Files
zed/crates/edit_prediction_button
feeiyu b9c705c72e Fix circular reference issue between EditPredictionButton and PopoverMenuHandle (#42351)
Closes #ISSUE

While working on issue #40906, I discovered that RemoteClient was not
being released after the remote project closed.
Analysis revealed a circular reference between EditPredictionButton and
PopoverMenuHandle.

Dependency Chain: RemoteClient → Project → ZetaEditPredictionProvider →
EditPredictionButton ↔ PopoverMenuHandle

<img width="400" height="300" alt="image"
src="https://github.com/user-attachments/assets/6b716c9b-6938-471a-b044-397314b729d4"
/>

a) EditPredictionButton hold the reference of PopoverMenuHandle 

https://github.com/zed-industries/zed/blob/dc16897144700e4f949347e4ba7b8ef05c0b8efc/crates/zed/src/zed.rs#L386-L394

b) PopoverMenuHandle hold the reference of Fn which capture
`Entity<EditPredictionButton>`

https://github.com/zed-industries/zed/blob/be5a67cbdac5c503aa2626d757c82f07484eeac4/crates/edit_prediction_button/src/edit_prediction_button.rs#L382-L389


https://github.com/zed-industries/zed/blob/edaf9e122cbd198eacfdb0041ddb6fdff438e620/crates/ui/src/components/popover_menu.rs#L376-L384


Release Notes:

- N/A
2025-11-10 16:52:03 +02:00
..
2025-10-17 18:58:14 +00:00