Om Chillure and Danilo Leal
6bf00800c6
Fix agent thread sidebar covering window buttons ( #54755 )
...
## Summary
Fixes an oversight in the agent threads archive sidebar's header: on
Linux and Windows it only accounted for macOS traffic lights, so the
custom window controls (minimize/maximize/close) rendered on top of the
sidebar. The main sidebar
(`crates/sidebar/src/sidebar.rs::render_sidebar_header`) already handles
this correctly — this PR mirrors that pattern in
`ThreadsArchiveView::render_header`.
### What changed
- `crates/agent_ui/src/threads_archive_view.rs`
- `render_header` now computes `traffic_lights`, `left_window_controls`,
and `right_window_controls` (matching `sidebar.rs`) and reserves space /
renders controls accordingly when not fullscreen.
- Added `render_left_window_controls` / `render_right_window_controls`
helpers that delegate to `platform_title_bar`.
- Imported `workspace::CloseWindow`.
- `crates/agent_ui/Cargo.toml`
- Added `platform_title_bar` dependency.
### Behavior
- macOS (sidebar on left): unchanged — traffic-light padding + divider.
- Linux/Windows, sidebar on left: renders left-side window controls
inside the header.
- Linux/Windows, sidebar on right: renders right-side window controls
inside the header.
- Fullscreen: no controls rendered, same as before.
#### Closes #54596
### Self-Review Checklist:
- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist )
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable
### Video
[Screencast from 2026-04-24
14-27-51.webm](https://github.com/user-attachments/assets/47009458-2acb-4b65-bff6-d25302a0342e )
Release Notes:
- Agent: Fixed the threads sidebar overlapping the window control
buttons on Linux and Windows.
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com >
2026-04-24 09:42:05 +00:00
..
2026-04-24 08:42:44 +00:00
2026-04-22 14:57:12 -07:00
2026-04-16 12:54:17 +00:00
2026-04-21 09:01:42 +00:00
2026-04-24 08:42:44 +00:00
2026-04-22 15:02:57 +00:00
2026-04-22 15:02:57 +00:00
2026-04-24 09:42:05 +00:00
2026-04-15 21:51:15 -03:00
2026-04-23 23:47:30 +00:00
2026-04-23 23:47:30 +00:00
2026-03-24 00:58:09 +01:00
2026-03-18 21:31:20 -04:00
2026-03-03 17:47:35 +01:00
2026-04-23 23:47:30 +00:00
2026-04-23 23:47:30 +00:00
2026-03-13 08:00:22 +00:00
2026-04-16 12:54:17 +00:00
2026-04-20 09:29:51 +00:00
2026-03-30 13:07:13 +00:00
2026-04-20 18:03:26 -07:00
2026-04-23 23:47:30 +00:00
2026-02-25 08:12:04 +01:00
2026-04-07 12:28:19 -03:00
2026-04-10 10:15:28 -04:00
2026-04-22 13:39:48 +00:00
2026-04-02 17:06:57 -03:00
2026-04-23 23:47:30 +00:00
2026-04-21 09:01:42 +00:00
2026-03-27 18:06:56 -07:00
2026-04-22 11:12:32 -06:00
2026-04-15 21:51:15 -03:00
2026-04-21 08:06:40 +00:00
2026-04-05 23:05:35 +01:00
2026-04-20 14:33:18 +02:00
2026-03-27 14:56:46 -07:00
2026-03-11 03:08:39 +00:00
2026-04-02 17:06:57 -03:00
2026-04-21 07:25:22 +00:00
2026-03-30 09:06:59 +00:00
2026-03-16 16:29:24 +00:00
2026-04-15 23:25:44 +00:00
2026-01-14 07:19:13 +00:00
2026-04-21 19:54:02 +00:00
2026-04-21 19:25:21 +00:00
2026-04-09 10:42:21 -03:00
2026-04-23 07:36:36 +00:00
2026-04-20 08:53:15 +00:00
2026-04-23 23:47:30 +00:00
2026-04-23 23:47:30 +00:00
2026-04-22 10:40:37 +00:00
2026-04-23 23:47:30 +00:00
2026-04-20 14:03:26 +03:00
2026-04-10 13:27:04 -04:00
2026-04-21 09:01:42 +00:00
2026-04-24 08:45:47 +00:00
2026-04-01 17:25:32 +00:00
2026-04-07 12:28:19 -03:00
2026-02-28 21:47:30 -05:00
2026-04-22 15:02:57 +00:00
2026-02-19 18:57:49 +01:00
2026-02-28 22:42:19 -05:00
2026-04-21 17:32:54 -04:00
2026-03-24 19:11:30 -04:00
2026-04-21 17:32:54 -04:00
2026-04-21 17:32:54 -04:00
2026-04-21 09:01:42 +00:00
2026-04-21 09:43:44 -07:00
2026-04-18 06:34:19 +00:00
2026-04-16 07:45:38 +00:00
2026-04-23 23:47:30 +00:00
2026-04-24 02:51:19 +00:00
2026-02-19 18:57:49 +01:00
2026-04-03 11:00:13 +00:00
2026-04-21 11:01:20 +02:00
2026-04-24 02:51:19 +00:00
2026-04-24 02:51:19 +00:00
2026-01-31 21:56:34 +00:00
2026-04-24 02:51:19 +00:00
2026-04-01 17:25:32 +00:00
2026-04-22 13:39:48 +00:00
2026-04-24 08:58:26 +00:00
2026-04-23 23:47:30 +00:00
2026-04-24 09:09:29 +00:00
2026-04-16 10:37:05 -04:00
2026-03-24 11:05:12 +00:00
2026-04-24 08:58:26 +00:00
2026-04-14 18:14:31 +02:00
2026-04-23 23:47:30 +00:00
2026-03-31 13:16:53 +00:00
2026-04-21 09:55:14 +02:00
2026-04-21 13:35:13 -04:00
2026-04-24 08:45:47 +00:00
2026-04-07 11:19:21 +05:30
2026-04-17 13:54:43 +02:00
2026-03-28 18:41:33 -04:00
2026-04-22 22:22:10 +00:00
2026-04-17 13:54:43 +02:00
2026-02-12 00:28:17 +00:00
2026-03-12 15:34:09 -07:00
2026-04-22 15:09:09 +01:00
2026-04-24 08:58:26 +00:00
2026-04-24 08:58:26 +00:00
2026-04-18 00:55:44 +02:00
2026-04-02 12:52:42 +00:00
2026-04-22 13:39:48 +00:00
2026-04-15 10:11:44 +02:00
2026-04-23 23:47:30 +00:00
2026-04-23 23:47:30 +00:00
2026-03-25 12:07:34 -06:00
2026-04-01 17:25:32 +00:00
2026-04-21 19:54:02 +00:00
2026-04-23 23:47:30 +00:00
2026-04-01 17:25:32 +00:00
2026-02-03 15:51:40 -05:00
2026-03-24 00:58:09 +01:00
2026-03-06 16:49:55 +00:00
2026-03-17 08:36:37 +01:00
2026-04-24 02:52:54 +00:00
2026-04-23 23:47:30 +00:00
2026-04-22 15:43:53 +05:30
2026-04-23 18:41:52 +00:00
2026-04-09 10:42:21 -03:00
2026-04-22 02:42:11 +00:00
2026-02-17 10:41:10 +00:00
2026-02-20 13:36:04 +00:00
2026-04-14 11:10:31 +00:00
2026-04-15 21:51:15 -03:00
2026-04-15 02:21:56 -04:00
2026-04-21 09:27:12 -03:00
2026-04-22 13:39:48 +00:00
2026-03-27 14:41:25 +01:00
2026-04-07 12:28:19 -03:00
2026-04-17 10:51:32 -04:00
2026-04-01 17:25:32 +00:00
2026-04-21 09:01:42 +00:00
2026-03-13 14:13:12 -03:00
2026-04-21 07:57:35 +02:00
2026-04-23 23:47:30 +00:00
2026-04-08 00:34:54 +00:00
2026-03-31 12:48:22 +03:00
2026-04-24 02:51:19 +00:00
2026-02-19 18:57:49 +01:00
2026-04-24 02:51:19 +00:00
2026-04-09 16:38:07 +00:00
2026-04-24 08:58:26 +00:00
2026-04-24 02:51:19 +00:00
2026-04-23 23:47:30 +00:00
2026-04-15 23:25:44 +00:00
2026-04-21 07:44:24 +00:00
2026-04-16 16:36:09 -07:00
2026-04-22 20:02:45 +03:00
2026-04-21 23:39:53 +00:00
2026-03-09 13:22:12 +01:00
2026-03-21 14:05:30 +01:00
2026-04-13 09:07:09 +00:00
2026-04-22 13:39:48 +00:00
2026-03-07 04:11:45 +00:00
2026-03-27 14:41:25 +01:00
2026-04-23 23:47:30 +00:00
2026-03-18 12:05:57 -07:00
2026-04-23 23:41:07 +00:00
2026-04-23 23:47:30 +00:00
2026-03-25 12:07:34 -06:00
2026-04-02 00:44:53 +00:00
2026-04-23 23:47:30 +00:00
2026-03-16 23:49:34 -04:00
2026-04-23 23:47:30 +00:00
2026-01-26 13:49:26 +00:00
2026-02-12 00:28:17 +00:00
2026-03-10 20:25:12 +00:00
2026-03-21 14:05:30 +01:00
2026-03-29 14:43:05 +00:00
2026-03-31 08:06:37 -06:00
2026-04-20 14:41:29 +02:00
2026-04-02 13:09:29 +00:00
2026-04-07 06:14:00 +00:00
2026-01-28 16:36:44 -08:00
2026-04-24 06:41:37 +00:00
2026-04-24 08:31:43 +00:00
2026-04-01 17:25:32 +00:00
2026-04-23 23:47:30 +00:00
2026-03-27 14:41:25 +01:00
2026-03-27 14:41:25 +01:00
2026-04-23 23:47:30 +00:00
2026-04-23 23:47:30 +00:00
2026-02-28 21:47:30 -05:00
2026-04-23 23:47:30 +00:00
2026-04-01 17:25:32 +00:00
2026-04-24 08:31:43 +00:00
2026-03-13 19:37:18 -03:00
2026-03-27 15:31:49 +00:00
2026-03-27 14:41:25 +01:00
2026-04-23 23:47:30 +00:00
2026-04-09 10:42:21 -03:00
2026-04-23 23:47:30 +00:00
2026-03-19 12:53:26 -04:00
2026-03-09 13:22:12 +01:00
2026-04-07 12:28:19 -03:00
2026-03-27 14:41:25 +01:00
2026-04-24 08:31:43 +00:00
2026-04-23 23:47:30 +00:00
2026-02-19 18:57:49 +01:00
2026-04-22 13:39:48 +00:00
2026-04-22 22:22:10 +00:00
2026-04-21 19:54:02 +00:00
2026-04-02 17:06:57 -03:00
2026-04-02 17:06:57 -03:00
2026-04-22 12:48:01 +00:00
2026-03-03 08:37:58 +00:00
2026-02-11 11:24:04 +00:00