Thanh NguyenandBen Kunkle
3cd051ac7c
Fixes #28339 ## What - Normalize cwd-relative path-like targets that include leading `..` before worktree lookup. - Update issue #28339 tests to expect `WorktreeExact` for local and remote resolution. ## Why - Prevent terminal links like `../foo/bar.txt` from creating invalid entries; resolve to the correct worktree file instead. ## How to test - `cargo test -p terminal_view issue_28339 -- --nocapture` - Manual: open a workspace, run `echo ../foo/bar.txt` from a subdir in the terminal, then cmd/ctrl-click and confirm the correct file opens. ## Risk - Low: only changes terminal path-like resolution for `..` paths; expected to match normalized behavior. ## Checklist - [x] Tests run (`cargo test -p terminal_view issue_28339 -- --nocapture`) - [x] Docs updated (not needed) - [x] Backwards compatibility considered Release Notes: - Fixed an issue where relative paths starting with `..` would not resolve correctly when clicking the link in the terminal --------- Co-authored-by: Ben Kunkle <ben.kunkle@gmail.com>
Design notes:
This crate is split into two conceptual halves:
- The terminal.rs file and the src/mappings/ folder, these contain the code for interacting with Alacritty and maintaining the pty event loop. Some behavior in this file is constrained by terminal protocols and standards. The Zed init function is also placed here.
- Everything else. These other files integrate the
Terminalstruct created in terminal.rs into the rest of GPUI. The main entry point for GPUI is the terminal_view.rs file and the modal.rs file.
ttys are created externally, and so can fail in unexpected ways. However, GPUI currently does not have an API for models than can fail to instantiate. TerminalBuilder solves this by using Rust's type system to split tty instantiation into a 2 step process: first attempt to create the file handles with TerminalBuilder::new(), check the result, then call TerminalBuilder::subscribe(cx) from within a model context.
The TerminalView struct abstracts over failed and successful terminals, passing focus through to the associated view and allowing clients to build a terminal without worrying about errors.
#Input
There are currently many distinct paths for getting keystrokes to the terminal:
-
Terminal specific characters and bindings. Things like ctrl-a mapping to ASCII control character 1, ANSI escape codes associated with the function keys, etc. These are caught with a raw key-down handler in the element and are processed immediately. This is done with the
try_keystroke()method on Terminal -
GPU Action handlers. GPUI clobbers a few vital keys by adding bindings to them in the global context. These keys are synthesized and then dispatched through the same
try_keystroke()API as the above mappings -
IME text. When the special character mappings fail, we pass the keystroke back to GPUI to hand it to the IME system. This comes back to us in the
View::replace_text_in_range()method, and we then send that to the terminal directly, bypassingtry_keystroke(). -
Pasted text has a separate pathway.
Generally, there's a distinction between 'keystrokes that need to be mapped' and 'strings which need to be written'. I've attempted to unify these under the '.try_keystroke()' API and the .input() API (which try_keystroke uses) so we have consistent input handling across the terminal