Maja Backman and Bennet Bo Fenner
a1e236f0c8
acp_thread: Shrink ACP terminal scrollback to used on exit ( #60019 )
...
# Objective
ACP agents (Cursor, Claude Code, Codex, etc.) start a display-only
`terminal::Terminal` for each bash tool call. After the call exits, the
terminal stays alive so that its output stays visible. But the
`alacritty` `Grid` keeps a `Storage` cache that's never reclaimed.
Across a long session this memory adds up.
Partially fixes #57099
## Solution
Added `Terminal::shrink_to_used`, called from the `Exit` branch of
`on_terminal_provider_event`. This calls `Grid::truncate()` on the
alacritty grid, shrinking the `Storage` cache portion while leaving
user-visible scrollback.
## Testing
- `cargo nextest run -p terminal
shrink_to_used_preserves_user_visible_scrollback` passes — exercises the
path with >10K rows of scrollback.
- `./script/clippy` clean.
- Manually verified: ran a noisy bash tool call via an ACP agent,
observed exit, then scrolled back through the output, no regression.
## Self-Review Checklist:
- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist )
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md )
guidelines)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable
Release Notes:
- Improved memory usage of ACP terminals after the tool call exits
---------
Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de >
2026-07-03 11:41:48 +00:00
..
2026-07-03 11:41:48 +00:00
2026-06-22 09:04:29 +00:00
2026-06-09 20:13:13 +00:00
2026-05-15 12:01:31 +00:00
2026-07-01 14:55:30 +00:00
2026-07-01 13:10:14 +00:00
2026-07-01 14:55:30 +00:00
2026-06-08 14:57:47 +00:00
2026-07-02 18:38:37 +00:00
2026-06-18 20:51:36 +00:00
2026-06-16 13:06:20 +00:00
2026-06-08 09:37:00 +00:00
2026-06-05 16:49:42 +00:00
2026-07-03 08:23:06 +00:00
2026-05-01 22:33:54 +00:00
2026-06-07 16:55:18 +00:00
2026-06-02 13:29:23 +00:00
2026-06-18 02:47:10 +00:00
2026-06-01 04:40:13 +00:00
2026-06-09 20:13:13 +00:00
2026-06-23 09:13:28 +00:00
2026-06-29 20:21:46 +00:00
2026-06-30 20:10:06 +00:00
2026-06-29 20:21:46 +00:00
2026-02-25 08:12:04 +01:00
2026-06-09 19:12:34 +00:00
2026-07-02 12:38:43 +00:00
2026-06-26 11:07:29 +00:00
2026-06-04 22:52:29 +00:00
2026-07-03 09:50:42 +00:00
2026-06-29 20:21:46 +00:00
2026-06-05 10:32:57 +00:00
2026-07-02 13:23:17 +00:00
2026-06-05 10:32:57 +00:00
2026-05-29 07:06:57 +00:00
2026-06-15 03:26:51 +00:00
2026-05-19 17:45:07 +00:00
2026-06-04 22:52:29 +00:00
2026-05-28 15:00:31 +00:00
2026-07-01 04:25:40 +00:00
2026-06-17 18:29:21 +00:00
2026-04-02 17:06:57 -03:00
2026-05-15 11:12:41 +00:00
2026-06-15 10:55:39 +00:00
2026-04-29 10:27:47 +00:00
2026-04-24 10:29:51 +00:00
2026-05-13 23:35:10 +00:00
2026-06-23 09:33:47 +00:00
2026-06-02 13:29:23 +00:00
2026-06-23 09:33:47 +00:00
2026-06-27 21:19:49 +00:00
2026-06-30 11:10:04 +00:00
2026-06-29 19:00:22 +00:00
2026-06-25 14:07:41 +00:00
2026-06-24 23:28:47 +00:00
2026-06-25 14:07:41 +00:00
2026-06-04 22:52:29 +00:00
2026-06-29 10:12:28 +00:00
2026-07-02 14:38:04 +00:00
2026-06-05 19:24:28 +00:00
2026-06-23 09:33:47 +00:00
2026-04-07 12:28:19 -03:00
2026-02-28 21:47:30 -05:00
2026-06-29 15:58:53 +00:00
2026-02-19 18:57:49 +01:00
2026-02-28 22:42:19 -05:00
2026-06-24 21:32:43 +00:00
2026-06-04 11:01:48 +00:00
2026-06-07 16:39:58 +00:00
2026-06-24 21:32:43 +00:00
2026-06-23 09:33:47 +00:00
2026-07-01 04:25:40 +00:00
2026-04-18 06:34:19 +00:00
2026-05-04 06:30:47 +00:00
2026-06-30 09:26:20 +00:00
2026-07-02 16:04:53 +00:00
2026-02-19 18:57:49 +01:00
2026-06-12 12:27:28 +00:00
2026-06-12 12:27:28 +00:00
2026-07-01 14:51:10 +00:00
2026-06-15 08:48:19 +00:00
2026-06-30 10:21:40 +00:00
2026-06-16 17:42:36 +00:00
2026-06-16 13:06:20 +00:00
2026-07-02 23:54:11 +00:00
2026-06-29 15:16:26 +00:00
2026-06-24 19:59:34 +00:00
2026-06-17 07:57:05 +00:00
2026-03-24 11:05:12 +00:00
2026-04-24 08:58:26 +00:00
2026-06-16 13:47:55 +00:00
2026-06-16 13:47:55 +00:00
2026-06-24 19:59:34 +00:00
2026-06-08 23:09:47 +00:00
2026-06-24 19:59:34 +00:00
2026-07-01 17:36:57 +00:00
2026-06-16 13:47:55 +00:00
2026-06-24 01:42:52 +00:00
2026-07-01 16:55:07 +00:00
2026-06-08 21:24:44 +00:00
2026-04-22 22:22:10 +00:00
2026-06-12 12:27:28 +00:00
2026-06-22 18:20:57 +00:00
2026-05-05 22:41:13 +00:00
2026-06-25 17:30:12 +00:00
2026-07-02 19:24:34 +00:00
2026-07-03 08:22:48 +00:00
2026-06-02 13:59:39 +00:00
2026-04-02 12:52:42 +00:00
2026-07-02 14:32:34 +00:00
2026-06-25 14:47:28 +00:00
2026-07-02 14:32:34 +00:00
2026-06-26 11:07:29 +00:00
2026-03-25 12:07:34 -06:00
2026-06-23 09:33:47 +00:00
2026-07-02 11:00:16 +00:00
2026-07-01 17:36:57 +00:00
2026-06-23 09:33:47 +00:00
2026-07-03 09:50:42 +00:00
2026-07-03 09:50:42 +00:00
2026-06-29 13:24:33 +00:00
2026-06-02 13:29:23 +00:00
2026-06-28 13:48:10 +00:00
2026-07-02 08:00:19 +00:00
2026-06-27 10:09:13 +00:00
2026-06-22 15:42:12 +00:00
2026-05-04 22:51:56 +00:00
2026-06-02 12:03:05 +00:00
2026-06-02 13:29:23 +00:00
2026-06-15 11:03:26 +00:00
2026-02-20 13:36:04 +00:00
2026-05-27 04:39:26 +00:00
2026-05-29 07:06:57 +00:00
2026-05-14 21:03:56 +00:00
2026-06-23 09:21:31 +00:00
2026-06-23 09:33:47 +00:00
2026-06-25 14:47:28 +00:00
2026-06-23 09:33:47 +00:00
2026-06-23 23:01:58 +00:00
2026-06-25 14:47:28 +00:00
2026-06-23 09:33:47 +00:00
2026-06-15 11:03:26 +00:00
2026-05-12 15:52:52 +00:00
2026-05-14 16:30:08 +00:00
2026-07-03 10:48:15 +00:00
2026-07-03 10:48:15 +00:00
2026-06-10 12:02:29 +00:00
2026-06-13 05:21:05 +00:00
2026-07-02 18:14:11 +00:00
2026-05-05 22:41:13 +00:00
2026-07-02 16:04:53 +00:00
2026-07-03 10:48:15 +00:00
2026-06-05 19:46:05 +00:00
2026-07-02 18:14:11 +00:00
2026-06-25 10:56:11 +00:00
2026-05-15 21:17:43 +00:00
2026-06-27 09:21:37 +00:00
2026-04-16 16:36:09 -07:00
2026-07-02 18:14:11 +00:00
2026-06-23 09:33:47 +00:00
2026-07-03 01:00:54 +00:00
2026-05-27 10:31:53 +00:00
2026-06-05 10:32:57 +00:00
2026-07-01 22:52:24 +00:00
2026-06-08 15:44:17 +00:00
2026-03-27 14:41:25 +01:00
2026-07-02 13:49:41 +00:00
2026-03-18 12:05:57 -07:00
2026-07-02 19:24:34 +00:00
2026-07-03 08:22:48 +00:00
2026-03-25 12:07:34 -06:00
2026-06-23 09:33:47 +00:00
2026-07-02 14:32:34 +00:00
2026-05-05 16:25:56 +00:00
2026-06-23 14:40:13 +00:00
2026-04-29 10:27:47 +00:00
2026-06-23 09:33:47 +00:00
2026-04-24 10:29:51 +00:00
2026-05-27 19:33:04 +00:00
2026-05-27 10:31:53 +00:00
2026-03-29 14:43:05 +00:00
2026-03-31 08:06:37 -06:00
2026-05-04 06:30:47 +00:00
2026-06-23 09:33:47 +00:00
2026-06-09 22:46:22 +00:00
2026-06-23 09:33:47 +00:00
2026-07-03 11:41:48 +00:00
2026-07-01 16:00:54 +00:00
2026-06-09 20:13:13 +00:00
2026-07-01 17:36:23 +00:00
2026-03-27 14:41:25 +01:00
2026-03-27 14:41:25 +01:00
2026-06-23 09:33:47 +00:00
2026-07-02 05:04:24 +00:00
2026-05-28 19:43:30 +00:00
2026-07-03 08:23:06 +00:00
2026-06-23 09:33:47 +00:00
2026-07-03 08:23:06 +00:00
2026-07-01 04:25:40 +00:00
2026-05-29 07:06:57 +00:00
2026-06-08 14:59:39 +00:00
2026-06-29 15:58:53 +00:00
2026-07-02 15:38:22 +00:00
2026-03-19 12:53:26 -04:00
2026-05-27 10:31:53 +00:00
2026-06-09 12:06:49 +00:00
2026-03-27 14:41:25 +01:00
2026-05-01 22:33:54 +00:00
2026-07-02 18:14:11 +00:00
2026-07-02 18:14:11 +00:00
2026-02-19 18:57:49 +01:00
2026-05-29 16:28:27 +00:00
2026-07-03 05:59:13 +00:00
2026-07-03 05:59:13 +00:00
2026-04-02 17:06:57 -03:00
2026-04-02 17:06:57 -03:00
2026-06-25 14:07:41 +00:00
2026-07-01 15:18:54 +00:00
2026-05-28 20:19:17 +00:00
2026-05-28 20:19:17 +00:00