Files
zed/crates
Eric Holk a6607cbdae acp_tools: Always capture ACP transport and stderr into the log ring (#54536)
Part of #54531.

Previously the log tap started disabled and only flipped on when someone
opened the ACP logs panel for the first time on a given connection. That
meant the common *'I noticed something is wrong with my agent, let me go
look at the logs'* workflow started with an empty pane \u2014 all the
traffic that led up to the problem was already gone.

This removes the `enabled` flag on `AcpLogTap` so capture is
unconditional. The backlog ring is still bounded at
`MAX_BACKLOG_MESSAGES` (2000), so memory is capped. The steady-state
cost is one channel send per transport/stderr line, which is negligible
compared to the JSON-RPC serialization that already happened to produce
the line.

Net diff is ~40 lines deleted from `acp_tools.rs` \u2014 the flag, its
accessors, the early-return in `emit`, and the `active_tap` bookkeeping
needed to enable it on first subscribe.

I confirmed with the author of the original opt-in design before making
this change.

Release Notes:

- N/A
2026-04-22 14:57:12 -07:00
..
2026-04-22 15:02:57 +00:00
2026-04-22 15:02:57 +00:00
2026-04-17 10:51:32 -04:00
2026-04-05 23:05:35 +01:00
2026-03-27 14:56:46 -07:00
2026-03-11 03:08:39 +00:00
2026-04-21 07:25:22 +00:00
2026-03-30 09:06:59 +00:00
2026-04-22 15:02:57 +00:00
2026-04-22 16:58:55 -04:00
2026-04-21 07:25:22 +00:00
2026-02-26 18:36:50 +01:00
…
2026-04-22 15:02:57 +00:00