yenru0/zed
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
f2f900bbd54df9b08f8e4909bcc6e092864883da
zed/crates
T
History
Michael Barth f2f900bbd5 lsp: Skip serializing of params if unit type (#46027) 
Closes #45994 

Per the JSON-RPC specification, `params` "MUST be provided as a
Structured value" or the member "MAY be omitted." See specification
here: https://www.jsonrpc.org/specification#request_object

The code was passing in unit `()` for params which serde_json was
serializing to `null` which is not valid.

This pulls request adds an `is_unit` function and annotates the `params`
fields in the `Request` and `Notification` structs with the following:
 ```rs
#[serde(default, skip_serializing_if = "is_unit")]
```

so that the field will be omitted if the type is unit. This does also introduce a `'static` bound to these structs.

> [!WARNING]
> While this seems to me like a simple change, I am not super familiar with Rust, please look at this PR with extra scrutiny. The last thing I want to do is break everyone's LSP integration.


Release Notes:
- LSP integrations: send language server shutdown requests with correct parameters
2026-01-22 15:06:02 +02:00
..
acp_thread
acp_thread: Rename resume to retry (#47370)
2026-01-22 11:39:46 +00:00
acp_tools
ui: Improve performance in the CopyButton component (#47292)
2026-01-21 13:40:42 -03:00
action_log
git: Side-by-side diff UI (#47349)
2026-01-22 02:31:14 -05:00
activity_indicator
remote: Support opening builtin host files in remote workspaces on wsl (#46910)
2026-01-15 15:21:57 +00:00
agent
acp_thread: Rename resume to retry (#47370)
2026-01-22 11:39:46 +00:00
agent_servers
acp: Optimize registry refresh (#47367)
2026-01-22 11:19:32 +00:00
agent_settings
Remove Burn Mode code (#46950)
2026-01-15 21:28:33 +00:00
agent_ui
agent: Clearer distinction that we are in Text Thread history (#47295)
2026-01-22 12:43:42 +00:00
agent_ui_v2
agent_ui: Defer spawning agents until the agent panel has been opened (#47355)
2026-01-22 10:18:13 +00:00
ai_onboarding
Remove legacy billing code (#46927)
2026-01-15 13:06:45 -05:00
anthropic
ep: Handle errored requests in Anthropic batches (#46351)
2026-01-08 10:59:03 +00:00
askpass
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
assets
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_command
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
assistant_slash_commands
agent_ui: Add @diagnostics mention to the thread (#42270)
2026-01-20 13:19:24 +00:00
assistant_text_thread
Fix nested request rate limiting deadlock for subagent edit_file (#47232)
2026-01-20 21:51:54 -05:00
audio
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
auto_update
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
auto_update_helper
auto_update: Ignore dir removal errors on windows (#42435)
2025-11-11 12:55:19 +00:00
auto_update_ui
remote: Support opening builtin host files in remote workspaces on wsl (#46910)
2026-01-15 15:21:57 +00:00
aws_http_client
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
bedrock
bedrock: Add Bedrock API key authentication support (#41393)
2025-12-17 12:54:57 +01:00
breadcrumbs
Multibuffer breadcrumbs toolbar redesign (#45547)
2026-01-06 09:42:00 -03:00
buffer_diff
git: Side-by-side diff UI (#47349)
2026-01-22 02:31:14 -05:00
call
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
channel
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
cli
Make zed --wait work with directories (#44936)
2025-12-16 01:22:41 +00:00
client
Remove legacy billing code (#46927)
2026-01-15 13:06:45 -05:00
clock
text: Improve panic messages with more information (#42072)
2025-11-06 09:16:45 +00:00
cloud_api_client
Use cloud for auto-update (#42246)
2025-11-10 23:00:55 -07:00
cloud_api_types
Remove legacy billing code (#46927)
2026-01-15 13:06:45 -05:00
cloud_llm_client
Introduce new predict_edits/v3 endpoint (#46960)
2026-01-16 02:16:34 +00:00
codestral
Introduce new predict_edits/v3 endpoint (#46960)
2026-01-16 02:16:34 +00:00
collab
ep_cli: Fix "Too many open files" errors (#47243)
2026-01-20 15:41:31 -05:00
collab_ui
ui: Improve performance in the CopyButton component (#47292)
2026-01-21 13:40:42 -03:00
collections
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
command_palette
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
command_palette_hooks
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
component
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
component_preview
ep_cli: Fix "Too many open files" errors (#47243)
2026-01-20 15:41:31 -05:00
context_server
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
copilot
Fix delay in Copilot completion (#46885)
2026-01-15 13:22:03 +01:00
copilot_chat
copilot: Un-globalify copilot + handle it more directly with EditPredictionStore (#46618)
2026-01-14 14:44:13 +00:00
copilot_ui
copilot: Un-globalify copilot + handle it more directly with EditPredictionStore (#46618)
2026-01-14 14:44:13 +00:00
crashes
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
credentials_provider
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
dap
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
dap_adapters
language: Add LanguageName::new_static to reduce allocations (#44380)
2025-12-08 19:57:02 +01:00
db
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
debug_adapter_extension
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
debugger_tools
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
debugger_ui
debugger: Fix crash when dragging pane items to split view (#46806)
2026-01-20 18:02:03 +00:00
deepseek
deepseek: Fix for max output tokens blocking completions (#45236)
2025-12-18 12:47:34 +00:00
denoise
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
dev_container
Devcontainer setup modal (#47021)
2026-01-16 15:20:48 -08:00
diagnostics
Implement Vim's tag stack (#46002)
2026-01-15 17:48:15 +00:00
docs_preprocessor
Remove zed dependency from docs_preprocessor (#45130)
2025-12-18 21:59:05 -05:00
edit_prediction
ep: Add a prompt with git-style merge markers (#47215)
2026-01-20 13:33:43 +00:00
edit_prediction_cli
ep: Don't log steps that took <500ms (#47371)
2026-01-22 12:17:55 +00:00
edit_prediction_context
Introduce new predict_edits/v3 endpoint (#46960)
2026-01-16 02:16:34 +00:00
edit_prediction_types
Add sweep acceptance tracking (#46199)
2026-01-06 17:20:25 -05:00
edit_prediction_ui
git: Side-by-side diff UI (#47349)
2026-01-22 02:31:14 -05:00
editor
project_panel: Show Reveal in File Manager on wsl (#47288)
2026-01-22 11:24:23 +00:00
encoding_selector
status_bar: Add encoding indicator (#45476)
2026-01-07 07:24:46 +00:00
eval
Fix nested request rate limiting deadlock for subagent edit_file (#47232)
2026-01-20 21:51:54 -05:00
eval_utils
Fix self-referential symbolic link (#45265)
2025-12-18 17:26:20 +01:00
explorer_command_injector
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
extension
extension_host: Fix extension rebuild building in release mode (#47165)
2026-01-19 19:58:10 +00:00
extension_api
extension api: Make server id types constructible, to ease writing tests (#45174)
2025-12-17 16:25:07 -08:00
extension_cli
extension_cli: Properly populate manifest with snippet location (#44425)
2025-12-08 21:49:26 +01:00
extension_host
extension_host: Fix extension rebuild building in release mode (#47165)
2026-01-19 19:58:10 +00:00
extensions_ui
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
feature_flags
User-defined slash commands (#46815)
2026-01-22 01:43:55 -05:00
feedback
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
file_finder
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
file_icons
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
fs
fs: Use public-api-only tests (#47149)
2026-01-22 10:22:29 +01:00
fs_benchmarks
fs: Reintroduce benchmarks crate (#40689)
2025-10-20 10:30:06 +00:00
fsevent
Fix Zed OOM-ing when macOS file descriptors become invalid (#45669)
2025-12-26 18:47:53 +00:00
fuzzy
fuzzy: Use lowercase representations for matrix size calculation (#44338)
2025-12-08 19:50:20 +01:00
git
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
git_hosting_providers
git_ui: Add CreatePullRequest action (#42959)
2026-01-05 16:15:21 +00:00
git_ui
git: Side-by-side diff UI (#47349)
2026-01-22 02:31:14 -05:00
go_to_line
Fix stale pending keybinding indicators on focus change (#44678)
2025-12-17 16:51:16 +00:00
google_ai
google_ai: Refactor token count methods in Google AI (#45184)
2025-12-17 20:12:40 -06:00
gpui
git: Side-by-side diff UI (#47349)
2026-01-22 02:31:14 -05:00
gpui_macros
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
gpui_tokio
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
html_to_markdown
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
http_client
Remove reqwest dependency from gpui (#44424)
2025-12-09 09:29:40 -08:00
http_client_tls
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
icons
acp: Allow installing ACP agents from the registry (#47218)
2026-01-20 14:06:21 +00:00
image_viewer
Support zooming and panning in the image viewer (#43944)
2026-01-21 22:48:30 +01:00
inspector_ui
ep_cli: Fix "Too many open files" errors (#47243)
2026-01-20 15:41:31 -05:00
install_cli
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
journal
multi_buffer: Typed MultiBufferOffset (#42707)
2025-11-19 22:00:58 +00:00
json_schema_store
Fix json-language-server not considering file_types from project settings (#46991)
2026-01-16 14:33:28 +00:00
keymap_editor
remote: Support opening builtin host files in remote workspaces on wsl (#46910)
2026-01-15 15:21:57 +00:00
language
git: Side-by-side diff UI (#47349)
2026-01-22 02:31:14 -05:00
language_extension
ztracing: Enable memory profiling and callstack sampling (#47052)
2026-01-17 19:29:19 +00:00
language_model
Fix nested request rate limiting deadlock for subagent edit_file (#47232)
2026-01-20 21:51:54 -05:00
language_models
language_models: Remove open-ai-reponses-api feature flag (#47317)
2026-01-21 19:35:08 +00:00
language_onboarding
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
language_selector
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
language_tools
git: Side-by-side diff UI (#47349)
2026-01-22 02:31:14 -05:00
languages
rust: Highlight enum variants as types (#45546)
2026-01-22 12:52:14 +01:00
line_ending_selector
Fix keybind hints flickering in certain scenarios (#40927)
2025-10-22 19:52:38 +00:00
livekit_api
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
livekit_client
livekit_client: Revert #46986 for macos (#46990)
2026-01-16 14:20:23 +00:00
lmstudio
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
lsp
lsp: Skip serializing of params if unit type (#46027)
2026-01-22 15:06:02 +02:00
markdown
ui: Improve performance in the CopyButton component (#47292)
2026-01-21 13:40:42 -03:00
markdown_preview
ui: Improve performance in the CopyButton component (#47292)
2026-01-21 13:40:42 -03:00
media
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
menu
ui: Add submenus to ContextMenu (#45743)
2025-12-30 07:49:01 -03:00
migrator
Remove Burn Mode code (#46950)
2026-01-15 21:28:33 +00:00
miniprofiler_ui
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
mistral
Update Mistral models context length to their recommended values (#45194)
2025-12-18 09:49:32 +00:00
multi_buffer
git: Side-by-side diff UI (#47349)
2026-01-22 02:31:14 -05:00
nc
smol: Use Unblock instead of Async for stdin, stdout and stderr handles (#46141)
2026-01-06 08:14:34 +00:00
net
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
node_runtime
acp: Allow running NPM agents from registry (#47291)
2026-01-21 14:52:44 +00:00
notifications
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
ollama
ollama: Fix tool calling (#42275)
2025-11-11 16:10:47 +01:00
onboarding
onboarding: Fix theme picker always updating theme based on system appearance (#47245)
2026-01-21 10:12:29 +00:00
open_ai
open_ai: Support reasoning content (#43662)
2026-01-21 10:08:59 +00:00
open_router
Fix Gemini 3 on OpenRouter (#43416)
2025-11-24 13:24:26 -05:00
outline
outline: Enable scrollbar in outline view picker (#46774)
2026-01-14 08:06:55 -03:00
outline_panel
project_panel: Show Reveal in File Manager on wsl (#47288)
2026-01-22 11:24:23 +00:00
panel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
paths
Introduce MVP Dev Containers support (#44442)
2025-12-10 12:10:43 -08:00
picker
ui: Make docs aside in pickers and context menu render centered to its trigger (#45868)
2025-12-30 13:29:44 -03:00
prettier
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
project
project_panel: Show Reveal in File Manager on wsl (#47288)
2026-01-22 11:24:23 +00:00
project_benchmarks
ep_cli: Fix "Too many open files" errors (#47243)
2026-01-20 15:41:31 -05:00
project_panel
project_panel: Show Reveal in File Manager on wsl (#47288)
2026-01-22 11:24:23 +00:00
project_symbols
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
prompt_store
prompt_store: Fix deleted rules from the rules library being restored after restart (#47323)
2026-01-22 02:44:47 +05:30
proto
project: Implement range formatting for remoting (#47194)
2026-01-20 09:10:18 +00:00
recent_projects
Fix config file watch task leak (#47246)
2026-01-20 15:58:35 -05:00
refineable
gpui: Make refining a Style properly refine the TextStyle (#42852)
2025-12-15 13:30:13 +00:00
release_channel
release_version: Do not use prerelease field (#43669)
2025-11-27 13:46:43 +00:00
remote
project_panel: Show Reveal in File Manager on wsl (#47288)
2026-01-22 11:24:23 +00:00
remote_server
remote_server: Fix remote project search include/exclude filters for multiple worktrees (#47280)
2026-01-21 16:16:03 +05:30
repl
ui: Improve performance in the CopyButton component (#47292)
2026-01-21 13:40:42 -03:00
reqwest_client
Remove reqwest dependency from gpui (#44424)
2025-12-09 09:29:40 -08:00
rich_text
Revert "sum_tree: Replace rayon with futures (#41586) (#41846)
2025-11-03 19:25:15 +00:00
rope
rope: Fix an unintentional panic (#47019)
2026-01-20 12:23:17 +00:00
rpc
Fix worktree trust handling of multiple projects on the same remote host (#45834)
2025-12-29 20:21:59 +00:00
rules_library
Fix nested request rate limiting deadlock for subagent edit_file (#47232)
2026-01-20 21:51:54 -05:00
scheduler
Restore run_with_clock_advancement (#46930)
2026-01-15 18:39:06 +00:00
schema_generator
Add project settings schema to schema_generator CLI (#44321)
2025-12-16 10:48:14 -05:00
search
Implement Vim's tag stack (#46002)
2026-01-15 17:48:15 +00:00
session
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
settings
worktree: Use public-api-only tests (#47152)
2026-01-22 10:22:04 +01:00
settings_content
agent_servers: Don't fill in unneeded fields in settings when auto-adding new agent servers (#47293)
2026-01-21 14:40:31 +00:00
settings_json
settings_ui: Show migration banner (#41112)
2025-10-27 10:13:26 -04:00
settings_macros
Fallible Settings (#42938)
2025-11-21 08:28:17 -07:00
settings_profile_selector
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
settings_ui
settings_ui: Remote project setting files support (#45292)
2026-01-20 14:29:55 -05:00
snippet
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
snippet_provider
Improve snippet parse error context (#46277)
2026-01-11 15:08:34 +02:00
snippets_ui
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
sqlez_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
story
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
storybook
Revert "Revert scheduler update (#46659)" (#46671)
2026-01-14 07:19:13 +00:00
streaming_diff
Revert "sum_tree: Replace rayon with futures (#41586) (#41846)
2025-11-03 19:25:15 +00:00
sum_tree
git: Side-by-side diff UI (#47349)
2026-01-22 02:31:14 -05:00
supermaven
collab: Remove Supermaven API key issuance (#46044)
2026-01-04 23:28:18 +00:00
supermaven_api
collab: Remove Supermaven API key issuance (#46044)
2026-01-04 23:28:18 +00:00
svg_preview
svg_preview: Detect SVG in single-file mode by checking file name (#45747)
2025-12-27 23:29:36 +00:00
system_specs
releases: Add build number to Nightly builds (#42990)
2025-11-24 13:34:04 +01:00
tab_switcher
tab_switcher: Fix missing preview on initial ctrl-shift-tab press (#44959)
2025-12-16 08:26:29 +00:00
task
Allow trailing commas in builtin JSONC schemas (#43854)
2025-12-04 15:37:32 -05:00
tasks_ui
gpui: Implement From<String> for ElementId (#44447)
2025-12-09 09:08:59 +01:00
telemetry
Fix telemetry (#42184)
2025-11-07 11:36:05 +00:00
telemetry_events
releases: Add build number to Nightly builds (#42990)
2025-11-24 13:34:04 +01:00
terminal
terminal: Fix fast scrolling during mouse mode (#45600)
2026-01-19 14:18:53 +01:00
terminal_view
Split settings content into its own crate (#46845)
2026-01-15 18:10:21 +00:00
text
Fix inverted char boundary check causing invalid offsets (#47112)
2026-01-19 09:08:45 +01:00
theme
Split settings content into its own crate (#46845)
2026-01-15 18:10:21 +00:00
theme_extension
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
theme_importer
Split settings content into its own crate (#46845)
2026-01-15 18:10:21 +00:00
theme_selector
Allow dynamic set_theme based on Appearance (#42812)
2025-12-01 20:52:57 -07:00
time_format
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
title_bar
git_picker: Make the unified version of it available through the title bar (#47151)
2026-01-19 12:37:40 -03:00
toolchain_selector
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
ui
ui: Improve performance in the CopyButton component (#47292)
2026-01-21 13:40:42 -03:00
ui_input
ui_input: Only render number field border on focus (#46165)
2026-01-07 10:52:51 +00:00
ui_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
ui_prompt
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
util
remote: Support opening builtin host files in remote workspaces on wsl (#46910)
2026-01-15 15:21:57 +00:00
util_macros
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vercel
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
vim
Fix Visual mode flip on project search (#44284)
2026-01-22 00:11:29 +00:00
vim_mode_setting
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
watch
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
web_search_providers
Remove workspace-hack (#40216)
2025-10-17 18:58:14 +00:00
which_key
Add Vim-like Which-key Popup menu (#43618)
2025-12-17 11:53:48 -07:00
workspace
workspace: Add close project menu item (#47365)
2026-01-22 12:15:24 +01:00
worktree
worktree: Use public-api-only tests (#47152)
2026-01-22 10:22:04 +01:00
worktree_benchmarks
gpui: Actually remove the Result from AsyncApp (#45809)
2026-01-07 12:48:24 -08:00
x_ai
Add support for Grok 4.1 Fast models in xAI provider (#43419)
2025-12-08 16:38:34 +01:00
zed
workspace: Add close project menu item (#47365)
2026-01-22 12:15:24 +01:00
zed_actions
acp: Allow installing ACP agents from the registry (#47218)
2026-01-20 14:06:21 +00:00
zed_env_vars
Enable configuring edit prediction providers through the settings UI (#44505)
2025-12-13 11:06:30 -05:00
zeta_prompt
ep: Add a prompt with git-style merge markers (#47215)
2026-01-20 13:33:43 +00:00
zlog
zlog: Fix dynamic mod path filtering (#44296)
2025-12-06 17:56:49 +00:00
zlog_settings
Automate settings registration (#42238)
2025-11-07 22:27:14 +00:00
ztracing
ztracing: Enable memory profiling and callstack sampling (#47052)
2026-01-17 19:29:19 +00:00
ztracing_macro
adds tracing for instrumenting non-async functions (#44147)
2025-12-05 17:23:06 +00:00