Make all fragmentPref use fade anim

app/src/main/java/com/hippo/ehviewer/ui/fragment/BasePreferenceFragment.java

@@ -22,9 +22,12 @@ import android.os.Bundle;
 
 import androidx.annotation.Nullable;
 import androidx.annotation.StringRes;
+import androidx.fragment.app.Fragment;
+import androidx.fragment.app.FragmentTransaction;
 import androidx.preference.Preference;
 import androidx.preference.PreferenceFragmentCompat;
 
+import com.hippo.ehviewer.R;
 import com.hippo.ehviewer.ui.SettingsActivity;
 
 
@@ -56,6 +59,22 @@ public class BasePreferenceFragment extends PreferenceFragmentCompat
 
     }
 
+    @Override
+    public boolean onPreferenceTreeClick(Preference preference) {
+        String key = preference.getKey();
+        try {
+            Fragment classObj = (Fragment)Class.forName(key).newInstance();
+            requireActivity().getSupportFragmentManager()
+                    .beginTransaction()
+                    .setTransition(FragmentTransaction.TRANSIT_FRAGMENT_FADE)
+                    .replace(R.id.fragment, classObj)
+                    .addToBackStack(null)
+                    .commitAllowingStateLoss();
+        } catch (ClassNotFoundException | IllegalAccessException | java.lang.InstantiationException ignored) {
+        }
+        return true;
+    }
+
     private void setTitle(@StringRes int string) {
         requireActivity().setTitle(string);
     }

app/src/main/java/com/hippo/ehviewer/ui/fragment/SettingsFragment.java

@@ -33,24 +33,6 @@ public class SettingsFragment extends BasePreferenceFragment {
         addPreferencesFromResource(R.xml.settings_headers);
     }
 
-    @Override
-    public boolean onPreferenceTreeClick(Preference preference) {
-        String key = preference.getKey();
-        try {
-            Fragment classObj = (Fragment)Class.forName(key).newInstance();
-            requireActivity().getSupportFragmentManager()
-                    .beginTransaction()
-                    .setTransition(FragmentTransaction.TRANSIT_FRAGMENT_FADE)
-                    .replace(R.id.fragment, classObj)
-                    .addToBackStack("1")
-                    .commitAllowingStateLoss();
-        } catch (ClassNotFoundException | IllegalAccessException | java.lang.InstantiationException e) {
-            e.printStackTrace();
-            return false;
-        }
-        return true;
-    }
-
     @Override
     public int getFragmentTitle() {
         return R.string.settings;

app/src/main/res/xml/advanced_settings.xml

@@ -80,8 +80,7 @@
         app:iconSpaceReserved="false" />
 
     <Preference
-        android:fragment="com.hippo.ehviewer.ui.fragment.HostsFragment"
-        android:key="custom_hosts_2"
+        android:key="com.hippo.ehviewer.ui.fragment.HostsFragment"
         android:summary="@string/settings_advanced_custom_hosts_summary"
         android:title="@string/settings_advanced_custom_hosts_title"
         app:iconSpaceReserved="false" />

app/src/main/res/xml/eh_settings.xml

@@ -39,15 +39,13 @@
         app:iconSpaceReserved="false" />
 
     <com.hippo.ehviewer.preference.SignInRequiredPreference
-        android:fragment="com.hippo.ehviewer.ui.fragment.UConfigFragment"
-        android:key="u_config"
+        android:key="com.hippo.ehviewer.ui.fragment.UConfigFragment"
         android:summary="@string/settings_u_config_summary"
         android:title="@string/settings_u_config"
         app:iconSpaceReserved="false" />
 
     <com.hippo.ehviewer.preference.SignInRequiredPreference
-        android:fragment="com.hippo.ehviewer.ui.fragment.MyTagsFragment"
-        android:key="my_tags"
+        android:key="com.hippo.ehviewer.ui.fragment.MyTagsFragment"
         android:summary="@string/settings_my_tags_summary"
         android:title="@string/settings_my_tags"
         app:iconSpaceReserved="false" />
@@ -145,8 +143,7 @@
         app:url="@string/settings_eh_tag_translations_source_url" />
 
     <Preference
-        android:fragment="com.hippo.ehviewer.ui.fragment.FilterFragment"
-        android:key="filter"
+        android:key="com.hippo.ehviewer.ui.fragment.FilterFragment"
         android:summary="@string/settings_eh_filter_summary"
         android:title="@string/settings_eh_filter"
         app:iconSpaceReserved="false" />