image_viewer: Remove PDF annotation and form editing
Congratsbot / check-author (push) Skipped
Congratsbot / congrats (push) Waiting for needed jobs
deploy_nightly_docs / deploy_docs (push) Skipped
run_tests / orchestrate (push) Skipped
run_tests / check_style (push) Skipped
run_tests / clippy_windows (push) Skipped
run_tests / clippy_linux (push) Skipped
run_tests / clippy_mac (push) Skipped
run_tests / clippy_mac_x86_64 (push) Skipped
run_tests / run_tests_windows (push) Skipped
run_tests / run_tests_linux (push) Skipped
run_tests / run_tests_mac (push) Skipped
run_tests / miri_scheduler (push) Skipped
run_tests / doctests (push) Skipped
run_tests / check_workspace_binaries (push) Skipped
run_tests / build_visual_tests_binary (push) Skipped
run_tests / check_wasm (push) Skipped
run_tests / check_dependencies (push) Skipped
run_tests / check_docs (push) Skipped
run_tests / check_licenses (push) Skipped
run_tests / check_scripts (push) Skipped
run_tests / check_remote_server_linux_x86_64 (push) Skipped
run_tests / check_remote_server_mac_aarch64 (push) Skipped
run_tests / check_remote_server_windows_x86_64 (push) Skipped
run_tests / check_postgres_and_protobuf_migrations (push) Skipped
run_tests / extension_tests (push) Skipped
run_tests / tests_pass (push) Skipped
Congratsbot / check-author (push) Skipped
Congratsbot / congrats (push) Waiting for needed jobs
deploy_nightly_docs / deploy_docs (push) Skipped
run_tests / orchestrate (push) Skipped
run_tests / check_style (push) Skipped
run_tests / clippy_windows (push) Skipped
run_tests / clippy_linux (push) Skipped
run_tests / clippy_mac (push) Skipped
run_tests / clippy_mac_x86_64 (push) Skipped
run_tests / run_tests_windows (push) Skipped
run_tests / run_tests_linux (push) Skipped
run_tests / run_tests_mac (push) Skipped
run_tests / miri_scheduler (push) Skipped
run_tests / doctests (push) Skipped
run_tests / check_workspace_binaries (push) Skipped
run_tests / build_visual_tests_binary (push) Skipped
run_tests / check_wasm (push) Skipped
run_tests / check_dependencies (push) Skipped
run_tests / check_docs (push) Skipped
run_tests / check_licenses (push) Skipped
run_tests / check_scripts (push) Skipped
run_tests / check_remote_server_linux_x86_64 (push) Skipped
run_tests / check_remote_server_mac_aarch64 (push) Skipped
run_tests / check_remote_server_windows_x86_64 (push) Skipped
run_tests / check_postgres_and_protobuf_migrations (push) Skipped
run_tests / extension_tests (push) Skipped
run_tests / tests_pass (push) Skipped
The annotation and form-filling surface is being dropped, so remove it end to end rather than leave it half-maintained. pdf_viewer loses the editing APIs and everything only they used: add_ink_annotation, add_highlight_annotation, delete_annotation, apply_form_edits, the form widget and annotation extraction, the PdfFormWidget/PdfFormEdit/PdfAnnotation types, the document serialization helper, and the pdfium guards and constants those functions were the sole users of. Rendering, text, links, outline and metadata are untouched; annotation rendering stays on because it paints markup already embedded in viewed documents. image_viewer loses the tool palette, form widget overlays, inline form editors, pen canvas, option menus, the annotate toolbar button, the Undo Edit and Delete Annotation actions and their key bindings, plus the associated state and handlers. Text selection, find, links, thumbnails, outline, properties, rotation, presentation and Save a Copy remain.
This commit is contained in:
1 parent
4ac68ee5af
commit
935e2b0bd0
7 files changed
+29
-2476
No files matched your search
@@ -1630,7 +1630,6 @@
|
||||
"ctrl-g": "image_viewer::FindNext",
|
||||
"ctrl-shift-g": "image_viewer::FindPrevious",
|
||||
"ctrl-s": "image_viewer::SaveCopyAs",
|
||||
"ctrl-z": "image_viewer::UndoEdit",
|
||||
"ctrl-shift-t": "image_viewer::ToggleTextPanel"
|
||||
},
|
||||
},
|
||||
|
||||
@@ -1682,7 +1682,6 @@
|
||||
"cmd-g": "image_viewer::FindNext",
|
||||
"cmd-shift-g": "image_viewer::FindPrevious",
|
||||
"cmd-s": "image_viewer::SaveCopyAs",
|
||||
"cmd-z": "image_viewer::UndoEdit",
|
||||
"cmd-shift-t": "image_viewer::ToggleTextPanel"
|
||||
},
|
||||
},
|
||||
|
||||
@@ -1605,7 +1605,6 @@
|
||||
"ctrl-g": "image_viewer::FindNext",
|
||||
"ctrl-shift-g": "image_viewer::FindPrevious",
|
||||
"ctrl-s": "image_viewer::SaveCopyAs",
|
||||
"ctrl-z": "image_viewer::UndoEdit",
|
||||
"ctrl-shift-t": "image_viewer::ToggleTextPanel"
|
||||
},
|
||||
},
|
||||
|
||||
File diff suppressed because it is too large.
Load diff
@@ -52,8 +52,9 @@ A native, high performance PDF viewing engine and GPUI workspace item engineered
|
||||
## 2. Scope Boundaries
|
||||
|
||||
- **Continuous Scroll & Text Selection**: Supports fluid high frame rate document browsing and visual text selection.
|
||||
- **Excluded from initial scope**:
|
||||
- **Excluded from scope**:
|
||||
- Interactive PDF form field editing.
|
||||
- Annotation authoring, editing and deletion.
|
||||
- *Rationale*: Delivering an ultra fast, stutter free viewing experience with zero UI locks takes precedence.
|
||||
|
||||
---
|
||||
|
||||
@@ -22,9 +22,8 @@ pub mod watcher;
|
||||
pub use cache::{CacheKey, CacheablePage, DEFAULT_MEMORY_BUDGET_BYTES, PageLruCache, RenderedPage};
|
||||
pub use document::{PageDimensions, PdfDocument};
|
||||
pub use pdfium::{
|
||||
PdfAnnotationColor, PdfAnnotationInfo, PdfAnnotationKind, PdfCharBox, PdfDocumentDetails,
|
||||
PdfFormEdit, PdfFormWidget, PdfFormWidgetKind, PdfLinkAnnotation, PdfMetadata, PdfOutlineItem,
|
||||
PdfPageDetails, PdfTextSegment, PdfiumEngine,
|
||||
PdfCharBox, PdfDocumentDetails, PdfLinkAnnotation, PdfMetadata, PdfOutlineItem, PdfPageDetails,
|
||||
PdfTextSegment, PdfiumEngine,
|
||||
};
|
||||
pub use rasterizer::{LuminosityToneMapper, PageRasterizer, RasterizerOptions};
|
||||
pub use settings::{DefaultZoomPolicy, PageLayoutMode, PdfViewerSettings};
|
||||
|
||||
File diff suppressed because it is too large.
Load diff
Reference in new issue
Block a user