Remove occasionally incorrect expectation (#10358)

This panic has occured a handful of times, I think it must be the case
that:

1. Item is dropped outside of an update loop
2. The next update is this one

In that case no flush effects will have called the release observers
yet, but we cannot upgrade the WeakModel because the ref count is 0



Release Notes:

- Fixed a (rare) panic while collaborating
This commit is contained in:
Conrad Irwin authored and GitHub committed 2024-04-10 11:34:54 -04:00
1 parent 7abb63cfda
commit fc10201ce2
1 file changed
+1 -3
+1 -3
View File
@@ -453,9 +453,7 @@ impl<T: Item> ItemHandle for View<T> {
}
workspace.update(&mut cx, |workspace, cx| {
let item = item.upgrade().expect(
"item to be alive, otherwise task would have been dropped",
);
let Some(item) = item.upgrade() else { return };
workspace.update_followers(
is_project_item,
proto::update_followers::Variant::UpdateView(