Nathan Sobo
25476bcbc6
Move handling of modifier changes to new View hook
2022-10-16 12:47:48 -06:00
Nathan Sobo
6c870a17a6
Start on view-level dispatch approach for keyboard events
2022-10-16 11:46:31 -06:00
Nathan Sobo
5cde1e8f36
Refine mouse event naming
2022-10-16 11:18:58 -06:00
Nathan Sobo
3e27b81d17
Merge pull request #1762 from zed-industries/less-click-and-hover-invalidation
...
Reduce unnecessary view invalidations related to mouse events
2022-10-16 10:23:54 -06:00
Nathan Sobo
d2431d9540
Merge pull request #1761 from zed-industries/mouse-region-view-invalidation
...
Remove unconditional invalidation when calling mouse region handlers
2022-10-14 18:31:23 -06:00
Nathan Sobo and Max Brunsfeld
f80f306ad8
Avoid re-rendering editor on mouse move
...
Only notify editor when clearing highlights if there were highlights to
begin with.
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2022-10-14 18:27:55 -06:00
Nathan Sobo and Max Brunsfeld
4aff034ff5
Only invalidate parent view on click/hover if we read that state when rendering
...
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2022-10-14 18:09:15 -06:00
Max Brunsfeld
f2f6cbb57b
Merge pull request #1760 from zed-industries/invite-unknown-platform
...
Include waitlist entries w/ unknown platform when summarizing and sending invites
2022-10-14 16:24:48 -07:00
Max Brunsfeld
a841af67c3
Revert unnecessary logic for fetching invites' platform_unknown flag
2022-10-14 16:13:38 -07:00
Nathan Sobo
5c0f9e5c51
Remove unconditional invalidation when calling mouse region handlers
...
We want invalidation to opt-in as much as possible.
If you want a view to re-render, you need to call `cx.notify`.
2022-10-14 17:06:46 -06:00
Max Brunsfeld
f03687bfcd
Include waitlist entries w/ unknown platform when summarizing and sending invites
2022-10-14 15:20:23 -07:00
Mikayla Maki
420bd22225
Merge pull request #1759 from zed-industries/move-page-up-down
...
Move page up / down
2022-10-14 14:02:27 -07:00
Mikayla Maki
7ae0ac843a
Finished implementing vscode, emacs, and mac style pageup/down. Added keybindings ctrl-v, alt-v for emacs up/down and shift-pageup, shift-pagedown for vscode style. Also improved incorporated pageup/down into context menus
2022-10-14 13:52:30 -07:00
Max Brunsfeld
669898eef8
v0.60.4
2022-10-14 12:44:22 -07:00
Max Brunsfeld and Mikayla Maki
7c96e0d6e6
Add MovePageUp and MovePageDown editor commands
...
Co-authored-by: Mikayla Maki <mikayla@zed.dev >
2022-10-14 12:36:46 -07:00
Max Brunsfeld and Mikayla Maki
db9bd61f0d
Enable auto-scroll when moving cursors in Editor::handle_input
...
Co-authored-by: Mikayla Maki <mikayla@zed.dev >
2022-10-14 11:32:22 -07:00
Max Brunsfeld
299f18a971
Merge pull request #1758 from zed-industries/editor-paint-panic
...
Consolidate calculation of editor's visible row range
2022-10-14 10:47:16 -07:00
Max Brunsfeld
023bd6ee8f
Merge pull request #1757 from zed-industries/detect-unshare
...
Clear project's shared state upon every disconnection
2022-10-14 10:44:35 -07:00
Max Brunsfeld and Nathan Sobo
eb0c82b733
Consolidate calculation of editor's visible row range
...
We think this will fix a panic that was occuring in `paint_highlighted_range`
due to an out-of-bounds read into the line layouts. We think doing essentially the same
calculation in two different ways with floating point numbers might have
caused a different end row to be calculated in 2 different code paths.
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-10-14 10:37:44 -07:00
b8f6ec852b
Clear project's shared state upon every disconnection
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
Co-authored-by: Antonio Scandurra <as-cii@zed.dev >
2022-10-14 10:17:59 -07:00
Max Brunsfeld
93419ef049
0.60.3
2022-10-14 09:35:57 -07:00
Max Brunsfeld
971c74dc28
Merge pull request #1756 from zed-industries/autoclose-wrong-closing-bracket
...
Avoid skipping over a different closing bracket in autoclose
2022-10-14 09:34:33 -07:00
Max Brunsfeld
e5d18be301
Avoid skipping over a different closing bracket in autoclose
2022-10-14 09:30:30 -07:00
Nathan Sobo
069acfbcfb
0.60.2
2022-10-13 16:26:26 -06:00
Nathan Sobo
6b9221502c
Merge pull request #1754 from zed-industries/fix-list-scroll
...
Pass the current view id when painting List's mouse region instead of 10
2022-10-13 16:24:55 -06:00
Nathan Sobo
58e309df78
Pass the current view id value when painting List's mouse region
...
Previously, a dummy value was being passed. I think this slipped in accidentally.
2022-10-13 15:57:19 -06:00
Max Brunsfeld
eb66efff1e
v0.60.1
2022-10-13 10:00:07 -07:00
Antonio Scandurra
b1554b147e
Merge pull request #1752 from zed-industries/allow-inviting-users-to-another-guest-project
...
Allow inviting users to a project that was shared by someone else
2022-10-13 17:58:22 +01:00
7165bc1606
Allow inviting users to a project that was shared by someone else
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
Co-Authored-By: Max Brunsfeld <max@zed.dev >
2022-10-13 18:48:14 +02:00
Antonio Scandurra
cf03032b14
Merge pull request #1749 from zed-industries/child-view-panic
...
Prevent `ChildView` from retaining an otherwise dropped view
2022-10-13 15:45:53 +01:00
Antonio Scandurra and Nathan Sobo
542480da5b
Improve error message when rendering a child view for a dropped view
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-10-13 16:40:52 +02:00
Antonio Scandurra
e80af89a1c
Add unit test for ChildView
2022-10-13 15:59:52 +02:00
Antonio Scandurra
42e2594058
Log view name alongside error in ChildView
2022-10-13 15:44:01 +02:00
Antonio Scandurra
b591d77494
Avoid panicking if child view points to a view that was not rendered
2022-10-13 15:11:57 +02:00
Antonio Scandurra
60a4912abb
Prevent ChildView from retaining an otherwise dropped view
2022-10-13 15:04:57 +02:00
Antonio Scandurra
2c5e5912ca
Merge pull request #1747 from zed-industries/fix-clangd-error
...
Fix error on clangd when `compile-commands.json` is present
2022-10-13 10:16:10 +01:00
Antonio Scandurra
e2e3a266a5
Fix error on clangd when compile-commands.json is present
...
The language server was failing because we were forgetting to provide
a `jsonrpc` field for responses to requests coming from the lsp.
2022-10-13 11:10:23 +02:00
Antonio Scandurra
b5e00a45e8
Merge pull request #1745 from zed-industries/contact-popover-focus
...
Fix some issues with contact popover focus
2022-10-13 08:37:14 +01:00
Antonio Scandurra
bfe97fbc6a
Merge pull request #1746 from zed-industries/maintain-buffer-identity-across-renames
...
Preserve buffer identity when underlying entry temporarily disappears
2022-10-13 08:36:21 +01:00
Antonio Scandurra
a5303a0517
Use fake file system for buffer identity test
2022-10-13 09:33:55 +02:00
Antonio Scandurra
8ce65dc16a
Preserve buffer identity when underlying entry temporarily disappears
2022-10-13 09:10:10 +02:00
Antonio Scandurra
32acc49762
Add test to ensure buffer identity is kept across Project::rename
2022-10-13 08:17:35 +02:00
Max Brunsfeld and Nathan Sobo
c78d3dbd17
Dismiss contacts popover when clicking outside, even w/o focus change
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-10-12 17:55:11 -07:00
Max Brunsfeld and Nathan Sobo
9432d9e110
Remove spurious focus of contact popover when opening it
...
Co-authored-by: Nathan Sobo <nathan@zed.dev >
2022-10-12 17:39:44 -07:00
Mikayla Maki
aa370ab924
Merge pull request #1743 from zed-industries/new-settings-writing
...
Improved settings writing to be strongly typed and based on settings file content diffs
2022-10-12 17:18:48 -07:00
Mikayla Maki
db9c72232f
Fixed settings
2022-10-12 17:11:47 -07:00
Mikayla Maki and
d6b49291d9
Improved settings writing to be strongly typed and based on settings file content diffs
...
Co-Authored-By: kay@zed.dev
2022-10-12 17:05:23 -07:00
Kay Simmons
f2eeab02cd
Merge pull request #1740 from zed-industries/fix-dock-focus-issues
...
Fix Dock infinite loop
2022-10-12 16:19:09 -07:00
K Simmons
d861198c16
Update gpui focus test to match the new removal of intermediate focus filtering
2022-10-12 15:57:29 -07:00
Max Brunsfeld
1a05611aa6
Merge pull request #1742 from zed-industries/deps-fixes
...
Re-export basic text types from text and language crates, remove unused deps from collab
2022-10-12 15:56:55 -07:00
Nathan Sobo