Commit Graph
2501 Commits
Author SHA1 Message Date
Antonio ScandurraandNathan Sobo 4b656d7d91 Add unit test for Project::definition
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2022-01-21 15:05:25 +01:00
Antonio ScandurraandNathan Sobo 1548886a29 Hide weak worktrees in the file finder
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2022-01-21 14:39:35 +01:00
Antonio ScandurraandNathan Sobo e2badda58f Remove weak handles when worktree gets dropped
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2022-01-21 14:34:14 +01:00
Antonio ScandurraandNathan Sobo 620b6bd990 Allow observing the release of entities
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2022-01-21 14:34:14 +01:00
Antonio Scandurra ba96ca0b1b Remove weak worktrees from project when nobody references them
Also, avoid showing them in the project panel as well as in the
contacts panel.
2022-01-21 14:34:14 +01:00
Antonio Scandurra 6042bf0744 Unregister worktree when its last handle to it gets released 2022-01-21 14:34:14 +01:00
Nathan Sobo a58caa2eb9 Disable the nav history when selecting a definition in a different buffer
When jumping between different buffers, we don't care about the cursor's previous location. When navigating backward, we want to jump directly to the site of the jump.
2022-01-20 21:33:16 -07:00
a8684fe004 Make navigation history work with project diagnostics
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2022-01-20 18:21:48 +01:00
Antonio Scandurra 3c1b7e26c9 WIP 2022-01-20 18:11:37 +01:00
Antonio ScandurraandNathan Sobo 5229abd541 Center selections when going to definition
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2022-01-20 17:33:07 +01:00
Antonio ScandurraandNathan Sobo ade37e946c Make "go to definition" work in project diagnostics
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2022-01-20 17:30:30 +01:00
Antonio ScandurraandNathan Sobo 88cc335db3 Change GoToDefinition binding to F12
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2022-01-20 15:43:02 +01:00
Antonio Scandurra 390bf8adb7 🎨 2022-01-20 15:26:10 +01:00
Antonio Scandurra b7b59c94fa WIP: Start on a GoToDefinition action for the editor 2022-01-20 12:26:04 +01:00
Antonio Scandurra 911d6f708c Start on Project::definition that only works locally (for now) 2022-01-20 12:11:41 +01:00
Antonio Scandurra 9e52506098 Advertise link capability in LSP 2022-01-20 12:10:01 +01:00
Antonio Scandurra 95f2e7b36c Omit worktree id when emitting Event::DiskBasedDiagnosticsUpdated
Sometimes we will have more than one worktree associated with the same
language server and in that case it's unclear which worktree id we should
report an event for.
2022-01-20 10:13:27 +01:00
Antonio Scandurra ef78225a5d Return a Task<Result<()>> in {ItemView,Buffer,MultiBuffer}::save 2022-01-20 09:58:24 +01:00
Antonio Scandurra 897e0b4a7a Return a task from Workspace::save_active_item
This required changing our approach to OS prompts and this commit greatly
simplifies that. We now avoid passing a callback and return a simple future
instead. This lets callers spawn tasks to handle those futures.
2022-01-20 09:51:29 +01:00
Max Brunsfeld 7d9d20a661 Get tests passing, centralize more diagnostic logic in Project 2022-01-19 16:32:55 -08:00
Max Brunsfeld 09719a0bfc Always open buffers via the project 2022-01-19 14:48:54 -08:00
Max Brunsfeld 575def57db Move logic for starting language servers to the project 2022-01-19 14:05:06 -08:00
Antonio Scandurra 7ad9b2b0d7 WIP 2022-01-19 19:28:41 +01:00
Antonio Scandurra 87e844a6f0 Remove unused languages field from LocalWorktree 2022-01-19 18:46:17 +01:00
Antonio ScandurraandMax Brunsfeld 841827f873 Route save_as via the Project
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2022-01-19 18:44:48 +01:00
Antonio Scandurra a2822f54bb Remove unused languages field on LocalWorktree 2022-01-19 17:27:00 +01:00
Antonio Scandurra c5fe187527 Replace project_path with project_entry in workspace::{Item, ItemView} 2022-01-19 15:56:04 +01:00
Antonio Scandurra 6702f048eb Rename Navigation to NavHistory 2022-01-19 15:27:34 +01:00
Antonio Scandurra 948817fb79 Merge pull request #349 from zed-industries/navigation-history
Add a navigation history
2022-01-19 09:02:23 +01:00
Max Brunsfeld bfe0cefa38 Avoid changing selection in buffer navigation dialogs
If an editor has highlighted_rows, autoscroll it to reveal those rows instead of
its cursor positions.
2022-01-18 17:29:33 -08:00
Max Brunsfeld 3bb1cdc35c Limit the storage used by the navigation history 2022-01-18 16:31:48 -08:00
Max Brunsfeld ef52932a63 Add a unit test for navigation behavior at the editor level 2022-01-18 16:25:22 -08:00
Max Brunsfeld babaabb941 Push to navigation history based on jump distance instead of time 2022-01-18 15:02:49 -08:00
Antonio Scandurra d7d30d3303 Experiment with a more general way of pushing editor navigation entries 2022-01-18 18:03:10 +01:00
Antonio Scandurra 1dd722265b Ensure focus is transferred when opening the first item in pane 2022-01-18 10:15:37 +01:00
Antonio Scandurra 7031fcdeb4 Fix double borrow error when closing an item 2022-01-18 10:13:50 +01:00
Antonio Scandurra db88a7c2c8 🔥 2022-01-18 10:10:16 +01:00
Antonio Scandurra ec7a343f4f Introduce a test to verify navigation 2022-01-18 10:03:56 +01:00
Antonio Scandurra f9ebc363a2 Use offset to restore navigation position if anchor can't be resolved 2022-01-18 09:59:28 +01:00
Antonio Scandurra 1a4c868701 Skip past entries in the navigation history that can't be re-opened 2022-01-18 09:58:40 +01:00
Max Brunsfeld 25b150c560 Navigate to previous positions in editors when using navigation history 2022-01-17 16:01:52 -08:00
Max Brunsfeld 74b79486f2 WIP - Reopen closed items when going back in nav history 2022-01-17 10:46:47 -08:00
Antonio ScandurraandMax Brunsfeld 3f2ea66672 Populate backward/forward stacks upon item deactivation
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2022-01-17 18:57:31 +01:00
Antonio Scandurra d1f435bcdc Start laying the foundation for a per-pane navigation system 2022-01-17 16:59:06 +01:00
Antonio Scandurra 70b951a950 Delete unused pane::State struct 2022-01-17 15:27:54 +01:00
Antonio Scandurra 514cbb1c27 Remove accidentally committed test.md file 2022-01-17 11:12:54 +01:00
Antonio Scandurra 1755d881d7 Merge pull request #347 from zed-industries/fix-sharing-after-unsharing
Cleanup worktrees' shared state when unsharing
2022-01-17 11:11:23 +01:00
Antonio Scandurra 732e413832 Cleanup worktrees' shared state when unsharing 2022-01-17 10:58:49 +01:00
Antonio Scandurra c0ff5fbf60 Merge pull request #346 from zed-industries/missing-notify
Always re-render outline view when changing the active selection
2022-01-17 10:30:11 +01:00
Antonio Scandurra b9d8def8cc Always re-render outline view when changing the active selection 2022-01-17 10:17:11 +01:00