Commit Graph
15954 Commits
Author SHA1 Message Date
Nate Butler 7f3e724723 Add github icon 2023-12-18 12:56:57 -05:00
Nate Butler 2ddcf7fab0 Fix implementation of full_width and icon_position in button 2023-12-18 12:56:50 -05:00
Nate Butler 859f528faa Start on collab panel empty state 2023-12-18 11:33:37 -05:00
Julia 09d81e83fe Unbork project search focus (#3691)
I got a little too clever for my own good with these focus handles
originally lol

Release Notes:

- N/A
2023-12-18 10:54:11 -05:00
Julia 6270cd8e10 Unbork project search focus 2023-12-18 10:44:34 -05:00
Kirill Bulatov f7f4dd2e32 Fix worktree panic for out-of-worktree files being opened (#3690)
Fixes
https://zed-industries.slack.com/archives/C04S6T1T7TQ/p1702865855729989

Release Notes:

- Fixed certain files excluded from worktrees causing panics when being
opened
2023-12-18 13:30:46 +02:00
Kirill Bulatov b7fab01c6e Do not panic on non-worktree file indexing 2023-12-18 13:10:26 +02:00
Antonio Scandurra 13f2ce26d9 Introduce an Arena to allocate and deallocate frame-related structs more cheaply (#3689)
Picture worth a thousand words:


![before-after](https://github.com/zed-industries/zed/assets/482957/0aa92baf-f1cd-485e-a234-6d8f8b63a79a)

Note how having an area makes a substantial amount of frames between
0.5ms and 1ms faster (15-20% faster frames).

Release Notes:

- N/A
2023-12-18 11:16:07 +01:00
Antonio Scandurra 2dd438dd5c Use a closure to allocate structs onto the Arena
This is a trick borrowed from Bumpalo that helps LLVM understand
it should instantiate the object directly on the heap, as opposed to
doing so on the stack and then moving it.
2023-12-18 10:56:37 +01:00
Max Brunsfeld b8a1441277 Fix following bugs (#3688)
* Follow command didn't work, because follow task was dropped
* An extra div prevented titlebar facepiles from rendering correctly
2023-12-15 16:34:08 -08:00
Max Brunsfeld 2b2fb8f6a8 Remove div around all avatars in titlebar facepile 2023-12-15 16:26:56 -08:00
Max Brunsfeld e8df9cc77b Fix accidental drop of following task. Add back FollowNextCollaborator 2023-12-15 16:15:31 -08:00
Marshall Bowers 9afdc91750 Only apply scroll correction in uniform_list when already scrolled (#3687)
This PR fixes an issue where the scroll correction added to the uniform
list in 25572d835c was being applied even
if the list wasn't scrolled at all.

This manifested in the project panel starting with an incorrect scroll
offset that would disappear once scrolled.

It seems like we should only need to apply this scroll correction when
the list is already scrolled.

Release Notes:

- N/A
2023-12-15 17:53:10 -05:00
Marshall Bowers 91711830d9 Fix channel filter input (#3686)
This PR fixes the channel filter in the collab panel not showing up.

Release Notes:

- N/A
2023-12-15 17:03:59 -05:00
Max Brunsfeld 6208ff9106 Don't scroll List on scroll wheel events outside of its bounds (#3685) 2023-12-15 13:47:40 -08:00
Max Brunsfeld 67318b54e4 Don't scroll List on scroll wheel events outside of its bounds 2023-12-15 13:38:49 -08:00
Marshall Bowers 28f15c0ddd Add --release flag to script/zed-local (#3684)
This PR adds support for the `--release` flag to `script/zed-local`.

This allows you to run a local build of Zed in release mode, which can
be useful when needing to profile things or do other performance work.

Release Notes:

- N/A
2023-12-15 16:38:40 -05:00
Max Brunsfeld 3933762a6c Pane rendering fixes (#3683)
* Fix a bug where a pane's leader info was not rendered if the pane was
part of a split
* Fix a crash when zooming a pane, due to duplicate render of that view.
2023-12-15 13:34:34 -08:00
Marshall Bowers fbaac8857f Add support for --release flag to zed-local script 2023-12-15 16:28:23 -05:00
Marshall Bowers 908408901e Format zed-local script 2023-12-15 16:27:58 -05:00
Max Brunsfeld 997aa3154d Avoid duplicate render of a pane when it is zoomed 2023-12-15 13:26:48 -08:00
Max Brunsfeld 2829ad7286 Always render panes via pane_group::Member::render
Remove distinct code path for rendering panes in a PaneAxis, as this dropped
the logic for rendering the leader border and info box.
2023-12-15 13:26:36 -08:00
Max Brunsfeld a8918d85cc Enable zoom (#3668)
* [x] zoom
* [x] pane tests
2023-12-15 12:58:03 -08:00
Nate Butler dd03f4aaa0 Editor UI Cleanup (#3676)
[[PR Description]]

TODO: 
- [x] Style fold marker
- [x] Editor - Code action icon too large, should use muted color,
should have tooltip
- [ ] Style inline assistant
    - Prompt text gets cut off veritcally
- [x] Line height on inline assist editor isn't tall enough
- Nate: This is my fault due to the line height (relative: 1) we are
setting on non-buffer editors. I'll look into this.
- [ ] Style diagnostic hover (right now it's an opaque box on some
themes)
    - Nate: This needs status tints, we are working on it
- [ ] Hovering over a symbol shows a dialogue that appears underneath
the scroll-bar

Release Notes:

- N/A
2023-12-15 15:49:55 -05:00
Nate Butler 54e65e465a Style fold control 2023-12-15 15:41:53 -05:00
Conrad Irwin 714dfed0d5 fix theme selector gaps (#3682)
- Don't scroll beyond end of uniform list
- Restore position of uniform_list padding

[[PR Description]]

Release Notes:

- N/A
2023-12-15 13:27:17 -07:00
Nathan Sobo 6fca4b26d8 Merge branch 'main' into arena 2023-12-15 13:22:19 -07:00
Conrad Irwin f244d88993 Fix bug where vim commands were copied on each update_matches (#3680)
In zed1, the array of commands was recalculated on every update_matches,
In zed2 it's cached before we change the focus.

Release Notes:

- N/A
2023-12-15 13:20:10 -07:00
Conrad Irwin b3b1cb4a08 Restore position of uniform_list padding
It should be inside the scrollable area.
2023-12-15 13:18:51 -07:00
Max Brunsfeld 1e27d2c818 Enable pane tests 2023-12-15 12:00:58 -08:00
Conrad Irwin 25572d835c Don't scroll beyond end of uniform list 2023-12-15 12:54:12 -07:00
Max Brunsfeld f8258f04e4 When a dock is zoomed, don't render it in its normal place 2023-12-15 11:48:25 -08:00
Max Brunsfeld 0d19aa54a8 Fix logic for activating panel when re-docking it 2023-12-15 11:47:01 -08:00
Marshall Bowers f77eff3045 Fix toolbar width (#3681)
This PR fixes an issue with the toolbar width introduced in #3666.

The lack of a flex container was making the toolbar contents not take up
the full width, and thus not positions items correctly along its main
axis.

Release Notes:

- N/A
2023-12-15 14:44:29 -05:00
Max Brunsfeld 5f343b34b7 Render zoomed item in the workspace 2023-12-15 11:19:59 -08:00
Marshall Bowers 4f2f6b9a05 Rework collab panel rendering to use gpui::list (#3678)
This PR reworks the rendering of the collab panel to use `gpui::list`,
so that we don't render any items that are not visible on the screen.

In the process we also fixed some bugs in the channel list:

- Fixed the context menu for channels not deploying when activated via
keyboard
- Fixed drag and drop for channels
- Made it so when navigating the collab panel via keyboard the list only
scrolls enough to reveal the next item when navigating to an item that
is currently off-screen

Release Notes:

- N/A
2023-12-15 14:11:24 -05:00
Mikayla Maki 47bc85223f Fix editor mouse event dispatch stealing clicks (#3679)
[[PR Description]]

Release Notes:

-
2023-12-15 11:06:31 -08:00
Marshall Bowers 88c13b48f7 Format code 2023-12-15 14:03:49 -05:00
Marshall BowersandMax f186389611 Fix channel drag and drop
Also add the ability to unnest a channel by dragging it to the "Channels"
header. This is currently not working due to a collab server issue.

Co-authored-by: Max <max@zed.dev>
2023-12-15 14:01:24 -05:00
Conrad Irwin 633f23536a Fix bug where vim commands were copied on each update_matches
In zed1, the array of commands was recalculated on every update_matches,
In zed2 it's cached before we change the focus.
2023-12-15 11:59:06 -07:00
Marshall BowersandMax 316ecb52d8 Only scroll enough to reveal the next channel if it isn't visible
Co-authored-by: Max <max@zed.dev>
2023-12-15 13:50:51 -05:00
Mikayla 118894f502 Fix editor mouse event dispatch 2023-12-15 10:26:41 -08:00
Marshall BowersandMax 00fea0ce57 Fix positioning of the inline context menu
Added a new `bounds_for_item` for `ListState`.

Co-authored-by: Max <max@zed.dev>
2023-12-15 13:24:30 -05:00
Mikayla Maki e2fe6a69bf Fix center pane resizing (#3677)
Release Notes:

- N/A
2023-12-15 10:15:58 -08:00
Mikayla 923dd84bd4 Fix pane resizing 2023-12-15 10:07:10 -08:00
Antonio Scandurra 29a063903f Use a safe API for Arena 2023-12-15 19:03:37 +01:00
Nate Butler 103bddafd6 Update size of code action indicator and show when active 2023-12-15 12:29:33 -05:00
Nate Butler 6a78cd7bc6 Revert change to single line editor height 2023-12-15 12:22:33 -05:00
Marshall Bowers 2c56fd5bf0 Perform scroll interactions through the ListState 2023-12-15 12:10:40 -05:00
Nate Butler 5407216c11 Update fold_indicator render 2023-12-15 12:09:06 -05:00