yenru0/zed
1
0 Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
16,697 Commits 5 Branches 0 Tags
a3f79d31f8a57ac215db2a28e2de3629591ffbcb
Commit Graph
16697 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Conrad Irwin a3f79d31f8 Ensure focus_in and focus_out fire on window activation 
Also:
- Rename cx.on_blur to cx.on_focus_lost
- Fix a bug where notify calls in focus handlers were ignored
- Fix a bug where vim would get stuck in the wrong mode when switching
  windows
 2024-01-09 20:55:00 -07:00
Conrad Irwin 5e464ccde4 Fix panic in set_scroll_anchor_remote (#3987) 
If the remote sends us an invalid scroll position, we should not panic.

Release Notes:

- Fix a panic receiving scroll positions out of order
 2024-01-09 14:39:06 -07:00
Kirill Bulatov 32fb4f9507 Do not dismiss buffer search when any modal is present (#3988) 
Release Notes:

- Fixed buffer search being dismissed not after the modals are
 2024-01-09 23:36:32 +02:00
Kirill BulatovandPiotr Osiewicz 48c15abf2b Do not dismiss buffer search when any modal is present 
Co-authored-by: Piotr Osiewicz <piotr@zed.dev>
 2024-01-09 23:29:05 +02:00
Marshall Bowers fac822cac4 Rename Shape to AvatarShape (#3986) 
This PR renames the `Shape` enum to `AvatarShape`, since it seems pretty
specific to `Avatar`s.

Release Notes:

- N/A
 2024-01-09 16:21:27 -05:00
Conrad Irwin ff33f08095 Fix panic in set_scroll_anchor_remote 2024-01-09 14:19:48 -07:00
Marshall Bowers b3678463e8 Clean up references in doc comments in ui and theme crates (#3985) 
This PR cleans up a number of references in doc comments in the `ui` and
`theme` crates so that `rustdoc` will link and display them correctly.

Release Notes:

- N/A
 2024-01-09 15:22:36 -05:00
Mikayla Maki d5da000fa6 Add a test to catch keybinding bounds issue (#3966) 
Add a test to catch regressions to
https://github.com/zed-industries/zed/pull/3964

Thanks for the idea @ConradIrwin 

TODO:

- [ ] Fix immediate stack overflow in test

Release Notes:

- N/A
 2024-01-09 12:03:48 -08:00
Nate Butler d3fae03bcb Add some Theme and UI docs (#3979) 
Documents a number of items in the `theme` and `ui` crates.

Release Notes:

- N/A
 2024-01-09 15:00:21 -05:00
Mikayla 9a9abd176e Fixed test 2024-01-09 11:52:03 -08:00
Julia b41cd2b4de Take into account multiple scroll deltas within a single frame (#3982) 
Release Notes:

- Fixed an issue where all but the last scroll event would be dropped if
there were multiple within a single frame.
 2024-01-09 14:51:26 -05:00
Nate Butler d3bc7c4096 Document more enums 2024-01-09 14:50:04 -05:00
Marshall Bowers 1736e06a6b Clean up references in doc comments (#3983) 
This PR cleans up a number of references in doc comments so that
`rustdoc` will link and display them correctly.

Release Notes:

- N/A
 2024-01-09 14:48:48 -05:00
JuliaandAntonio Scandurra 02204107c6 Take into account multiple scroll deltas within a single frame 
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
 2024-01-09 14:32:43 -05:00
Nate Butler 18392dc79d Document free functions 2024-01-09 14:21:29 -05:00
Nate Butler 6161cc7486 Restore removed ColorScaleStep ALL that was breaking the build 2024-01-09 14:16:50 -05:00
Nate Butler a7b3045ed1 Document ui crate traits 2024-01-09 14:15:25 -05:00
Nathan Sobo 612d814e35 Add documentation to GPUI (#3980) 
🍐d with @conrad @mikayla-maki on covering some of the surface area.

Release Notes:

- N/A
 2024-01-09 12:10:53 -07:00
Nathan SoboandConrad 7147f22f41 Even more docs 
Co-authored-by: Conrad <conrad@zed.dev>
 2024-01-09 12:02:12 -07:00
Nate Butler d0b2e4f3a0 Fix unclosed delimiter 2024-01-09 13:52:11 -05:00
Nate Butler 9b2ec46772 Add label docs 2024-01-09 13:49:27 -05:00
Nate ButlerandAntonio Scandurra 7255dba0ea Initial button documentation 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
 2024-01-09 13:39:15 -05:00
Nathan SoboandConrad 0df36210bf Add more API docs 
Co-Authored-By: Conrad <conrad@zed.dev>
 2024-01-09 11:16:56 -07:00
Nate ButlerandAntonio Scandurra bab7704414 Document components/avatar 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
 2024-01-09 13:04:55 -05:00
Nathan SoboConradMikayla
 		009d46bd90 Add a bunch of docs 
Co-Authored-By: Conrad <conrad@zed.dev>
Co-Authored-By: Mikayla <mikayla@zed.dev>
 2024-01-09 11:02:57 -07:00
Nate ButlerandAntonio Scandurra 58e5f805bf Document UI modules 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
 2024-01-09 12:57:12 -05:00
Nate ButlerandAntonio Scandurra 0521c1f80e Start documenting Theme crate 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
 2024-01-09 12:49:56 -05:00
Piotr Osiewicz 6f97b30b45 chore: cfg(test) a test in rpc. (#3978) 
The test in particular should be included in our release binary at
present. :/
Release Notes:

- N/A
 2024-01-09 18:00:54 +01:00
Marshall Bowers f2585dcaa6 Remove Default impl for StatusColors (#3977) 
This PR removes the `Default` impl for `StatusColors`.

Since we need default light and dark variants for `StatusColors`, we
can't use a single `Default` impl.

Release Notes:

- N/A
 2024-01-09 11:31:19 -05:00
Piotr Osiewicz ef01883833 search: Remove newlines from query used for tab_content. (#3976) 
Fixes https://github.com/zed-industries/community/issues/2388
Release Notes:

- Fixed tab content of project search overflowing the tab for queries
with newlines.
 2024-01-09 17:16:25 +01:00
Marshall Bowers 6c1b134e2f gpui: Add SharedUrl type (#3975) 
This PR adds a `SharedUrl` type to GPUI.

It's just like a `SharedString`, but for denoting that the contained
value is a URL.

Mainlined from @nathansobo's GPUI blog post:
https://github.com/zed-industries/zed/pull/3968/files#diff-7ee75937e2daf7dd53f71b17698d8bd6d46993d06928d411781b9bd739b5f231R9-R12

Release Notes:

- N/A
 2024-01-09 10:55:49 -05:00
Marshall Bowers 84dd2c6954 Rename IconElement to just Icon (#3974) 
This PR renames the `IconElement` component to just `Icon`.

This better matches the rest of our components, as `IconElement` was the
only one using this naming convention.

The `Icon` enum has been renamed to `IconName` to free up the name.

I was trying to come up with a way that would allow rendering an
`Icon::Zed` directly (and thus make the `IconElement` a hidden part of
the API), but I couldn't come up with a way to do this cleanly.

Release Notes:

- N/A
 2024-01-09 10:11:20 -05:00
Piotr Osiewicz 57eb962929 Add a missing default value to docs (#3973) 
Release Notes:

- N/A
 2024-01-09 12:20:52 +01:00
Kirill Bulatov 0f6af99423 Remove some todo!'s from the code (#3972) 
Release Notes:

- N/A
 2024-01-09 11:45:09 +02:00
Kirill Bulatov f83721fd05 Remove some todo!'s 2024-01-09 11:36:36 +02:00
Kirill Bulatov 1885228457 Remove dbg! usage from tests 2024-01-09 10:08:27 +02:00
Marshall Bowers 438c13747a Add stories for collab notifications (#3967) 
This PR adds some basic stories for collab notifications to make them
easier to work on:

<img width="1076" alt="Screenshot 2024-01-08 at 9 43 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/4a0adcfa-1134-49c2-b589-74ac1d52af4c">

I factored out a `CollabNotification` component that defines the general
structure for one of these notifications, and this is the component that
we use in the stories, with representative values passed to it to
simulate the different instances of the notification.

We can't use the actual notification components in the stories due to
their data dependencies.

Release Notes:

- N/A
 2024-01-08 21:54:59 -05:00
Mikayla 0c311e8e1f Attempt to write test 2024-01-08 18:21:54 -08:00
Marshall Bowers 47741c956c Stop propagation when deploying the context menu for a project panel entry (#3965) 
This PR fixes an issue where right-click on any project panel entry
would cause the context menu on the root of the project panel
(introduced in #3954) to deploy.

We need to stop propagation in the handler on the inner project panel
list items so that the click event doesn't bubble up the tree.

Release Notes:

- Fixed an issue where the project panel was always deploying the root
context menu rather than on the clicked item.
 2024-01-08 20:51:14 -05:00
Mikayla Maki f4b81e69cc Fix off by 1 error when computing available key bindings (#3964) 
Fixes https://github.com/zed-industries/community/issues/2379

Release Notes:

- Fixed issue where keybindings in some context menus would not show
reliably.
 2024-01-08 17:40:43 -08:00
Mikayla 9284bc64f0 Fix off by 1 error when computing available key bindings 2024-01-08 17:30:24 -08:00
Mikayla Maki e86debfe99 Restore the terminal cursor settings (#3963) 
As it says on the tin

Release Notes:

- Restored the terminal cursor's I-beam and pointing hand settings
 2024-01-08 16:07:08 -08:00
Mikayla 97a6c4153d Restore the terminal cursor settings 2024-01-08 16:02:39 -08:00
Mikayla Maki 0378bd8ca4 Restore the active pane magnification feature (#3961) 
As it says on the tin

Release Notes:

- Restored the active pane magnification setting.
 2024-01-08 15:58:57 -08:00
Conrad Irwin 45ebeeaf8e Fix assets build (#3962) 
Release Notes:

- N/A
 2024-01-08 16:57:36 -07:00
Conrad Irwin 6b3c8d0e83 Fix assets build 2024-01-08 16:53:01 -07:00
Mikayla 799181b636 Restore the active pane magnification feature 2024-01-08 15:48:31 -08:00
Marshall Bowers 8a91419ec2 Tighten up feedback modal design (#3960) 
This PR tightens up the design of the feedback dialog:

<img width="680" alt="Screenshot 2024-01-08 at 6 20 50 PM"
src="https://github.com/zed-industries/zed/assets/1486634/8dc0e687-2459-4ab3-b69f-b610ce067ef1">

<img width="682" alt="Screenshot 2024-01-08 at 6 21 24 PM"
src="https://github.com/zed-industries/zed/assets/1486634/f0730710-16e0-4d61-a919-60874442186a">

Release Notes:

- Improved the design of the feedback dialog.
 2024-01-08 18:28:37 -05:00
Conrad Irwin 90b8f8ac56 Push branch before tag 2024-01-08 15:49:03 -07:00
Conrad Irwin f9e2d8940b collab 0.35.0 2024-01-08 15:47:59 -07:00