Commit Graph
15641 Commits
Author SHA1 Message Date
Marshall Bowers c0abf7e355 Use editorOverviewRuler.border for the scrollbar track border 2023-12-11 16:54:53 -05:00
Marshall Bowers 142e7b60e2 Use the editor background for the scrollbar track background 2023-12-11 16:39:26 -05:00
Marshall Bowers 23d774a230 Draw the scrollbar track left border 2023-12-11 16:39:00 -05:00
Marshall Bowers b0f8016aac Use tab.inactiveForeground from VS Code for muted text color (#3593)
This PR updates the `theme_importer` to pull in the
`tab.inactiveForeground` color from VS Code to use as the muted text
color.

Release Notes:

- N/A
2023-12-11 15:57:47 -05:00
Marshall Bowers 53b76a6dd2 Fix inactive tab styles (the verbose way) (#3591)
This PR fixes the inactive tab style to properly show the label using
the muted text color.

I went about fixing this in the most direct way possible, but the
solution leaves a lot to be desired, IMO. I plan to explore some ideas
on how we can improve the state of styling the tab content without
having the same styles repeated all over the place and subsequently
out-of-sync.

Release Notes:

- N/A
2023-12-11 15:42:17 -05:00
Conrad Irwin 547c4cebb8 vim-flight entertainment (#3574)
- vim2 compiling (but mostly commented out)
- More code written, similar lack of workingness so far

Still todo:
[ ] Figure out the focus/blur stuff
[ ] Uncoment more code
[ ] Fix VimTestContext
[ ] Uncomment the tests

Release Notes:

- N/A
2023-12-11 12:11:13 -07:00
Joseph T. Lyons d4e62e761e Fix rustfmt in feedback_modal.rs 2023-12-11 13:56:58 -05:00
Conrad Irwin baa3f7710a COmment out tests again for now 2023-12-11 11:40:54 -07:00
Marshall Bowers d83c40c77f Fix color for selections in scrollbar (#3590)
This PR fixes an issue where we weren't using the right color for
displaying selections within the scrollbar.

Release Notes:

- N/A
2023-12-11 13:34:29 -05:00
Joseph T. Lyons ba2227b743 Use copy button for copy channel link (#3589)
Release Notes:

- N/A
2023-12-11 13:22:36 -05:00
Joseph T. Lyons 364020e45d Use copy button for copy channel link 2023-12-11 13:14:29 -05:00
Marshall Bowers 54d483cf5f Style scrollbars with theme colors (#3588)
This PR updates the styling of scrollbars in the editor to use the theme
colors.

Release Notes:

- N/A
2023-12-11 13:06:43 -05:00
Joseph T. Lyons ca8b2094b9 Adjust nightly to build twice a day 2023-12-11 13:05:16 -05:00
Conrad Irwin 53d9129d36 Clear out easy todo!()s 2023-12-11 11:00:55 -07:00
Marshall Bowers f36490091e Pull more scrollbar colors from VS Code 2023-12-11 12:59:03 -05:00
Marshall Bowers b1330f68e8 Style scrollbar when using diff markers 2023-12-11 12:58:55 -05:00
Marshall Bowers abeca44202 Map scrollbar colors from VS Code themes 2023-12-11 12:49:54 -05:00
Marshall Bowers f294387f7d Pull scrollbar colors from theme 2023-12-11 12:47:29 -05:00
Conrad Irwin 3ae69b7596 Remove warnigns 2023-12-11 10:45:27 -07:00
Nate Butler 39ba0b128e Extend theme colors (#3587)
[[PR Description]]

Title

Release Notes:

- N/A
2023-12-11 12:34:06 -05:00
Conrad Irwin 29ca3fa9af Merge branch 'main' into vim2 2023-12-11 10:19:18 -07:00
Conrad Irwin 00d9519d6f Revert actions! changes 2023-12-11 10:19:03 -07:00
Antonio Scandurra 37b570895b Fire click event only when using left button (#3584)
Release Notes:

- N/A
2023-12-11 18:00:13 +01:00
Nate ButlerandMarshall Bowers 6e8127cc76 Add new colors to themes
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-12-11 12:00:12 -05:00
Conrad Irwin 8947e52bb2 actions3 (#3586)
- Fix action registrations

Release Notes:

- N/A
2023-12-11 09:48:57 -07:00
Nate ButlerandMarshall Bowers 15b076cb9f Add new colors to One Dark
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-12-11 11:43:49 -05:00
Conrad Irwin 0d96e964ef Merge branch 'main' into vim2 2023-12-11 09:38:23 -07:00
Nate Butler dfae7ca733 Add new color defs 2023-12-11 11:30:43 -05:00
Conrad Irwin 300d1c4f49 Fix some action registrations 2023-12-11 09:29:10 -07:00
Piotr Osiewicz 2e92fc73b9 Project search2 (#3585)
Semantic search and tests are gonna be shipped in a separate PR.

Release Notes:

- N/A
2023-12-11 17:20:13 +01:00
Piotr Osiewicz 214846690a Comment out the tests 2023-12-11 16:52:12 +01:00
Piotr Osiewicz ba57516632 Merge branch 'main' into project_search2 2023-12-11 16:47:48 +01:00
Piotr Osiewicz 37256d6e5d Add Editor::Tab and CycleMode actions 2023-12-11 16:39:17 +01:00
Antonio Scandurra 6f7d1e5baa Fire click event only when using left button 2023-12-11 16:20:46 +01:00
Piotr Osiewicz 35314d3305 fixup! Further warnings churn 2023-12-11 15:54:36 +01:00
Piotr Osiewicz 31e76db16d Further warnings churn 2023-12-11 15:53:19 +01:00
Piotr Osiewicz 96eb0d9fa3 Fix up warnings (automatic) 2023-12-11 15:48:42 +01:00
Piotr Osiewicz 2be714cd59 Make match index 1-based 2023-12-11 15:47:02 +01:00
Piotr Osiewicz 0094050c08 Make the query editor expand in size less 2023-12-11 15:40:38 +01:00
Piotr Osiewicz d91a6c9fa4 Forego using dispatch_action for click handlers 2023-12-11 15:32:28 +01:00
Antonio Scandurra 51e504e812 Fix porting mistake that caused clicking on the editor to misbehave (#3583)
We used `width` instead of `height` in the "pixels-to-point" conversion
code, which would cause clicks to not work correctly when the width was
smaller than the `y` coordinate.

Release Notes:

- N/A
2023-12-11 14:30:06 +01:00
Antonio Scandurra 7aa6a41fa5 Maintain focus correctly when activating panes in zed2 (#3582)
Previously, before emitting a `Focus` event from the pane inside of the
`focus_in` listener, we would erroneously check whether the pane's focus
handle was _not_ focused. However, by the time the pane was notified of
being "focused in", the focus handle would already be focused, which was
preventing the pane from ever emitting a `Focus` event. In turn, this
would cause the workspace to not maintain the active pane correctly.

This pull request maintains an explicit `was_focused` boolean as part of
the `Pane` state, which ensures we only emit the `Focus` event the first
time the pane receives focus.

As part of this, I also reworked how the outline view gets deployed to
allow clicking breadcrumbs even when the corresponding pane doesn't have
focus.

Release Notes:

- N/A
2023-12-11 14:29:56 +01:00
Antonio Scandurra 0d2780b508 Fix porting mistake that caused clicking on the editor to misbehave
We used `width` instead of `height` in the "pixels-to-point" conversion
code, which would cause clicks to not work correctly when the width was
smaller than the `y` coordinate.
2023-12-11 14:21:55 +01:00
Antonio Scandurra d2db7f6b23 Focus editor when confirming outline item 2023-12-11 14:18:46 +01:00
Piotr Osiewicz f7c0fb71de fixup! Add major text 2023-12-11 14:03:43 +01:00
Antonio Scandurra fb4749878d Emit Focus events from Pane only when it didn't have focus before 2023-12-11 14:02:08 +01:00
Antonio Scandurra 6e7a18c90a Show the correct outline when clicking on a breadcrumb 2023-12-11 14:01:16 +01:00
Piotr Osiewicz 78ca5a4528 Add major text 2023-12-11 13:56:02 +01:00
Piotr Osiewicz e84ed7b2bd Bind actions on the whole search bar, not just the query editor 2023-12-11 13:35:25 +01:00
Kirill Bulatov 7c6f45ff59 Always open new project search view workspace::NewSearch action (#3581) 2023-12-11 13:45:41 +02:00