Cole Miller
cc24aff469
Fix more improper uses of the buffer_id field of Anchor ( #36636 )
...
Follow-up to #36524
Release Notes:
- N/A
2025-08-21 09:24:34 -04:00
Cole Miller
25f5f367fa
Show excerpt dividers in without_headers multibuffers ( #36647 )
...
Release Notes:
- Fixed diff cards in agent threads not showing dividers between
disjoint edited regions.
2025-08-21 13:23:56 +00:00
Bennet Bo Fenner
94df132ff8
acp: Allow collapsing edit file tool calls ( #36675 )
...
Release Notes:
- N/A
2025-08-21 11:05:41 +00:00
Antonio Scandurra
06f08c9fa6
acp: Use unstaged style for diffs ( #36674 )
...
Release Notes:
- N/A
2025-08-21 10:59:51 +00:00
Julia Ryan
d55cdfbba8
Avoid suspending panicking thread while crashing ( #36645 )
...
On the latest build @maxbrunsfeld got a panic that hung zed. It appeared
that the hang occured after the minidump had been successfully written,
so our theory on what happened is that the `suspend_all_other_threads`
call in the crash handler suspended the panicking thread (due to the
signal from simulate_exception being received on a different thread),
and then when the crash handler returned everything was suspended so the
panic hook never made it to the `process::abort`.
This change makes the crash handler avoid _both_ the current and the
panicking thread which should avoid that scenario.
Release Notes:
- N/A
2025-08-21 10:33:45 +00:00
Piotr Osiewicz
66ebc64ddb
remote: Fix toolchain RPC messages not being handled because of the entity getting dropped ( #36665 )
...
Release Notes:
- N/A
2025-08-21 09:37:45 +00:00
Bennet Bo Fenner
7150ddebbf
agent2: Allow expanding terminals individually ( #36670 )
...
Release Notes:
- N/A
2025-08-21 11:25:00 +02:00
Antonio Scandurra
1b119c8554
Fix @-mentioning threads when their summary isn't ready yet ( #36664 )
...
Release Notes:
- N/A
2025-08-21 08:57:28 +00:00
Kirill Bulatov
3abfd61d5e
Fix overlooked Clippy lints ( #36659 )
...
Follow-up of https://github.com/zed-industries/zed/pull/36557 that is
needed after https://github.com/zed-industries/zed/pull/36652
Release Notes:
- N/A
2025-08-21 06:48:04 +00:00
Kirill Bulatov
0c29d4edf3
Add a non-style lint exclusion ( #36658 )
...
Follow-up of https://github.com/zed-industries/zed/pull/36651
Restores https://github.com/zed-industries/zed/pull/35955 footgun guard.
Release Notes:
- N/A
2025-08-21 06:36:57 +00:00
Sachith Shetty
ae2187131a
editor: Use highlight_text to highlight matching brackets, fix unnecessary inlay hint highlighting ( #36540 )
...
Closes #35981
Release Notes:
- Fixed bracket highlights overly including parts of inlays when
highlighting
Before -
<img width="1480" height="602" alt="Screenshot from 2025-08-19 17-15-06"
src="https://github.com/user-attachments/assets/8e6b5ed8-f133-4867-8352-ed93441fbd8b "
/>
After -
<img width="1480" height="602" alt="Screenshot from 2025-08-19 17-24-26"
src="https://github.com/user-attachments/assets/1314e54e-ecf9-4280-9d53-eed6e96e393f "
/>
2025-08-21 09:27:41 +03:00
618cfaf19b
Stop waiting for part of LSP responses on remote Collab clients' part ( #36557 )
...
Instead of holding a connection for potentially long LSP queries (e.g.
rust-analyzer might take minutes to look up a definition), disconnect
right after sending the initial request and handle the follow-up
responses later.
As a bonus, this allows to cancel previously sent request on the local
Collab clients' side due to this, as instead of holding and serving the
old connection, local clients now can stop previous requests, if needed.
Current PR does not convert all LSP requests to the new paradigm, but
the problematic ones, deprecating `MultiLspQuery` and moving all its
requests to the new paradigm.
Release Notes:
- Improved resource usage when querying LSP over Collab
---------
Co-authored-by: David Kleingeld <git@davidsk.dev >
Co-authored-by: Mikayla Maki <mikayla@zed.dev >
Co-authored-by: David Kleingeld <davidsk@zed.dev >
2025-08-21 09:24:34 +03:00
Conrad Irwin
c40686166f
Re-add redundant clone ( #36652 )
...
Although I said I'd do this, I actually didn't...
Updates #36651
Release Notes:
- N/A
2025-08-20 21:08:49 -06:00
Conrad Irwin
7ad0579e41
Remove style lints for now ( #36651 )
...
Closes #36577
Release Notes:
- N/A
2025-08-20 20:38:30 -06:00
Agus Zubiaga
7b352d9f7c
acp: Suggest upgrading to preview instead of latest ( #36648 )
...
A previous PR changed the install command from `@latest` to `@preview`,
but the upgrade command kept suggesting `@latest`.
Release Notes:
- N/A
2025-08-21 00:52:38 +00:00
Ben Brandt
ea8d1d3da1
acp: Add e2e test support for NativeAgent ( #36635 )
...
Release Notes:
- N/A
2025-08-21 00:36:50 +00:00
Agus Zubiaga
a29f5e17c6
acp: Update to 0.0.30 ( #36643 )
...
See: https://github.com/zed-industries/agent-client-protocol/pull/20
Release Notes:
- N/A
2025-08-21 00:10:36 +00:00
张小白
a70da60d42
windows: Fix RevealInFileManager ( #36592 )
...
Closes #36314
This PR takes inspiration from [Electron’s
implementation](https://github.com/electron/electron/blob/dd54e84a58531b52680f7f736f593ee887eff6a7/shell/common/platform_util_win.cc#L268-L314 ).
Before and after:
https://github.com/user-attachments/assets/53eec5d3-23c7-4ee1-8477-e524b0538f60
Release Notes:
- N/A
2025-08-21 08:08:54 +08:00
Ben Kunkle
0da34712a0
docs: Add table of all actions ( #36642 )
...
Closes #ISSUE
Release Notes:
- N/A *or* Added/Fixed/Improved ...
2025-08-20 23:41:06 +00:00
Agus Zubiaga
e649cd90cc
acp: Reliably suppress gemini abort error ( #36640 )
...
https://github.com/zed-industries/zed/pull/36633 relied on the prompt
request responding before cancel, but that's not guaranteed
Release Notes:
- N/A
2025-08-20 23:32:17 +00:00
Marshall Bowers
fb8a28ecfc
agent_ui: Fix signed-in check in Zed provider configuration ( #36639 )
...
This PR fixes the check for if the user is signed in in the Agent panel
configuration.
Supersedes https://github.com/zed-industries/zed/pull/36634 .
Release Notes:
- Fixed the user's plan badge near the Zed provider in the Agent panel
not showing despite being signed in.
2025-08-20 23:09:09 +00:00
Agus Zubiaga
60b82b1dff
acp: Supress gemini aborted errors ( #36633 )
...
This PR adds a temporary workaround to supress "Aborted" errors from
Gemini when cancelling generation. This won't be needed once
https://github.com/google-gemini/gemini-cli/pull/6656 is generally
available.
Release Notes:
- N/A
2025-08-20 22:30:25 +00:00
Conrad Irwin and Danilo Leal
89ff4f029a
acp: Handle Gemini Auth Better ( #36631 )
...
Release Notes:
- N/A
---------
Co-authored-by: Danilo Leal <daniloleal09@gmail.com >
2025-08-20 16:12:41 -06:00
Julia Ryan
c254e5a58c
nix: Re-enable nightly builds ( #36632 )
...
Release Notes:
- N/A
2025-08-20 21:43:53 +00:00
Agus Zubiaga
f56f126a36
acp: Hide feedback buttons for external agents ( #36630 )
...
Release Notes:
- N/A
2025-08-20 21:35:48 +00:00
Cole Miller
101868e997
acp: Rename assistant::QuoteSelection and support it in agent2 threads ( #36628 )
...
Release Notes:
- N/A
2025-08-20 21:31:25 +00:00
Agus Zubiaga
e08743117f
acp: Suggest installing gemini@preview instead of latest ( #36629 )
...
Release Notes:
- N/A
2025-08-20 21:26:07 +00:00
Danilo Leal
e9be7a516b
thread_view: Add recent history entries & adjust empty state ( #36625 )
...
Release Notes:
- N/A
2025-08-20 18:01:22 -03:00
Agus Zubiaga
c786bf35e5
acp thread view: Do not go into editing mode if unsupported ( #36623 )
...
Release Notes:
- N/A
2025-08-20 20:05:53 +00:00
Joseph T. Lyons
00fe2f86ee
Bump Zed to v0.202 ( #36622 )
...
Release Notes:
-N/A
2025-08-20 20:05:30 +00:00
Cole Miller
8914a03fe4
Fix typo in Excerpt::contains ( #36621 )
...
Follow-up to #36524
Release Notes:
- N/A
2025-08-20 19:30:11 +00:00
Ben Brandt
34544003eb
agent2: Clean up tool descriptions ( #36619 )
...
schemars was passing along the newlines from the doc comments. This
should make these closer to the markdown file versions we had in the old
agent.
Release Notes:
- N/A
2025-08-20 19:17:07 +00:00
Agus Zubiaga
c3bb046816
message editor: Only allow types of content the agent can handle ( #36616 )
...
Uses the new
[`acp::PromptCapabilities`](https://github.com/zed-industries/agent-client-protocol/blob/a39b7f635d67528f0a4e05e086ab283b9fc5cb93/rust/agent.rs#L194-L215 )
to disable non-file mentions and images for agents that don't support
them.
Release Notes:
- N/A
2025-08-20 19:04:10 +00:00
Piotr Osiewicz
e5c06b6e42
clippy: println_empty_string & non_minimal_cfg ( #36614 )
...
- **clippy: Fix println-empty-string**
- **clippy: non-minimal-cfg**
Related to #36577
Release Notes:
- N/A
2025-08-20 18:45:40 +00:00
Cole Miller and Conrad Irwin
cfef425366
Remove special case for singleton buffers from MultiBufferSnapshot::anchor_at ( #36524 )
...
This may be responsible for a panic that we've been seeing with
increased frequency in agent2 threads.
Release Notes:
- N/A
Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com >
2025-08-20 18:43:29 +00:00
Umesh Yadav
502b8203a2
Fix clippy::println_empty_string, clippy::while_let_on_iterator, clippy::while_let_on_iterator lint style violations ( #36613 )
...
Related: #36577
Release Notes:
- N/A
2025-08-20 20:14:30 +02:00
Cole Miller
6eabe6d0df
Add tracked buffers for agent2 mentions ( #36608 )
...
Release Notes:
- N/A
2025-08-20 14:01:18 -04:00
Bennet Bo Fenner and Ben Brandt
5c639b47ff
agent2: Port feedback ( #36603 )
...
Release Notes:
- N/A
---------
Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com >
2025-08-20 19:10:43 +02:00
Antonio Scandurra
af8ee2bdf4
Fix scrollbar flicker when streaming agent2 response ( #36606 )
...
This was caused by calling `list_state.splice` on updated entries. We
don't need to splice the entry, as we'll recompute its measurements
automatically when we render it.
Release Notes:
- N/A
2025-08-20 16:39:46 +00:00
Antonio Scandurra
59249cf00c
Capture telemetry when requesting completions in agent2 ( #36600 )
...
Release Notes:
- N/A
2025-08-20 16:04:32 +00:00
Umesh Yadav
7411188abc
Fix clippy::len_zero lint style violations ( #36589 )
...
Related: #36577
Release Notes:
- N/A
---------
Signed-off-by: Umesh Yadav <git@umesh.dev >
2025-08-20 14:35:59 +00:00
tidely
53d1091d05
Fix clippy::map_clone lint violations ( #36585 )
...
#36577
Release Notes:
- N/A
2025-08-20 16:34:52 +02:00
Antonio Scandurra
f256fffbb3
Miscellaneous UX fixes for agent2 ( #36591 )
...
Release Notes:
- N/A
2025-08-20 13:56:39 +00:00
d098225635
agent2: New thread from summary ( #36578 )
...
Release Notes:
- N/A
---------
Co-authored-by: Agus Zubiaga <agus@zed.dev >
Co-authored-by: Cole Miller <cole@zed.dev >
2025-08-20 13:54:00 +00:00
Lukas Wirth
c39ce53973
remote: Do not leave client hanging on unhandled proto message ( #36590 )
...
Otherwise the client will wait for a response that never arrives,
causing the task to lock up
Release Notes:
- N/A
2025-08-20 13:41:58 +00:00
tidely
0d7997549f
Fix clippy::manual_map lint violations ( #36584 )
...
#36577
Release Notes:
- N/A
2025-08-20 15:17:28 +02:00
Antonio Scandurra
43e33a7d70
Wait for agent2 feature flag before loading panel ( #36583 )
...
Release Notes:
- N/A
2025-08-20 15:02:40 +02:00
tidely
4c8b910167
Enforce style lints which do not have violations ( #36580 )
...
Release Notes:
- N/A
2025-08-20 14:07:37 +02:00
Antonio Scandurra
0a1ed6e75f
Fix mentions roundtrip from/to database and other history bugs ( #36575 )
...
Release Notes:
- N/A
2025-08-20 12:03:20 +00:00
tidely
fbd2542b63
Move clippy lints which aren't apart of the style category ( #36579 )
...
Move lints which aren't apart of the style category.
Motivation: They might get accidentally get reverted when we turn the
style category on again and remove the manual lint enforcements.
Release Notes:
- N/A
2025-08-20 11:26:45 +00:00