yenru0/zed
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
2,371 Commits 5 Branches 0 Tags
db335c29aa80a2c69662eeaf337ea0cdcdceb7dc
Commit Graph
2371 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Max Brunsfeld db335c29aa Merge pull request #316 from zed-industries/fix-subscription-panic 
Fix `rpc::Client` subscription panics
 2022-01-10 11:15:17 -08:00
Antonio Scandurra 12c11fcf8d 🎨 2022-01-10 16:10:29 +01:00
Antonio Scandurra e7c1ba181f Fix panic if subscribing after dropping a subscription for the same message 2022-01-10 16:09:06 +01:00
Antonio Scandurra 35c768fadd Don't panic when dropping a subscription in a subscription handler 2022-01-10 16:04:49 +01:00
Antonio Scandurra 389c472375 Fix dev dependencies in client/Cargo.toml 2022-01-10 16:03:55 +01:00
Antonio Scandurra 5bd4c5442b Merge pull request #313 from zed-industries/polish-project-diagnostics 
Polish project diagnostics UX
 2022-01-10 14:33:26 +01:00
Antonio Scandurra ed68da4503 Fix diagnostic unit test assertions 2022-01-10 14:28:25 +01:00
Antonio Scandurra 9d52e4851b 🎨 2022-01-10 12:14:52 +01:00
Antonio Scandurra 9759f2188b Compare singleton buffers in test_open_and_save_new_file 2022-01-10 11:56:00 +01:00
Antonio Scandurra dc0714a27d Correctly report line boundaries when a map contains both folds and wraps 
This fixes the randomized test failures that were occurring on main.
 2022-01-10 11:26:48 +01:00
Antonio Scandurra 9521be8224 Use a new Workspace::activate_item API in project diagnostics 
Previously, we would only activate the pane without switching the
pane's *active item*.
 2022-01-10 10:10:11 +01:00
Max Brunsfeld dfab726dd9 When selections lose their excerpts, move them to the next primary diagnostic 2022-01-07 14:53:33 -08:00
Max BrunsfeldandNathan Sobo 4b7584e1a2 Reuse views when moving between diagnostic view and editors 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 11:00:12 -08:00
Max BrunsfeldandNathan Sobo 4ca8d56b7f Finish implementing ProjectDiagnostics::open_excerpts 
* Build workspace item views with a reference to the workspace
* Add randomized test for MultiBuffer::excerpted_buffers and fix a small bug

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 09:59:27 -08:00
Antonio ScandurraandNathan Sobo 2877e37001 Use Buffer handles instead of MultiBuffer as editor workspace items 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 17:48:31 +01:00
Antonio ScandurraandNathan Sobo c28fd392cb Refactor opening workspace items 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 17:38:37 +01:00
Antonio ScandurraandNathan Sobo 7ebeddd2c2 WIP: Add keybinding to open buffers under cursors 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 16:12:50 +01:00
Antonio ScandurraandNathan Sobo f7c2757178 Display a "Checking..." message when running disk-based diagnostics 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 15:03:19 +01:00
Antonio ScandurraandNathan Sobo 592208c92d Show status bar item for project diagnostic summary 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 14:14:21 +01:00
Antonio ScandurraandNathan Sobo d5fb3c1203 Move back diagnostic_summaries into Worktree 
This fixes an issue where updating the snapshot's entries would
override the diagnostic summaries received on the remote side.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-07 13:38:20 +01:00
Antonio Scandurra 0dfb51c7a9 Avoid removing diagnostics from Worktree after opening a buffer 
This allows re-opening the same buffer and supplying the previous
diagnostics.
 2022-01-07 10:33:21 +01:00
Antonio Scandurra 8ed2231de0 Clear selections on other excerpted buffers when setting active selections 2022-01-07 10:19:28 +01:00
Max Brunsfeld d9f725e20a Give a full-width background to the diagnostic headers 2022-01-06 17:55:56 -08:00
Max BrunsfeldandNathan Sobo 6f94450d4b Introduce Expanded element 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-06 17:35:45 -08:00
Max BrunsfeldandNathan Sobo 6551baa91e Unify Flexible and Expanded elements 
We'll use the name Expanded for something else now.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-06 17:29:34 -08:00
Max BrunsfeldandNathan Sobo 3f2f57b77d Keep selections at the top of the project diagnostics view when it is first populated 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-06 17:01:13 -08:00
Max BrunsfeldandNathan Sobo 222848a753 Don't clobber diagnostics when getting new snapshot from background scanner 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-06 15:04:06 -08:00
Max Brunsfeld e9b63f06a0 Revert "Remove special handling of multi-line primary diagnostic messages and fix tests" 
This reverts commit 05c8db05ca.
 2022-01-06 14:38:13 -08:00
Max BrunsfeldandNathan Sobo dcfa8be99e Always group diagnostics the way they're grouped in the LSP message 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-06 14:22:28 -08:00
Nathan SoboandMax Brunsfeld 517a1c6dc2 Report backtraces of pending conditions when deterministic executor illegally parks 
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2022-01-06 13:33:55 -07:00
Nathan SoboandMax Brunsfeld df5b181ad8 Send diagnostic summaries to guests when they join the project 
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
 2022-01-06 12:12:09 -07:00
Nathan SoboandAntonio Scandurra 80e5915179 Allow disk-based diagnostic progress begin/end events to interleave 
When multiple saves occur, we can have multiple start events followed by multiple end events. We don't want to update our project diagnostics view until all pending progress is finished.

Co-Authored-By: Antonio Scandurra <me@as-cii.com>
 2022-01-06 09:32:08 -07:00
Nathan SoboandAntonio Scandurra b12936bc38 Re-focus diagnostics editor when transitioning from an empty to a populated state 
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
 2022-01-06 08:35:31 -07:00
Antonio ScandurraandNathan Sobo a56b3c7fb9 Polish rendering of inline errors 
- Don't soft-wrap
- Render multiple lines

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-06 16:17:53 +01:00
Antonio Scandurra e89b1d8354 Maintain excerpt ordering correctly when some errors don't change 2022-01-06 15:33:02 +01:00
Antonio Scandurra 3ec22e7581 Wire up refresh_anchors in Editor::refresh_selections and call it 2022-01-06 15:32:37 +01:00
Max Brunsfeld f2273252b1 WIP - MultiBuffer::refresh_anchors 2022-01-05 21:12:49 -08:00
Max Brunsfeld 4535c2e99d Merge branch 'main' into polish-project-diagnostics 2022-01-05 20:38:20 -08:00
Nathan Sobo 9cf539ed3a Merge pull request #308 from zed-industries/fix-collaboration-regressions 
Fix collaboration regressions
 2022-01-05 19:56:51 -07:00
Max BrunsfeldandNathan Sobo 4d4dc1b44a Fix Locator::from_index 
Enhance language::tests::test_random_collaborators so that it checks buffer invariants.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-05 17:58:24 -08:00
Max BrunsfeldandNathan Sobo 75170a078f Fix Global::gt and rename it to changed_since 
A false negative return value of `gt` was preventing guests' multibuffers from
syncing correctly.

Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-05 17:36:12 -08:00
Max BrunsfeldandNathan Sobo 2879a402ca Don't scroll editors away from the top of their buffer when content changes 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-05 12:31:00 -08:00
Max BrunsfeldandNathan Sobo 75ac4f8925 Fix panic when resolving anchors after an excerpt id has been recycled 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
 2022-01-05 11:28:49 -08:00
Max Brunsfeld 59310ae90d Merge branch 'main' into polish-project-diagnostics 
Also fix false failure in ModelHandle::condition when parking is not forbidden.
 2022-01-05 10:53:18 -08:00
Antonio Scandurra 386b1d4719 Remove invalid excerpts as opposed to styling them differently 2022-01-05 18:21:17 +01:00
Antonio Scandurra d92ca16e6f Merge pull request #306 from zed-industries/serialize-buffer-undos 
Fix buffer replication bugs that would lead to divergence among replicas
 2022-01-05 18:14:09 +01:00
Antonio Scandurra fbb347523a Show a message when no diagnostics are available 2022-01-05 17:25:03 +01:00
Antonio Scandurra 0e4147791f Ensure prior, deferred selections don't override newer selections 2022-01-05 15:43:26 +01:00
Antonio Scandurra 866e9bbc6a Fix TreeMap::get always returning None 2022-01-05 15:41:30 +01:00
Antonio Scandurra ecb270f191 Fix Buffer::remote_selections_in_range at query range boundaries 2022-01-05 15:04:50 +01:00