Antonio Scandurra
e1945e2abf
Add a unit test for editor edit events
2022-03-24 09:17:56 +01:00
Antonio Scandurra
529fdc2764
Emit an Edited event when ending, undoing or redoing a transaction
2022-03-24 08:56:37 +01:00
Antonio Scandurra
a0ca4a13f8
Rename editor::Event::Edited to editor::Event::BufferEdited
...
This is to distinguish it from a new event we're about to add which
represent edits originating from that specific editor.
2022-03-24 08:55:46 +01:00
Antonio Scandurra
a7e3a51ac6
Use Editor::transact everywhere
...
This is in preparation of emitting an edit event every time a transaction ends
or it is undone/redone.
2022-03-24 08:48:06 +01:00
Max Brunsfeld
731537fe5a
Merge pull request #669 from zed-industries/extend-selection-fixes
...
Fix extending selections starting at ends of syntax nodes
2022-03-23 15:56:35 -07:00
Max Brunsfeld
0876781606
Fix extending selections starting at ends of other nodes
...
Fixes #478
2022-03-23 15:38:23 -07:00
Max Brunsfeld
5770e54f3a
Merge pull request #657 from zed-industries/global-observations
...
Add global change observations
2022-03-23 14:11:33 -07:00
Max Brunsfeld
1f99157c36
0.22
2022-03-23 12:09:07 -07:00
Max Brunsfeld
c23723cce2
Merge pull request #668 from zed-industries/no-lsp-when-following
...
Avoid making LSP requests when moving cursor due to following
2022-03-23 11:54:45 -07:00
Max Brunsfeld
1c58e616b9
Merge pull request #667 from zed-industries/fix-duplicate-nav-entries
...
Fix duplicate nav entries
2022-03-23 11:49:00 -07:00
Max Brunsfeld
1f14c68362
Merge pull request #666 from zed-industries/keychain
...
Refine authentication and keychain interaction
2022-03-23 11:48:49 -07:00
Max Brunsfeld
00cee40996
Avoid making LSP requests when moving cursor due to following
2022-03-23 11:41:20 -07:00
Keith Simmons and Antonio Scandurra
b931215d49
Add navigation deduping
...
Co-authored-by: Antonio Scandurra <me@as-cii.com >
2022-03-23 11:32:25 -07:00
Nathan Sobo and Max Brunsfeld
bc4956e837
Authenticate on startup if ZED_IMPERSONATE is assigned
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2022-03-23 12:25:06 -06:00
Nathan Sobo and Max Brunsfeld
c77d659b88
Don't prompt for keychain access when launching from a pty
...
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2022-03-23 12:18:17 -06:00
Nathan Sobo and Max Brunsfeld
8b684e14dc
Don't try keychain after authentication fails
...
Previously, we were achieving this by deleting the keychain item, but this can sometimes fail which leads to an infinite loop. Now, we explicitly never try the keychain when reattempting authentication after authentication fails.
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com >
2022-03-23 12:15:36 -06:00
Antonio Scandurra
27fbbeffe9
WIP
2022-03-23 19:05:46 +01:00
Antonio Scandurra and Keith Simmons
3dde930f6b
Don't push a duplicate nav entry when changing selections via the mouse
...
Co-Authored-By: Keith Simmons <keith@zed.dev >
2022-03-23 18:45:45 +01:00
Max Brunsfeld
32af5317c8
Merge pull request #663 from zed-industries/following-pending-selections
...
Fix error in follower when leader creates pending selections
2022-03-23 10:32:40 -07:00
Keith Simmons and Antonio Scandurra
2c656c63b8
Add global tests and wrap global update functions in update call to flush effects
...
Co-authored-by: Antonio Scandurra <me@as-cii.com >
2022-03-23 10:27:27 -07:00
Max Brunsfeld and Nathan Sobo
072fa2448c
Fix error in follower when leader creates pending selections
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-23 10:24:26 -07:00
Keith Simmons
48fc9f95fb
Add global change observations
2022-03-23 09:14:12 -07:00
Antonio Scandurra
dd6c8a17e5
Merge pull request #662 from zed-industries/fix-refresh-selections-when-mouse-selecting
...
Account for pending selections when calling `Editor::refresh_selections`
2022-03-23 15:58:28 +01:00
Antonio Scandurra and Nathan Sobo
c6b87d4e9c
Don't destroy pending selection on Editor::refresh_selections
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-23 15:21:11 +01:00
Antonio Scandurra
2f1b1abbb8
Merge pull request #661 from zed-industries/follow
...
Introduce basic following experience
2022-03-23 15:17:44 +01:00
Antonio Scandurra and Nathan Sobo
7266849908
Cycle through panes spatially rather than in the order in which they created
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-23 15:06:25 +01:00
Antonio Scandurra and Nathan Sobo
d94d39357d
Don't show local cursors when editor is not focused
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-23 14:46:33 +01:00
Antonio Scandurra and Nathan Sobo
beb370a308
Focus followed items when they become active if the pane is active
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-23 14:41:48 +01:00
Antonio Scandurra and Nathan Sobo
a4b0ec4a33
Activate previous pane and next pane via cmd-k cmd-left and cmd-k cmd-right
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-23 14:26:00 +01:00
Nathan Sobo
a207d05604
Update follow binding, remove unfollow binding
...
The previous binding to follow had ergonomics issues for the frequency that I think we'll want to use it. It would also conflict with the sub-word selection binding.
Now that moving the cursor etc unfollows, I don't think we need the follow binding.
2022-03-23 06:19:35 -06:00
Nathan Sobo
54c8815162
Merge pull request #656 from zed-industries/add-editor-lifetime-events
...
Add editor lifetime events
2022-03-23 05:59:22 -06:00
Antonio Scandurra
831bddc331
Account for pending selections when calling Editor::refresh_selections
2022-03-23 11:46:35 +01:00
Antonio Scandurra
6948924e9a
Fix global nested event test after turning subscriptions into effects
2022-03-23 09:14:33 +01:00
Keith Simmons
753c7ff5bb
Merge pull request #655 from zed-industries/add-editor-selection-helpers
...
Add editor selection helpers
2022-03-22 22:44:56 -07:00
Max Brunsfeld and Nathan Sobo
1d4061dcb9
Autoscroll when leader moves cursors
...
instead of copying their scroll top.
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-22 18:02:54 -07:00
Max Brunsfeld and Nathan Sobo
1329824507
Add unit test for editor's following methods
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-22 17:39:34 -07:00
Max Brunsfeld and Nathan Sobo
a60cc61dd8
Replicate fractional component of leader's scroll position
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-22 17:20:13 -07:00
Max Brunsfeld and Nathan Sobo
4436301fa3
Coalesce followed view updates only within one frame
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-22 17:03:24 -07:00
Max Brunsfeld and Nathan Sobo
b920b865c4
Combine updates from multiple view events when updating followers
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-22 16:22:42 -07:00
Keith Simmons
8bf564ecf7
Add editor lifetime events
2022-03-22 16:14:32 -07:00
Keith Simmons
8d4deb8693
Add editor selection utilities
...
Also improved test that was failing during above to use marker text approach as a drive by
2022-03-22 16:08:22 -07:00
Keith Simmons
5b92fcdf72
Merge pull request #654 from zed-industries/remove-movment-results
...
Remove results from movement functions
2022-03-22 16:07:39 -07:00
Max Brunsfeld
5d1658e1f1
Don't represent editor's scroll top anchor as an option
...
Use Anchor::min as the special value representing a scroll top of zero
2022-03-22 13:32:25 -07:00
Max Brunsfeld
421b170515
Use env_logger when running the app in a terminal
2022-03-22 13:32:25 -07:00
Max Brunsfeld
a0d18fc007
Allow customizing the pane's following border width in the theme
2022-03-22 13:32:25 -07:00
Max Brunsfeld
76cf065588
Make UpdateBuffer a foreground message
2022-03-22 13:32:25 -07:00
Keith Simmons
3e22400212
Remove results from movement function return values, and move editor test utilities to test file
2022-03-22 10:55:03 -07:00
Max Brunsfeld
995b1421aa
Merge pull request #651 from zed-industries/refine-word-movement
...
Add sub-word movement and helper functions for finding word boundaries
2022-03-22 09:09:03 -07:00
Antonio Scandurra and Nathan Sobo
13c6ca7adb
Ensure leader updates don't change the active pane of followers
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-22 16:44:59 +01:00
Antonio Scandurra and Nathan Sobo
43eeb11192
Don't trigger observations with notifications emitted prior to observing
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev >
2022-03-22 16:28:11 +01:00