Commit Graph
12746 Commits
Author SHA1 Message Date
Conrad Irwin fbbf36d152 Merge branch 'main' into pixel-columns 2023-10-18 23:00:56 -06:00
Conrad Irwin 3d5cbcaad1 Refactor TextLayoutDetails construction 2023-10-18 22:56:11 -06:00
Conrad Irwin 1d49ff70f7 recert config change 2023-10-18 22:23:38 -06:00
Conrad Irwin 7436ed4d45 Make vim visual block work better 2023-10-18 22:23:06 -06:00
Max Brunsfeld 2ea9668872 Fix possibility of infinite loop in selections_with_autoclose_regions (#3138)
Previously, that method could loop forever if the editor's autoclose
regions had unexpected selection ids.

Something must have changed recently that allowed this invariant to be
violated, but regardless, this code should not have relied on that
invariant to terminate like this.
2023-10-18 11:34:35 -07:00
Max BrunsfeldandPiotr 80b1b6be22 Fix possibility of infinite loop in selections_with_autoclose_regions
Previously, that method could loop forever if the editor's autoclose
regions had unexpected selection ids.

Co-authored-by: Piotr <piotr@zed.dev>
2023-10-18 11:16:14 -07:00
Joseph T. Lyons b4911dcea8 collab 0.25.0 2023-10-18 13:17:17 -04:00
Joseph T. Lyons 99e2e5733c v0.110.x dev 2023-10-18 12:31:12 -04:00
Piotr Osiewicz 36ea6531a4 buffer_search: Discard empty search suggestions. (#3136)
Now when buffer_search::Deploy action is triggered (with cmd-f), we'll
keep the previous query in query_editor (if there was one) instead of
replacing it with empty query.

This addresses this bit of feedback from Jose:
> If no text is selected, `cmd + f` should not delete the text in the
search bar when refocusing

Release Notes:
- Improved buffer search by not clearing out query editor when no text
is selected and "buffer search: deploy" (default keybind: cmd-f) is
triggered.
2023-10-18 18:05:13 +02:00
Kyle Caverly c8590ff675 return code inside a markdown block during inline assist (#3137)
Reverted prior small change in inline prompting.
We should now only return code in a markdown block during inline
assists.
2023-10-18 10:40:53 -04:00
KCaverly d268fb71f5 revert change to return only the text and inside return all text inside markdown blocks 2023-10-18 10:35:11 -04:00
Joseph T. Lyons d61918ef4c Shorten GitHub release message 2023-10-17 15:47:17 -04:00
Conrad Irwin 58950c1d11 Start writing role to database (#3120)
Scaffolding for guest members in channels

Release notes:
- You can now set channels to "public" which will allow anyone to join
and become a member. In a future release guests joining public channels
will have reduced permissions.
2023-10-17 13:40:58 -06:00
Conrad Irwin e81e9c9538 Fix lint errors 2023-10-17 13:32:08 -06:00
Conrad Irwin 5240eb08f9 update sidebar for public channels 2023-10-17 13:30:09 -06:00
Kyle Caverly bbbab1c92e Introduce Context Retrieval in Inline Assistant (#3097)
This PR introduces a new Inline Assistant feature "Retrieve Context", to
dynamically fill the content in your generation prompt based on relevant
results returned from the Semantic Search for the Prompt.

Release Notes:

- Introduce "Retrieve Context" button in Inline Assistant
2023-10-17 15:04:36 -04:00
Kirill Bulatov 44626a64a2 Cap every language server logs (#3134)
* on opening a language server's logs, a new editor for server logs is
now created from `\n`-joined `VecDeque` elements instead of a buffer, as
before
* every `VecDeque` entry is a log line we receiver out of stderr or LSP
server, and their general amount is capped with `let
MAX_STORED_LOG_ENTRIES: usize = 2000;`
* currently opened editor with logs (`Editor::multi_line`) keeps getting
log lines appended and may get over this cap, but only last stored 2000
entries will be restored on reopen
* similarly, cap rpc message logs

Release Notes:

- Improved memory usage by storing less language LSP server and rpc logs
2023-10-17 21:51:21 +03:00
Kirill Bulatov b1f5894b56 Reduce max log lines, clean log buffers better 2023-10-17 21:47:21 +03:00
Kirill Bulatov 3dc40711b6 Do not create buffers for rpc logs 2023-10-17 21:43:34 +03:00
Kirill Bulatov a1c88cee98 Remove another needless log buffer 2023-10-17 21:43:34 +03:00
Kirill Bulatov f3334199db Update editor with current buffer logs 2023-10-17 21:43:34 +03:00
Kirill Bulatov f73e3636a3 Do not detach subscriptions 2023-10-17 21:43:34 +03:00
Kirill Bulatov eccf64d21a Add a rough prototype 2023-10-17 21:43:34 +03:00
Nate Butler ea92a0aec5 Add link & public icons 2023-10-17 13:34:51 -04:00
Piotr Osiewicz 0113bca5ce workspace: Do not scan for .gitignore files if a .git directory is encountered along the way (#3135)
Partially fixes zed-industries/community#575

This PR will see one more fix to the case I've spotted while working on
this: namely, if a project has several nested repositories, e.g for a
structure:
/a
/a/.git/
/a/.gitignore
/a/b/
/a/b/.git/
/a/b/.gitignore

/b/ should not account for a's .gitignore at all - which is sort of
similar to the fix in commit #c416fbb, but for the paths in the project.

The release note is kinda bad, I'll try to reword it too.
- [ ] Improve release note.
- [x] Address the same bug for project files.

Release Notes:
- Fixed .gitignore files beyond the first .git directory being respected
by the worktree (zed-industries/community#575).
2023-10-17 18:56:03 +02:00
Conrad Irwin 29b1d0ad13 Temporarily join public channels as a member 2023-10-17 10:29:43 -06:00
Conrad Irwin cab542114e Fix some tests 2023-10-17 10:15:20 -06:00
Conrad Irwin 2da5b3d15e Fix channel test ordering 2023-10-17 10:01:31 -06:00
Conrad Irwin 9029a2807b Merge branch 'main' into guests 2023-10-17 09:54:17 -06:00
Conrad Irwin 7d67bc51fb Fix get_most_public_ancestor 2023-10-17 09:41:34 -06:00
Mikayla dce496da2e Minor adjustments 2023-10-17 03:05:01 -07:00
Mikayla Maki d39fa728ba Update IDs on interactive elements in LSP log viewer (#3133)
This PR fixes a panic in the LSP log viewer when rendering the popover
UI. This did not ship to preview or stable, and so does not require a
release note.

Release Notes:

- N/A
2023-10-17 02:27:37 -07:00
Mikayla Maki 17108d8c5b Adjust chat to allow channel admins to delete all messages (#3132)
As it says on the tin

Release Notes:

- Changed chat permissions so that admins of a channel can delete any
message in a channel.
2023-10-17 02:24:14 -07:00
Mikayla 4c91261cab Update IDs on interactive elements in LSP log viewer 2023-10-17 02:22:34 -07:00
Mikayla 942f910aee Adjust chat permisisons to allow deletion for channel admins 2023-10-17 02:16:17 -07:00
Conrad Irwin 968aa29b0c New entitlements: (#3118)
Release Notes:

- Support Universal Links for Channel links
- Share credentials between Stable and Preview
2023-10-16 22:10:14 -06:00
Conrad Irwin 925986cc1f Provisioning profiles for stable and preview 2023-10-16 20:38:10 -06:00
Conrad Irwin 61d349956e Allow pasting ZED urls in the command palette in development 2023-10-16 20:03:44 -06:00
Conrad Irwin 74ffac5519 Ensure that invitees do not have permissions
They have to accept the invite, (which joining the channel will do),
first.
2023-10-16 16:24:10 -06:00
Conrad Irwin 2899a628c7 Make joining a channel as a guest always succeed 2023-10-16 15:14:13 -06:00
Nate ButlerandKyle Caverly 281d4266c3 Update indexing icon
Co-Authored-By: Kyle Caverly <22121886+KCaverly@users.noreply.github.com>
2023-10-16 15:53:29 -04:00
Joseph T. Lyons 15e11762cc Fix telemetry-related crash on start up (#3131)
Fixes (hopefully)
[#2136](https://github.com/zed-industries/community/issues/2136).

Release Notes:

- N/A
2023-10-16 14:01:52 -04:00
Joseph T. Lyons 0d00924039 Fix telemetry-related crash on start up 2023-10-16 13:07:07 -04:00
KCaverly d82855948f clean up warnings 2023-10-16 10:02:11 -04:00
KCaverly 0b914ab1db remove print from prompts 2023-10-16 09:55:45 -04:00
KCaverly 5cba986cee catchup with main 2023-10-16 09:47:07 -04:00
Piotr Osiewicz 503ca69e86 editor/language: hoist out non-generic parts of edit functions. (#3130)
This reduces LLVM IR size of editor (that's one of the heaviest crates
to build) by almost 5%.

LLVM IR size of `editor` before this PR: 3280386
LLVM IR size with `editor::edit` changed: 3227092
LLVM IR size with `editor::edit` and `language::edit` changed: 3146807

Release Notes:
- N/A
2023-10-16 13:17:44 +02:00
Piotr Osiewicz 563d506da1 copilot: Propagate action if suggest_next is not possible. (#3129)
One of our users ran into an issue where typing "true quote" characters
(option-[ for „ and option-] for ‚) was not possible; I've narrowed it
down to a collision with Copilot's NextSuggestion and PreviousSuggestion
action default keybinds. I explicitly did not want to alter the key
bindings, so I've went with a more neutral fix - one that propagates the
keystroke if there's no Copilot action to be taken (user is not using
Copilot etc). Note however that typing true quotes while using a Copilot
is still not possible, as for that we'd have to change a keybind.

Fixes zed-industries/community#2072


Release Notes:
- Fixed Copilot's "Suggest next" and "Suggest previous" actions
colliding with true quotes key bindings (`option-[` and `option-]`). The
keystrokes are now propagated if there's no Copilot action to be taken
at cursor's position.
2023-10-15 17:27:36 +02:00
Conrad Irwin a4e960f73a Wire through public access toggle 2023-10-13 16:59:30 -06:00
Conrad Irwin 7194bee9c3 fix migration 2023-10-13 15:08:09 -06:00