Commit Graph
31406 Commits
Author SHA1 Message Date
Joseph T. Lyons 7d5b0d3b60 Instrument welcome screen events (#3930)
# TODO

- [x] Fix busted tests
- [x] Check all events from actions on welcome screen
    - [x] change theme
    - [x] change keymap
    - [x] install cli
    - [x] enable vim
    - [x] send metric data
    - [x] send diagnostics
    - [x] close welcome screen
- [X] Check all settings events
    - [x] record theme change (in main and in selector)
    - [x] record base keymap change (in main and in selector)
    - [x] record metric data value
    - [x] record diagnostics value
- [X] Triple check that telemetry settings still block events from being
sent, since we updated how we check for settings changes
- [X] Remove immediate flush mode and allow the flush method to be
called publicly
- [x] Remove references to clickhouse in the code (should be generic at
the client level)

Release Notes:

- N/A
2024-01-06 23:39:46 -05:00
Joseph T. Lyons dd7f4a6a0d Improve setting name consistency for welcome page 2024-01-06 23:34:46 -05:00
Joseph T. Lyons 37858e742f Improve operation name consistency for welcome page 2024-01-06 23:30:53 -05:00
Joseph T. Lyons d55c3f88f9 Remove "clickhouse" from telemetry code
The client sends events to our end point, and the endpoint is what determines what analytics database is used to store the data. The client should be generic and not mention the name of the service being proxied to through our server.
2024-01-06 23:27:23 -05:00
Joseph T. Lyons 3431c14e32 Remove immediate flush mode
Allow flush method to be called publicly. This is a better, simpler solution, that allows for better control over flushing.
2024-01-06 20:27:30 -05:00
Kirill Bulatov b9e1f95aa3 On external file drop, add visible project entries for directories only 2024-01-07 03:11:28 +02:00
Kirill Bulatov c9917e440e Fix panic during terminal tab drag and drop 2024-01-07 02:32:15 +02:00
Kirill Bulatov 17b2b29008 Implement terminal pane drag and drop overrides 2024-01-07 02:21:43 +02:00
Kirill Bulatov 10967ea45f Implement external file drop in pane 2024-01-07 01:18:02 +02:00
Kirill Bulatov 307f0444bc Prepare for external file drop in pane 2024-01-07 01:17:49 +02:00
Piotr Osiewicz 87c35ec90f gpui: Sweep through cargo doc output and mark dubious items as non-public (#3932)
I essentially went through the publicly exported items and marked these
that are e.g. leaky reexports as pub(crate). I expect that'd be done on
Tuesday anyways.

Release Notes:
- N/A
2024-01-06 23:47:51 +01:00
Kirill Bulatov b047dfae98 Properly detect file finder label positions in paths 2024-01-06 23:50:59 +02:00
Joseph T. Lyons 73368099ed Fix tests 2024-01-06 16:10:40 -05:00
Joseph T. Lyons bb443a09c5 Clean up code 2024-01-06 15:31:16 -05:00
Joseph T. Lyons 7fe787f48d Merge branch 'main' into instrument-welcome-screen 2024-01-06 15:23:06 -05:00
Joseph T. Lyons 93d5de6c59 Add event for welcome page close 2024-01-06 15:17:28 -05:00
Joseph T. Lyons 86ea6562cd WIP 2024-01-06 14:41:35 -05:00
Antonio Scandurra 879bf2bda5 Fix bug that was causing Editor to notify on every mouse move 2024-01-06 18:56:55 +01:00
Kirill Bulatov 6ce7635645 Reduce the height of the collaborators' color ribbon 2024-01-06 12:54:54 +02:00
Kirill Bulatov 94c278498f Add space between menus and player stack 2024-01-06 12:07:48 +02:00
Kirill Bulatov a29fb62550 Add spaces between leave call and call status icons, and call status icons and user menu 2024-01-06 11:56:01 +02:00
Kirill Bulatov e431a52773 Fix base keymap selector keyboard shortcuts 2024-01-06 11:39:27 +02:00
Nathan Sobo 83f1178c91 Implement From<Rgba> for Fill 2024-01-05 17:33:22 -07:00
Nathan Sobo 81614f9674 Align the assistant message headers with the editable message content
Since the message headers are buttons, we need to shift them relatively to
compensate for the fact that the background is only visible when hovered.
I'm ok with the background not being aligned so long as the unhovered text is.
2024-01-05 17:23:10 -07:00
Kirill Bulatov f58a47acc7 Screenshare item background is now of editor background's color 2024-01-06 02:01:12 +02:00
Kirill Bulatov 44a8f19245 Restore tooltipts for all collab buttons 2024-01-06 01:50:59 +02:00
Conrad IrwinandMax b3bef72cb9 Tidy up context usage
Co-Authored-By: Max <max@zed.dev>
2024-01-05 16:35:20 -07:00
Conrad IrwinandMax 690159001b Tidy up TestContext lifecycle
Co-Authored-By: Max <max@zed.dev>
2024-01-05 16:31:41 -07:00
Conrad IrwinandMax a079b9a4e4 All the following tests
Co-Authored-By: Max <max@zed.dev>
2024-01-05 16:18:01 -07:00
Conrad Irwin 6248af11a4 Merge branch 'main' into following-tests 2024-01-05 16:14:12 -07:00
Conrad Irwin c9592c8669 More following tests 2024-01-05 16:13:40 -07:00
Conrad IrwinandMax 70dd73f875 Port 1.00 following tests
Co-Authored-By: Max <max@zed.dev>
2024-01-05 15:55:33 -07:00
Max Brunsfeld 85502494d5 Restore the ability to disable key bindings by setting them to null in your keymap (#3921)
* Fix an incorrect use of `Any::type_id` that prevented the disabling of
key bindings
* Restructured the representation of disabled key bindings so that they
handle context predicates correctly. Previously, to disable key binding,
you needed to supply the exact same context predicate (e.g. `Editor &&
mode == "full"`) as the binding that you are trying to disable. Now, the
context predicates of disabled key bindings are evaluated just like any
other context predicate (with the current context) to see if they apply.

Release Notes:

- Fixed an issue where disabling key bindings didn't work. To disable a
key binding, set it to `null` in your keymap.
2024-01-05 13:51:47 -08:00
Marshall Bowers bf03a8db63 Iterate on design of channel management modal (#3923)
This PR refines the design of the channel management modal:

#### Before

<img width="585" alt="Screenshot 2024-01-05 at 4 17 32 PM"
src="https://github.com/zed-industries/zed/assets/1486634/a6d96674-b688-4549-8fb8-0a7b2c7c88be">

#### After

<img width="589" alt="Screenshot 2024-01-05 at 4 15 20 PM"
src="https://github.com/zed-industries/zed/assets/1486634/31ae8dc1-a129-4a15-963e-9779b9b79bd9">

Release Notes:

- Improved the look of the channel management modal.
2024-01-05 16:22:43 -05:00
Nate Butler 4d650b95fa Refine copilot UI 2024-01-05 16:17:06 -05:00
Max Brunsfeld f45c9c94fc Handle contexts correctly for disabled key bindings 2024-01-05 13:06:59 -08:00
Nate Butler b6c7926dc2 Use the already existing styles/typography for Headline 2024-01-05 15:59:34 -05:00
Nate Butler 204317b80c Merge branch 'main' into copilot-ui 2024-01-05 15:56:33 -05:00
Marshall Bowers 979a79b717 Tidy up styling of connection status in the title bar (#3922)
This PR tidies up the styling of the connection status indicators in the
title bar.

Removed some debug styles and tweaked the styling to match the rest of
the title bar overall.

Release Notes:

- Improved the connection status indicators in the title bar.
2024-01-05 15:36:30 -05:00
Conrad Irwin 27b340c13a Deploy tweaks (#3920)
Bugs from the 0.34.0 collab nightly deploy
2024-01-05 13:32:47 -07:00
Conrad Irwin 0def88270d Deploy tweaks 2024-01-05 13:24:29 -07:00
Marshall Bowers c8a9582965 Gracefully prevent submitting feedback while in a shared project (#3919)
This PR fixes a panic that would occur when trying to submit feedback
while within a shared project.

There may be a way we want to support this in the future, but for now we
just show a toast letting the user know this is not supported:

<img width="415" alt="Screenshot 2024-01-05 at 2 46 02 PM"
src="https://github.com/zed-industries/zed/assets/1486634/d3eff4d9-90ba-4257-9857-19b1bc933cf3">

Release Notes:

- Fixed a panic when attempting to open the feedback modal while in a
shared project.
2024-01-05 15:03:09 -05:00
Marshall Bowers ab6faa1754 Use regular text color for diagnostic popovers (#3918)
This PR updates the diagnostic popovers to use the regular editor text
color rather than one specific to the diagnostic kind.

Release Notes:

- Updated text color in diagnostic popovers.
2024-01-05 14:13:43 -05:00
Marshall Bowers ba318bf17a Decouple theme license generation from TypeScript theme definitions (#3917)
This PR decouples the generation of licenses for the themes we ship from
the TypeScript theme definitions.

For now, we are embedding the license information for the themes in the
`theme_importer`, and emit a combined `LICENSES` file in the `theme`
crate whenever we import themes. This is also where we check that each
theme has a valid license.

We then use this `LICENSES` file when building up the global license
file for Zed.

This decoupling is one step towards us being able to delete the old Zed1
styles.

Release Notes:

- N/A
2024-01-05 13:38:12 -05:00
Piotr Osiewicz e6d1cbfa08 gpui: Remove dependency on sqlez (#3871)
This removes one of the path dependencies in gpui that's only really
needed by `workspace` (which can work around lack of these
implementations by itself). In theory it should also improve build
scheduling (as gpui doesn't have to wait for main dependency of sqlez -
libsqlite3 - to finish it's 25 seconds-long build in release), though in
practice I didn't notice a substantial improvement.
Moreover `sqlez` was unused by `settings` too, so that's removed
as well.

Release Notes:

- N/A
2024-01-05 19:36:55 +01:00
Conrad Irwin 892eafbd60 collab 0.34.0 2024-01-05 11:30:00 -07:00
Conrad Irwin ad56914bb5 Read-only access for channel guests (#3841) 2024-01-05 11:21:18 -07:00
Conrad Irwin e31428cd33 Disable Dangerous Downtime-causing Default (#3873)
According to
https://docs.digitalocean.com/products/kubernetes/how-to/configure-load-balancers/#ssl-certificates

you can specify whether to disable automatic DNS record
creation for the certificate upon the load balancer’s creation using the
do-loadbalancer-disable-lets-encrypt-dns-records annotation. If you
specify true, we will not automatically create a DNS A record at the
apex of your domain to support the SSL certificate.
2024-01-05 11:21:03 -07:00
Kirill Bulatov 2047021376 Fix current lsp logs menu item not shown as selected 2024-01-05 19:23:15 +02:00
Conrad Irwin 83d3c339cc Fix dock right click labels (#3626)
Release Notes:

- N/A
2024-01-05 10:08:58 -07:00