Commit Graph
31406 Commits
Author SHA1 Message Date
Joseph T. Lyons 7b243d3826 Remove outdated TODO 2024-01-04 17:32:00 -05:00
Marshall Bowers 121882fc6a Merge branch 'main' into collab-titlebar-fixes 2024-01-04 17:31:58 -05:00
Joseph T. Lyons 6cc2e82fe1 Remove outdated TODOs 2024-01-04 17:28:07 -05:00
Marshall Bowers d08ddcff42 Fix label color for inactive tabs (#3899)
This PR fixes an issue where certain tabs were not using the correct
color for their labels when they were inactive.

Release Notes:

- Fixed an issue where some inactive tabs were not using the correct
label color.
2024-01-04 17:25:11 -05:00
Marshall Bowers 55d36fd7ec Render an empty placeholder when not showing file icons in the project panel (#3897)
This PR makes it so when we're not showing file icons in the project
panel we render an empty placeholder instead of nothing.

This prevents the indentation of the items in the file tree from
changing based on the presence of the icon.

Release Notes:

- Fixed layout shift when `project_panel.file_icons` is set to `false`.
2024-01-04 17:10:08 -05:00
Max Brunsfeld b8fa28fc0a Fix terminal selection when cursor leaves terminal bounds 2024-01-04 14:08:18 -08:00
Max BrunsfeldandMarshall 7ae7f15800 Fix some bugs in keymap handling (#3895)
- `base_keymap` setting was not respected, now it is
- without a `~/.config/zed/keymap.json` file, we would fail to load the
*default* keymap

Co-authored-by: Marshall <marshall@zed.dev>
2024-01-04 16:04:17 -05:00
Conrad IrwinandJulia 12e2b2b10e Uncomment editor tests
Co-Authored-By: Julia <julia@zed.dev>
2024-01-04 13:58:19 -07:00
JuliaandConrad Irwin 7d12232a4d Unbork test relying on old keystroke behavior
Previously it would both send the keydown *and then* the action, now
it send the action, and then because there was an action, does not send
the keydown

Co-Authored-By: Conrad Irwin <conrad@zed.dev>
2024-01-04 15:07:46 -05:00
Marshall Bowers 87497797b6 Fix font resolution for UI text so we render with the fallback font (#3893)
This PR updates the font resolution for shaped text to use the new
`resolve_font` method on the text system.

This makes it so we use the fallback font if the desired font cannot be
found rather than rendering nothing.

Release Notes:

- Fixed an issue where nothing would render when the font set in
`ui_font_family` was not found.
2024-01-04 14:26:08 -05:00
Conrad Irwin 271e27a922 Tidy up guest count 2024-01-04 12:22:45 -07:00
Kirill Bulatov a5a9292c76 Return back old project search behavior as default.
Add a `workspace::DeploySearch` action and use it as a default for "cmd-shift-f" binding.
This action opens existing search tab if it exists, or creates a new one otherwise.
`workspace::NewSearch` action is still available and always opens an existing search tab.
2024-01-04 21:17:24 +02:00
Marshall Bowers e3286a8d35 Try to load fallback fonts instead of panicking when a font is not found (#3891)
This PR adjusts our font resolution code to attempt to use a fallback
font if the specified font cannot be found.

Right now our fallback font stack is `Zed Mono`, followed by `Helvetica`
(in practice we should always be able to resolve `Zed Mono` since we
bundle it with the app).

In the future we'll want to surface the ability to set the fallback font
stack from GPUI consumers, and potentially even support specifying font
stacks in the user settings (as opposed to a single font family).

Release Notes:

- Fixed a panic when trying to load a font that could not be found.
2024-01-04 14:10:46 -05:00
Julia 59aaa048b1 Attempt to run keystroke actions before attempting key listeners 2024-01-04 14:01:01 -05:00
Conrad Irwin 2cf11423a3 Tidy up branch 2024-01-04 11:55:14 -07:00
Piotr Osiewicz 273ea228a9 lsp: Do not cache initialization options 2024-01-04 19:54:58 +01:00
Max Brunsfeld 5517c50d28 Fix version comparison in auto update (#3889) 2024-01-04 10:01:07 -08:00
Max BrunsfeldandAntonio Scandurra 36a603c93d Fix version comparison in auto update
Co-authored-by: Antonio Scandurra <antonio@zed.dev>
2024-01-04 09:53:57 -08:00
JuliaandMax Brunsfeld 0426c318ad Fix SendText/SendKeystroke having the wrong context name in terminal
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2024-01-04 12:35:51 -05:00
Conrad Irwin 739da57009 Implement "open in terminal" (#3888) 2024-01-04 10:35:17 -07:00
Antonio Scandurra e9d14f79b5 Prevent scrolling editor and resizing panels at the same time (#3887)
Release Notes:

- Fixed a bug that would cause Zed to never stop resizing panels when
the drag handle overlapped with an editor scrollbar.
2024-01-04 18:06:22 +01:00
Conrad Irwin b5149bb94e let search happen too 2024-01-04 09:48:47 -07:00
Conrad Irwin 774487a058 Implement "open in terminal" 2024-01-04 09:45:39 -07:00
Conrad Irwin 16e603b4a8 Read only permissions for project panel too 2024-01-04 09:40:12 -07:00
Antonio ScandurraandMarshall 4066775e57 Prevent scrolling editor and resizing panels at the same time
This fixes a bug that would cause Zed to never stop resizing
panels when the drag handle overlapped with an editor scrollbar.

Co-Authored-By: Marshall <marshall@zed.dev>
2024-01-04 17:25:02 +01:00
Nate Butler a39ca584b6 WIP tinted buttons 2024-01-04 11:15:53 -05:00
Julia ee085c371f Show pointer hand on tab & give last tab border right 2024-01-04 11:08:56 -05:00
Conrad Irwin 9487445cb9 Fix vim tests 2024-01-04 08:59:31 -07:00
Antonio Scandurra 389c819abc Re-enable key bindings for AssistantPanel (#3885)
Release Notes:

- Fixed a bug that caused `cmd-g` and `cmd-shift-g` to not work anymore
in the assistant panel.
2024-01-04 16:42:07 +01:00
Antonio Scandurra 561e967bbe Re-enable key bindings for AssistantPanel 2024-01-04 16:37:13 +01:00
Antonio Scandurra 16279f4887 Fix border rendering (#3884)
After implementing it a while ago, our previous interpolation scheme
didn't really make sense to me and was causing borders to be rendered
incorrectly. We don't really draw backgrounds and borders as part of the
same draw call anymore, but it seemed reasonable to have a correct
implementation in the shader anyway.

This commit uses Porter-Duff compositing (i.e., `over`) to produce a
color that is the result of superimposing the border on top of the
background. Then, we linearly interpolate towards the background color
as we slide out of the border and into the background.

Release Notes:

- Fixed incorrect rendering of borders.
2024-01-04 16:35:09 +01:00
Antonio Scandurra e9af65f501 Fix border rendering
After implementing it a while ago, our previous interpolation scheme
didn't really make sense to me and was causing borders to be rendered
incorrectly. We don't really draw backgrounds and borders as part of
the same draw call anymore, but it seemed reasonable to have a correct
implementation in the shader anyway.

This commit uses Porter-Duff compositing (i.e., `over`) to produce
a color that is the result of superimposing the border on top of the
background. Then, we linearly interpolate towards the background color
as we slide out of the border and into the background.
2024-01-04 16:27:20 +01:00
Conrad Irwin f9dd8d2fc9 Better TestWindow support 2024-01-04 08:00:40 -07:00
Antonio Scandurra baf08045eb Clip List items that partially overflow (#3882)
Release Notes:

- Fixed a visual bug that caused channels to overlap with the filter
input.
2024-01-04 15:21:41 +01:00
Antonio Scandurra 072fe59b6a Clip List items that partially overflow 2024-01-04 15:12:25 +01:00
Antonio Scandurra 6a845a5013 Fix quitting Zed when project was unshared (#3881)
Release Notes:

- Fixed a bug that would disable `cmd-q` after a remote project was
unshared.
2024-01-04 15:12:25 +01:00
Antonio Scandurra 4c8d7bfe2e Fix quitting Zed when project was unshared 2024-01-04 15:00:36 +01:00
Antonio Scandurra 0e54798ec3 Show scrollbar even when buffer search highlights are outside viewport (#3880)
Release Notes:

- Fixed a bug that prevented scrollbars from being shown when search
matches were outside the viewport.
2024-01-04 12:45:55 +01:00
Antonio Scandurra b28ab7f085 Show scrollbar even when buffer search highlights are outside viewport 2024-01-04 12:39:15 +01:00
Piotr Osiewicz 36b8aedc4c channels: Move name of the channel to the same line as the hash icon. 2024-01-04 12:11:23 +01:00
Joseph T. Lyons 597b99e9d7 Move telemetry settings check into telemetry module 2024-01-04 01:13:21 -05:00
Nate Butler cf5b4b121a UI grab bag (#3875)
- Tidy up some ui crate docs
- Update "checking" diagnostic color + add icon
- Make scrollbar track transparent in all themes
- Update border variant color in all themes
- Use theme colors for muted/speaking indicators

Release Notes:

- N/A
2024-01-03 23:26:02 -05:00
Nate Butler 7ce0aefb36 Use theme colors for muted/speaking indicators 2024-01-03 23:19:47 -05:00
Nate Butler f611244312 Update border variant color 2024-01-03 23:13:26 -05:00
Nate Butler aeb21a51df Make scrollbar track transparent 2024-01-03 23:09:24 -05:00
Nate Butler f5620f3896 Add "Checking" icon for diagnostics 2024-01-03 23:07:21 -05:00
Marshall Bowers b680507a46 Use dense spacing for completion menu items (#3874)
This PR updates the completion menu to use dense spacing for its items.

Release Notes:

- Adjusted styling of completion menu entries.
2024-01-03 23:06:16 -05:00
Joseph T. Lyons 4538780fce Merge branch 'main' into rename-notification-store 2024-01-03 22:59:43 -05:00
Nate Butler b16221b652 Update ui docs 2024-01-03 22:44:31 -05:00
Conrad Irwin 13accd43ad Disable Dangerous Downtime-causing Default
According to https://docs.digitalocean.com/products/kubernetes/how-to/configure-load-balancers/#ssl-certificates

you can specify whether to disable automatic DNS record
creation for the certificate upon the load balancer’s creation using the
do-loadbalancer-disable-lets-encrypt-dns-records annotation. If you
specify true, we will not automatically create a DNS A record at the
apex of your domain to support the SSL certificate.
2024-01-03 19:55:17 -07:00