Commit Graph
39175 Commits
Author SHA1 Message Date
Julia 3f0c2f0319 Start port of notification panel 2023-12-11 20:40:48 -05:00
Max Brunsfeld 2fd0f453f3 Allow dragging and dropping files in the project panel (#3602)
Also, fix a bug that prevented drag and drop from working in the collab
panel.
2023-12-11 17:03:07 -08:00
Max BrunsfeldandMikayla f95d8796ce Fix detection of topmost region under the dragged item
Co-authored-by: Mikayla <mikayla@zed.dev>
2023-12-11 16:50:44 -08:00
Nate Butler eb814b6f2a WIP 2023-12-11 19:17:13 -05:00
Marshall Bowers 9d79921f6e Take a first pass at styling the welcome screen (#3601)
This PR is a first pass at styling the welcome screen in Zed2.

Here's the current state:

<img width="1237" alt="Screenshot 2023-12-11 at 7 00 43 PM"
src="https://github.com/zed-industries/zed/assets/1486634/a0cbd5ca-7331-4785-bf46-f83fc4cb3bb6">

Release Notes:

- N/A
2023-12-11 19:06:33 -05:00
Max Brunsfeld 376b8ae82d Start work on dragging entries in the project panel 2023-12-11 15:52:58 -08:00
Max Brunsfeld a6f43a3e2c Use Box instead of Rc for List event handlers 2023-12-11 15:52:06 -08:00
Conrad Irwin 4e9d0f48fb vim2 (#3597)
- MOAR TESTS

[[PR Description]]

Release Notes:

- N/A
2023-12-11 16:42:03 -07:00
Marshall Bowers 88cc0307cb Add w_vw and h_vh to StyledExt for setting sizes in viewport units (#3600)
This PR adds `w_vw` and `h_vh` methods to `StyledExt`.

These methods are the same as their `w` and `h` counterparts, but
operate in viewport units, giving us the equivalent of `vw` and `vh` in
CSS.

You can see them in action in this story:

```
cargo run -p storybook2 -- components/viewport_units
```

Release Notes:

- N/A
2023-12-11 18:19:11 -05:00
Conrad Irwin 84bb006d3e Fix scroll tests
For some reason in gpui2, the window contains an extra 59px of space..
2023-12-11 16:12:17 -07:00
Max Brunsfeld a2891993be Implement welcome view in zed2. (#3599)
Still needs styling.
2023-12-11 14:54:03 -08:00
Max Brunsfeld d49d4d2b1e Implement welcome view in zed2.
Still needs styling.
2023-12-11 14:48:42 -08:00
Marshall Bowers 147a49d00a theme_importer: Fall back to inactive tab background if no active tab background set (#3598)
This PR makes it so the `theme_importer` falls back to the inactive tab
background color if the theme doesn't not an active tab background
color.

This fixes the active tab color in the Synthwave 84 theme.

Release Notes:

- N/A
2023-12-11 17:39:46 -05:00
Conrad Irwin daf7ea9b69 Most tests now... 2023-12-11 15:25:30 -07:00
Conrad Irwin d62a6bd531 And some more 2023-12-11 15:14:13 -07:00
Conrad Irwin 60dab800f0 All the easy tests? 2023-12-11 15:13:11 -07:00
Marshall Bowers cf46241ea0 Adjust scrollbar track background and border colors (#3596)
This PR adjusts the colors we pull from the VS Code themes to use for
the scrollbar track background and border.

For the scrollbar track background we now use the `editor.background`,
and for the scrollbar track border we use `editorOverviewRuler.border`.

Release Notes:

- N/A
2023-12-11 17:08:39 -05:00
Conrad Irwin 8aaf5eab9a vim2 (#3594)
- First round of vim tests

Add `observe_keystrokes` back to gpui2
Allow multiple actions to match a given key event

[[PR Description]]

Release Notes:

- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/<public_issue_number_if_exists>)).
2023-12-11 15:06:51 -07:00
Conrad Irwin e2600388bf MOAR TESTS 2023-12-11 15:06:33 -07:00
Conrad Irwin b07d46c434 Fix warnings 2023-12-11 14:54:58 -07:00
Marshall Bowers c0abf7e355 Use editorOverviewRuler.border for the scrollbar track border 2023-12-11 16:54:53 -05:00
Marshall Bowers 142e7b60e2 Use the editor background for the scrollbar track background 2023-12-11 16:39:26 -05:00
Marshall Bowers 23d774a230 Draw the scrollbar track left border 2023-12-11 16:39:00 -05:00
Mikayla Maki b49faf2673 Add support for resizing splits and docks, as well as utilities (#3595)
Making this PR to upstream changes to util and GPUI2, resizing exists
but isn't working yet.

Release Notes:

- N/A
2023-12-11 13:32:06 -08:00
Mikayla 30626c9003 Remove some debug styles 2023-12-11 13:23:07 -08:00
Conrad Irwin e83d9ab066 Moar tests 2023-12-11 14:21:21 -07:00
Mikayla e626f02246 Add double click handling 2023-12-11 13:17:42 -08:00
Conrad Irwin 287fdcbf9e First round of vim tests 2023-12-11 14:16:25 -07:00
Max Brunsfeld e1adfae09b Defer drawing the window until the CoreAnimation displayLayer: method is called (#3592)
GPUI (both 1 and 2) currently performs rendering, layout, and painting
at the end of every effect cycle. This leads to poor performance when
the app receives events more frequently than the display refreshes. Such
rapid events can come from a terminal, an LSP, or a mouse with a high
polling rate.

This PR changes GPUI so that we don't render until the OS notifies us
that the content will be presented, via the `displayLayer:` callback.

Because render, layout, and paint have side effects that are sometimes
relied on in tests, we currently keep the old behavior (drawing after
every effects cycle) in tests.

This is similar to what @ForLoveOfCats explored in
https://github.com/zed-industries/zed/pull/3542, but slightly simpler,
in that we're not using the display link. As a follow-up, we could use
the display link to start rendering earlier, to possibly reduce latency
further.
2023-12-11 13:03:04 -08:00
Marshall Bowers b0f8016aac Use tab.inactiveForeground from VS Code for muted text color (#3593)
This PR updates the `theme_importer` to pull in the
`tab.inactiveForeground` color from VS Code to use as the muted text
color.

Release Notes:

- N/A
2023-12-11 15:57:47 -05:00
Max Brunsfeld 74931325d9 Fix unused field warning 2023-12-11 12:56:18 -08:00
Marshall Bowers 53b76a6dd2 Fix inactive tab styles (the verbose way) (#3591)
This PR fixes the inactive tab style to properly show the label using
the muted text color.

I went about fixing this in the most direct way possible, but the
solution leaves a lot to be desired, IMO. I plan to explore some ideas
on how we can improve the state of styling the tab content without
having the same styles repeated all over the place and subsequently
out-of-sync.

Release Notes:

- N/A
2023-12-11 15:42:17 -05:00
Max BrunsfeldandAntonio 5a3835b210 Avoid double borrow in tests by drawing windows explicitly in flush_effects
Co-authored-by: Antonio <antonio@zed.dev>
2023-12-11 12:37:10 -08:00
Conrad Irwin 547c4cebb8 vim-flight entertainment (#3574)
- vim2 compiling (but mostly commented out)
- More code written, similar lack of workingness so far

Still todo:
[ ] Figure out the focus/blur stuff
[ ] Uncoment more code
[ ] Fix VimTestContext
[ ] Uncomment the tests

Release Notes:

- N/A
2023-12-11 12:11:13 -07:00
Antonio ScandurraandMax Brunsfeld f6fc46e02a Redraw the window at the end of flush_effects in tests
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2023-12-11 20:10:27 +01:00
Joseph T. Lyons d4e62e761e Fix rustfmt in feedback_modal.rs 2023-12-11 13:56:58 -05:00
Antonio ScandurraandMax Brunsfeld 2973db5f52 Defer drawing the scene until macOS's display_layer callback
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2023-12-11 19:55:55 +01:00
Conrad Irwin baa3f7710a COmment out tests again for now 2023-12-11 11:40:54 -07:00
Marshall Bowers d83c40c77f Fix color for selections in scrollbar (#3590)
This PR fixes an issue where we weren't using the right color for
displaying selections within the scrollbar.

Release Notes:

- N/A
2023-12-11 13:34:29 -05:00
Joseph T. Lyons ba2227b743 Use copy button for copy channel link (#3589)
Release Notes:

- N/A
2023-12-11 13:22:36 -05:00
Mikayla fa73bc8748 Merge branch 'main' into splits 2023-12-11 10:16:32 -08:00
Joseph T. Lyons 364020e45d Use copy button for copy channel link 2023-12-11 13:14:29 -05:00
Marshall Bowers 54d483cf5f Style scrollbars with theme colors (#3588)
This PR updates the styling of scrollbars in the editor to use the theme
colors.

Release Notes:

- N/A
2023-12-11 13:06:43 -05:00
Joseph T. Lyons ca8b2094b9 Adjust nightly to build twice a day 2023-12-11 13:05:16 -05:00
Conrad Irwin 53d9129d36 Clear out easy todo!()s 2023-12-11 11:00:55 -07:00
Marshall Bowers f36490091e Pull more scrollbar colors from VS Code 2023-12-11 12:59:03 -05:00
Marshall Bowers b1330f68e8 Style scrollbar when using diff markers 2023-12-11 12:58:55 -05:00
Marshall Bowers abeca44202 Map scrollbar colors from VS Code themes 2023-12-11 12:49:54 -05:00
Marshall Bowers f294387f7d Pull scrollbar colors from theme 2023-12-11 12:47:29 -05:00
Conrad Irwin 3ae69b7596 Remove warnigns 2023-12-11 10:45:27 -07:00