Anthony Eid
387dac7bc0
## Summary Tune the shared `ReqwestClient` builder so HTTP connections that have silently gone bad on a flaky network path are detected and dropped rather than reused. A stale, reused HTTP/2 connection (after a NAT/conntrack timeout, a silent reset, or a degraded path) is a common source of intermittent TLS `BadRecordMac` errors against long-lived endpoints such as `cloud.zed.dev`. The client already retries these (`HttpSend` is retryable with exponential backoff), but users still see periodic multi-second stalls and "connection error" warnings. These settings make the client probe and recycle connections instead of sending a request's first records into a connection that is already dead: - `tcp_keepalive(30s)` — surface dead TCP connections instead of reusing them. - `pool_idle_timeout(30s)` — bound how long an idle connection lingers in the pool. - `http2_keep_alive_interval(15s)` / `http2_keep_alive_timeout(10s)` / `http2_keep_alive_while_idle(true)` — ping idle HTTP/2 connections so broken ones are torn down. All three constructors (`new`, `user_agent`, `proxy_and_user_agent`) go through `builder()`, so every Zed HTTP client picks this up. ## Notes - Values are conservative; they can be tightened if stale-connection errors persist. - `tcp_keepalive_interval` is not yet available in the pinned `zed-reqwest` fork rev, so only the initial keepalive idle time is set here. ## Verification Behavior is network-dependent, so there is no deterministic test. Verified that the crate builds (`cargo check -p reqwest_client`). The change is being validated empirically against a setup that reproduces the `BadRecordMac` errors. Release Notes: - Improved resilience to intermittent network errors by detecting and dropping stale HTTP connections instead of reusing them.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.