CainandChristopher Biscardi
5428eb8399
Follow-up to #63195. This PR fixes the cursor animation problems reported in [this comment](https://github.com/zed-industries/zed/pull/63195#issuecomment-5662566417): - Block cursors snapped instead of animating when moving between characters with different display widths, such as an ASCII character and an emoji or CJK character. - Cursor animation disappeared near the top and bottom scroll margins when keyboard navigation triggered vertical autoscrolling. The first issue happened because any cursor geometry size change was treated as a reason to snap. Cursor movement now retargets the animation when either the rectangle position or size changes, while geometry changes without a logical cursor move still snap immediately. The second issue happened because every viewport change cleared the active animation. Scroll-only viewport changes now translate the current and target corner positions, as well as the previous target geometry, by the scroll pixel delta before retargeting. This preserves the spring's motion and velocity across autoscroll. Actual layout changes, including text-area size, line height, and font advance changes, continue to snap. Regression coverage includes: - Both narrow-to-wide and wide-to-narrow cursor transitions, including convergence to the new rectangle. - Cursor movement in both directions while the viewport scrolls. - Scrolling during an active animation without clearing its position or velocity. - Layout changes that must still snap. - An editor-level keyboard autoscroll test using a vertical scroll margin of 3. Validation: - `cargo test -p editor cursor_animation --lib` - `cargo fmt --all --check` - `cargo build -p zed --bin zed --profile release-fast` - Manual verification with the release-fast binary Release Notes: - Fixed cursor animations when moving between characters of different widths and during keyboard-triggered autoscrolling. --------- Co-authored-by: Christopher Biscardi <chris@christopherbiscardi.com>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.