Shaz Ravenswood
641c58d04c
This PR updates the deprecated `rootPath` field in the LSP `InitializeParams` for backwards compatibility with language servers that still rely on this field. ### Issue Some language servers (notably the Salesforce Apex Language Server) only read from the deprecated `rootPath` field in the LSP initialize request and do not use `rootUri` or `workspaceFolders`. When Zed sends `root_path: None`, these language servers fail to initialize because they cannot determine the workspace root. Example error from the Apex Language Server: ``` NullPointerException at apex.jorje.lsp.impl.db.nddb.NdApexIndex.getToolsStoragePath(NdApexIndex.java:723) ``` The Apex LSP's initialize handler does: ```java serverSetup.setRootPath(params.getRootPath()); ``` VSCode's LanguageClient sends both `rootPath` and `rootUri` for backwards compatibility: https://github.com/microsoft/vscode-languageserver-node/blob/main/client/src/common/client.ts#L1434 ### Fix Derive `rootPath` from the existing `root_uri` field when building the initialize params. The LSP spec states that if both `rootPath` and `rootUri` are provided, `rootUri` wins, so this change should be backwards compatible and won't affect language servers that properly use `rootUri`<sup>(1)</sup>. --- (1) [LSP Specification - InitializeParams](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initializeParams) - notes that `rootPath` is deprecated in favor of `workspaceFolders`, but for backwards compatibility it should still be provided when possible. Release Notes: - Improved compatibility with legacy language servers
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking issue)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.