Ibrahim Khan
7d9afee0bf
# Objective Fixes #58970. With `terminal.copy_on_select` enabled, a left click that isn't a deliberate selection can still overwrite the system clipboard. It happens most often on the window-focusing click (clicking into the terminal from another app), where the pointer jitters by a pixel or two during the click. A perfectly motionless click is already safe (it produces a zero-length selection and the copy is skipped), but the drag handler treats *any* movement as the start of a selection, so a 1px jitter creates a stray selection that `copy_on_select` then copies, clobbering whatever was on the clipboard. ## Solution Apply a small drag-distance threshold before a left click begins a selection, matching the threshold gpui's `div` element already uses (`DRAG_THRESHOLD = 2.0`). `mouse_down` records the press position, and `mouse_drag` ignores movement below the threshold until a selection has actually started. Once a selection is in progress it keeps extending as before. This is the same click-vs-drag handling other terminals use (kitty's `drag_threshold`, iTerm2). ## Testing Added two unit tests in `crates/terminal/src/terminal.rs`: - `test_terminal_click_jitter_does_not_start_selection` — a 1px drag after mouse-down enqueues no `UpdateSelection` and leaves the selection phase `Ended`. - `test_terminal_deliberate_drag_starts_selection` — a drag well past the threshold still starts a selection. The first test fails on `main` (the jitter starts a selection) and passes with this change. The rest of the `terminal` suite is green and `script/clippy -p terminal` is clean. I tested on Linux. The fix lives in the shared `Terminal` mouse handling, so it's platform-independent, but I haven't manually reproduced the macOS focusing-click scenario from the report on a Mac. ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable --- Release Notes: - Fixed `terminal.copy_on_select` overwriting the clipboard when a click jittered without an intentional drag.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.