Zhuoyuan Hao (Larry Hao / 郝卓远)andMrSubidubi
7eec89207c
# Objective Fixes #43932. Extensions built with `zed_extension_api` 0.0.6 or 0.1 pass the absolute worktree root in `SettingsLocation.path`. After #38744 changed core settings locations to `RelPath`, `RelPath::new` returns an error for that absolute value. The conversion produces `None`, so `ProjectSettings::get` falls back to global settings. This regressed the behavior fixed in #10859. The current LaTeX and Typst extensions both use API 0.1, matching the two extension surfaces reported in the issue. # Solution For the 0.0.6 and 0.1 WIT adapters, treat the legacy path as the worktree root (`RelPath::empty()`) and preserve the worktree ID. API 0.2 and later already send an empty relative path, so their behavior is unchanged. The two version adapters each have a regression test for the legacy absolute-root input. # Testing - `cargo test -p extension_host settings_location_targets_the_worktree_root` (2 passed) - `cargo test -p extension_host -- --skip extension_store_test::test_extension_store_with_test_extension` (10 passed; the skipped fixture needs the `wasm32-wasip2` target, which is not installed in the local Homebrew Rust toolchain) - `cargo clippy -p extension_host --all-targets -- -D warnings` - `cargo fmt --check` - `cargo build -p zed` End-to-end check with an isolated `--user-data-dir`, a trusted folder worktree, LaTeX extension 0.2.3, and texlab 5.26.0: - Zed 1.16.1 sent the global sentinel for both startup and a live project-settings edit. - This branch sent the project sentinel on startup. - Changing the project sentinel from V2 to V3 produced a new `workspace/didChangeConfiguration` with V3, and texlab's follow-up `workspace/configuration` request also returned V3.  # Self-review checklist - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards - [x] Tests cover the new behavior - [x] Performance impact has been considered and is acceptable --- Release Notes: - Fixed project-level language server settings being ignored by extensions built with extension API versions before and including v0.1.0. --------- Co-authored-by: MrSubidubi <finn@zed.dev>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.