Aleksei Gusev
a2e2e06875
# Objective - Currently, the file preview pane in pickers forces line numbers and the editor gutter to always be visible, ignoring user-configured preferences. This PR ensures the preview component respects the user's global editor layout settings. ## Solution - Modified `EditorPreview::new` within `crates/picker/src/preview.rs`. - Imported `EditorSettings` from the `editor` crate. - Replaced the hardcoded `true` values for `set_show_gutter` and `set_show_line_numbers` with the user's active global configuration retrieved via `EditorSettings::get_global(cx).gutter.line_numbers`. ## Testing - Did you test these changes? If so, how? - Yes, manually verified that toggling line numbers off or using relative line numbers in `settings.json` is accurately reflected inside the picker's file preview pane. - Are there any parts that need more testing? - No, using the global context lookup seamlessly integrates with Zed's existing configuration lifecycle. - How can other people (reviewers) test your changes? Is there anything specific they need to know? - Open your `settings.json` and change your line number preferences (e.g., set `"line_numbers": false`). - Bring up a picker that renders a file preview (like the project search or file finder). - Confirm that the preview pane's gutter and line number layout perfectly matches your active configuration. - If relevant, what platforms did you test these changes on, and are there any important ones you can't test? - Tested on Linux. ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable ## Showcase <details> <summary>Click to view showcase</summary> ### Line numbers ON <img width="1940" height="2072" alt="preview-line-numbers-on" src="https://github.com/user-attachments/assets/db824b5e-bc29-459d-bc0c-86762d44f707" /> ### Line numbers OFF <img width="1940" height="2072" alt="preview-line-numbers-off" src="https://github.com/user-attachments/assets/48a6357e-d4b5-462b-920f-d1c20d3d27af" /> </details> --- Release Notes: - Preview line numbers now respect user configuration settings
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.