Counterfeit IQanddino
a57ba9b17c
Fixes the issues where using the zed builtin prompt when removing wsl/ssh remote servers did not capture focus and caused input to be passed to the existing picker/editor. Closes #60840. # Objective The objective of this fix was to make the remote server removal prompts work correctly, capture focus, when using keyboard navigation to remove a server or wsl distro. The fix was created directly to address #60840. ## Solution The solution here is quite simple, we remove the forced, focus lines, that attempt for the context to capture the new prompt window. The oringal additional call to `cx.focus` was entirely unnecessary and was duplicated from the original ssh remote server addition, into the wsl distro addition. This behaviour and the correct deferal is handled by the receivers invocation upon the execution of the listitem. ## Testing I tested these changes manually, however this is incredibly easy to reproduce, and is entirely platform agnostic. Simply add a testing distro to the list, and then attempt to remove that distro by going into its settings and removing the sever/distro. Then use the keybinds to attempt to navigate. Prior to this PR, this would cause you to interact with the editor behind the prompt, but now correclty directs actions/inputs to the prompt window. ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable --- Release Notes: - Fixed remote server removal prompts not capturing keyboard focus. Signed-off-by: Counterfit IQ <logicye@proton.me> Co-authored-by: dino <dinojoaocosta@gmail.com>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.