Nico
a8cdff3739
Closes #45271 Zed hardcodes `ControlMaster=yes` with a `ControlPath` in a random temp directory, so it can never find a ControlMaster session the user already has open. This means you get prompted for credentials again even if you're already authenticated. This patch checks for an existing master before spawning a new one. It runs `ssh -G` to resolve the user's configured `controlpath` (with `%h`, `%p`, etc. already expanded), then `ssh -O check` to verify it's alive. If it is, Zed skips askpass and uses the existing socket. If not, the current behavior is unchanged. Both commands are local and don't hit the network. Also adds a `killed: AtomicBool` to `SshRemoteConnection` because `has_been_killed()` was using `master_process.is_none()` as a proxy for "connection is dead." When reusing an external master, `master_process` starts as `None`, so the connection pool would discard it immediately. Tested against a university SSH setup with `ControlMaster auto` configured. The reuse path connects without prompting, and the fallback path works normally when no master exists. Windows is unaffected. Release Notes: - Zed now reuses existing SSH ControlMaster sessions instead of prompting for credentials again (#45271).
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking issue)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.