John
b2f2f8d297
# Objective - When a submenu is open in a ContextMenu (e.g., an LSP server entry in the status bar menu), focus moves from the main menu to the submenu entity. Hovering over a different submenu trigger calls `on_hover(true)` which runs `window.focus()` to return focus to the main menu. This fires `on_focus_in`, which runs `select_toggled_or_first` → `select_first`, re-selecting the first item. The same issue occurs in `on_hover(false)` when the mouse leaves a trigger with an open submenu. ## Solution - Add a `suppress_focus_selection` flag to `ContextMenu`. Before each `window.focus()` call in `on_hover` handlers, set the flag to `true`. The `on_focus_in` callback checks this flag and skips auto-selection when focus is returning from submenu interaction. The flag is reset to `false` after each `on_focus_in` invocation. ## Testing - Tested manually by opening the LSP status bar menu with multiple running language servers and hovering between server entries. The first item no longer flickers or stays highlighted after hovering over other items. ## Showcase ### before fixed https://github.com/user-attachments/assets/26efb133-fb7e-4dbe-88b7-88d510dfd3a4 ### after fixed https://github.com/user-attachments/assets/7081c07d-d7f6-4a35-abe3-486bfba8591f ## Release Notes: - Fixed a bug where the first LSP server item would flicker and stay highlighted when hovering between multiple language server entries in the status bar menu.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.