Anthony Eid
b379ccd62b
`Subscription::Notification` held a strong `Arc` to a language server's entire notification handler map, while `Subscription::Io` already used a `Weak`. Any subscription retained beyond the server's lifetime (e.g. `copilot_log_subscription` in the LSP log store, which lives until the project is closed) kept **every** handler on the dead server alive — along with everything those closures capture, including `Arc<CachedLspAdapter>` and `LspAdapterDelegate`s that pin full worktree snapshots. Each server restart while such a subscription existed leaked one server generation; on large worktrees that's tens of MB per restart. The fix changes `Subscription::Notification` to hold a `Weak` reference, matching the `Io` variant. Dropping a subscription still deregisters its handler when the server is alive; if the server is already gone, there is nothing left to clean up. Also adds a regression test (`test_subscription_leaks_handlers_after_server_drop`) to prevent this from happening again Helps with #58190 and #31461 (long-running memory growth involving language servers), though it likely isn't the whole story for either, the unbounded outbound message channel in `crates/lsp/src/lsp.rs` remains a separate suspect for the extreme growth in #58190. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed a memory leak where restarting a language server could leak memory if its notification subscriptions were still retained (e.g. while the LSP log view was tracking it).
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.