Nguyen Anh Tu (Elior)andMikayla Maki
b3b7459e3e
The `draw()` method was calling `.pop()` on `next_frame.input_handlers` to extract the active input handler for the platform window. This reduced the Vec length, making cached `paint_range` indices stale. On the next frame, when a cached view called `reuse_paint()`, it would index into `rendered_frame.input_handlers` with out-of-bounds indices, causing a panic: `range start index 1 out of range for slice of length 0`. **Fix:** Use `.last_mut().and_then(|h| h.take())` instead of `.pop()` to extract the handler without changing the Vec length. The slot becomes `None`, which is already handled by `reuse_paint`'s `.take()` logic. Closes #50456 ### Testing - All 83 existing GPUI unit tests pass - Manually verified with [longbridge/gpui-component](https://github.com/longbridge/gpui-component) `cargo run --example dock`: - Switch to Input panel → type text → no crash ✅ - Before fix: crash immediately on first keystroke --- Before you mark this PR as ready for review, make sure that you have: - [x] Added a solid test coverage and/or screenshots from doing manual testing - [x] Done a self-review taking into account security and performance aspects - [ ] Aligned any UI changes with the [UI checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) *(N/A — no UI changes)* Release Notes: - Fixed a crash in GPUI when typing into an Input widget inside a cached view ([#50456](https://github.com/zed-industries/zed/issues/50456)) Co-authored-by: Mikayla Maki <mikayla@zed.dev>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking issue)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.