Om ChillureandMrSubidubi
b5881c90e5
Fixes #50526 Fixes https://github.com/zed-industries/zed/issues/42841 Fixes https://github.com/zed-industries/zed/issues/49875 ### Summary Fix `autosave: on_focus_change` not firing reliably when leaving editors with nested focus targets (e.g. multibuffer/search flows). ### Root cause Autosave on focus change was wired to `on_blur` of the item focus handle. `on_blur` only fires when that exact handle is the focused leaf, which misses common descendant-to-outside focus transitions. ## Fix In `crates/workspace/src/item.rs`, switch autosave subscription from: - `cx.on_blur(&self.read(cx).focus_handle(cx), ...)` to: - `cx.on_focus_out(&self.read(cx).focus_handle(cx), ...)` Autosave behavior and guards remain unchanged: - only for `AutosaveSetting::OnFocusChange` - only when focus truly left the item (`!contains_focused`) - skipped when modal is active (`!has_active_modal`) ### Impact - Fixes missed autosaves when moving focus from item descendants to other UI (terminal, file tree, search inputs, etc.). - No behavior change for other autosave modes (`off`, `after_delay`, `on_window_change`). ### Video [Screencast from 2026-03-04 15-23-07.webm](https://github.com/user-attachments/assets/81135999-320f-40f3-9673-7c0460e5a14a) Release Notes: - Fixed an issue where `"autosave": "on_focus_change"` would not reliably work in multibuffers. --------- Co-authored-by: MrSubidubi <finn@zed.dev>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking issue)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.