sunwukk990
dbbc25fc44
Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #55022 ## Summary When a task explicitly uses `cmd.exe`, Zed prepares it as a shell invocation like `cmd.exe /S /C "<command>"`. If Python virtual environment activation is enabled, `Project::create_terminal_task` wraps that prepared task in an outer activation shell so the venv can be activated before the task runs. Before this change, the activation formatter treated the prepared `/C` command string as a normal shell argument and quoted it again. On Windows, that can make cmd receive escaped quotes literally, producing errors like `'\\"echo Hi there\\"' is not recognized...`. This preserves the prepared cmd `/C` command string while building the activation command, and keeps the existing quoting path for ordinary task arguments. ## Verification - `cargo test -p project formats_prepared_cmd_task` - `cargo test -p project formats_non_cmd_task_for_activation` - `cargo check -p project` - `cargo fmt --check --package project` - Manually verified on Windows with a selected Python `.venv` that a `cmd.exe` task prints `Hi there` and finishes successfully. Release Notes: - Fixed Windows `cmd.exe` tasks failing when run with a selected Python virtual environment.
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking issue)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.