Oleksandr KholiavkoandAnthony Eid
e0f913b07d
# Objective The settings panel rendered as a persistent bar above the table, always taking up vertical space even though most of its controls (text alignment, filter sort order, multiline rows, dev-only toggles) are rarely touched. @Anthony-Eid suggested reworking it into popover ## Solution Replaced the always-visible settings panel with a single settings icon button (next to the row-identifier toggle) that opens a popover menu with the same controls, grouped under headers: - Text Alignment, Filter Sort, Display - and (behind `dev-tools`) Rendering Mode / debug toggles. Frees up the row of vertical space previously occupied by the panel. Similarly how it's done in git pannel ## Testing `cargo check -p tabular_data_preview` and `--features dev-tools` both build clean; `./script/clippy` clean. Manually opened the popover and toggled each setting (alignment, filter sort, multiline rows) to confirm they still apply and persist while the popover stays open. ## Demo | Before | After | | --- | --- | | <img width="720" height="427" alt="image" src="https://github.com/user-attachments/assets/0af2e7a5-ab70-4cb8-b106-6cecd5a5752d" /> | <img width="721" height="384" alt="image" src="https://github.com/user-attachments/assets/c2938156-938e-4f05-b842-08e599e4bcdd" /> | Line numbers vs Row number <img width="572" height="253" alt="image" src="https://github.com/user-attachments/assets/1ccc5e8b-ffa3-4a8f-9dcb-07cba340306c" /> <img width="571" height="412" alt="image" src="https://github.com/user-attachments/assets/ecb3c686-cb4c-41e7-918c-b8a5e123a452" /> ## Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [ ] Unsafe blocks (if any) have justifying comments - [x] The content adheres to Zed's UI standards ([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) and [icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md) guidelines) - [ ] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable --- ~~# NOTE TO REVIEWER (release notes related)~~ ~~This feature is still under feature flag, but I've head from @Anthony-Eid few weeks ago that it's already good enough to go public. Do we make it live and I keep release notes or should I remove release notes due to some blockers?~~ Disabled feature flag in https://github.com/zed-industries/zed/pull/62773 --- Release Notes: - Refine tabular data preview setting UI --------- Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking discussion)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
Zed source code is licensed primarily under GPL-3.0-or-later, with Apache-2.0 components where marked.
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.