Finn EitreimandMikayla Maki
fdd310a0a2
Closes #51198 This actually doesn't effect any of the scrollbars in Zed, as they have a separate handler that prevents this issue from occurring in `crates/ui/src/components/scrollbar.rs`, line 856 ```rust let current_offset = current_offset .along(axis) .clamp(-max_offset, Pixels::ZERO) .abs(); ``` so it is gpui specific. I still added a test case and I have a manual test script: <details><summary>Details</summary> <p> ```rust //! Reproduction of the scrollbar-offset bug in bottom-aligned `ListState`. //! //! Run with: cargo run -p gpui --example list_bottom_scrollbar_bug //! //! The list starts pinned to the bottom. Before the fix, the red scrollbar //! thumb was pushed off the bottom of the track (invisible). use gpui::{ App, Bounds, Context, ListAlignment, ListState, Window, WindowBounds, WindowOptions, div, list, prelude::*, px, rgb, size, }; use gpui_platform::application; const ITEM_COUNT: usize = 40; const COLORS: [u32; 4] = [0xE8F0FE, 0xFCE8E6, 0xE6F4EA, 0xFEF7E0]; struct BugRepro { list_state: ListState, } impl BugRepro { fn new() -> Self { let list_state = ListState::new(ITEM_COUNT, ListAlignment::Bottom, px(5000.)); Self { list_state } } } impl Render for BugRepro { fn render(&mut self, _window: &mut Window, _cx: &mut Context<Self>) -> impl IntoElement { let state = &self.list_state; let max_offset = state.max_offset_for_scrollbar().y; let raw_offset = -state.scroll_px_offset_for_scrollbar().y; let viewport_h = state.viewport_bounds().size.height; let content_h = max_offset + viewport_h; let thumb_h = if content_h > px(0.) { ((viewport_h / content_h) * viewport_h).max(px(20.)) } else { viewport_h }; let thumb_top = if max_offset > px(0.) { (raw_offset / max_offset) * (viewport_h - thumb_h) } else { px(0.) }; div() .size_full() .flex() .flex_row() .bg(rgb(0xffffff)) .text_color(rgb(0x333333)) .text_xl() .child( div().flex_1().h_full().child( list(state.clone(), |ix, _window, _cx| { let height = if ix % 4 == 0 { px(70.) } else { px(40.) }; let bg = COLORS[ix % COLORS.len()]; div() .h(height) .w_full() .bg(rgb(bg)) .border_b_1() .border_color(rgb(0xcccccc)) .px_2() .flex() .items_center() .child(format!("Item {ix}")) .into_any() }) .h_full() .w_full(), ), ) .child( div() .w(px(14.)) .h_full() .bg(rgb(0xe0e0e0)) .relative() .child( div() .absolute() .right(px(0.)) .top(thumb_top) .h(thumb_h) .w(px(14.)) .rounded_sm() .bg(rgb(0xff3333)), ), ) } } fn main() { application().run(|cx: &mut App| { let bounds = Bounds::centered(None, size(px(400.), px(500.)), cx); cx.open_window( WindowOptions { window_bounds: Some(WindowBounds::Windowed(bounds)), ..Default::default() }, |_, cx| cx.new(|_| BugRepro::new()), ) .unwrap(); cx.activate(true); }); } ``` </p> </details> where I was able to test it out, here is a video of the new working behavior. https://github.com/user-attachments/assets/02e26308-da18-418b-97fc-dd52a3325dab Release Notes: - gpui: fixed a bug where the scollbar would disappear when using a bottom aligned list. --------- Co-authored-by: Mikayla Maki <mikayla.c.maki@gmail.com>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking issue)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.