settings_ui: Route Skill tool permissions to its own config page (#59728)

The Skill page now renders the correct “Skill Tool” title, the
skill-specific explanation, and reads/writes the `skill` tool’s own
rules.

## Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [ ] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [ ] Tests cover the new/changed behavior
- [ ] Performance impact has been considered and is acceptable

## Showcase

| Before | After |
|--------|--------|
| <img width="956" height="816" alt="image"
src="https://github.com/user-attachments/assets/e88ef051-aa5c-46de-9843-e3400fd63a7f"
/> | <img width="956" height="816" alt="image"
src="https://github.com/user-attachments/assets/77b8223d-bd97-4ac2-901d-15cf368341ec"
/> |

Closes #59720.

---

Release Notes:

- Fixed the Skill tool’s “Configure” button in the Agent’s Tool
Permissions settings opening the Terminal tool’s configuration instead
of the Skill tool’s own permission rules
This commit is contained in:
Kunall Banerjee authored and GitHub committed 2026-06-24 05:43:59 +00:00
1 parent 406a0c4ed7
commit a39a18de33
2 files changed
+4 -2

No files matched your search

+2 -2
View File
@@ -32,6 +32,6 @@ pub(crate) use tool_permissions_setup::render_tool_permissions_setup_page;
pub use tool_permissions_setup::{
render_copy_path_tool_config, render_create_directory_tool_config,
render_delete_path_tool_config, render_edit_file_tool_config, render_fetch_tool_config,
render_move_path_tool_config, render_terminal_tool_config, render_web_search_tool_config,
render_write_file_tool_config,
render_move_path_tool_config, render_skill_tool_config, render_terminal_tool_config,
render_web_search_tool_config, render_write_file_tool_config,
};
@@ -311,6 +311,7 @@ fn get_tool_render_fn(
"create_directory" => render_create_directory_tool_config,
"fetch" => render_fetch_tool_config,
"search_web" => render_web_search_tool_config,
"skill" => render_skill_tool_config,
_ => render_terminal_tool_config, // fallback
}
}
@@ -1388,6 +1389,7 @@ tool_config_page_fn!(render_move_path_tool_config, "move_path");
tool_config_page_fn!(render_create_directory_tool_config, "create_directory");
tool_config_page_fn!(render_fetch_tool_config, "fetch");
tool_config_page_fn!(render_web_search_tool_config, "search_web");
tool_config_page_fn!(render_skill_tool_config, "skill");
#[cfg(test)]
mod tests {