Kirill Bulatov
62707d9be9
Add LSP logs into the end of the editor, not after its caret
...
Also prevent tabs from being added in readonly editors
2024-01-15 22:12:52 +02:00
0e084ebd2f
Avoid panicking when closing a dragged tab
...
Co-Authored-By: Max <max@zed.dev >
Co-Authored-By: Nathan <nathan@zed.dev >
2024-01-15 19:46:34 +01:00
Antonio Scandurra
e4efad0856
Avoid retrieving layout bounds inside of right click menu event handler ( #4056 )
...
By the time the event handler is invoked, all information about the
rendered layout tree is gone.
Release Notes:
- N/A
2024-01-15 19:42:47 +01:00
Antonio Scandurra
5fd00b6fbc
Preserve tooltips requested by cached views ( #4055 )
...
Release Notes:
- N/A
2024-01-15 19:42:39 +01:00
6539892ad9
Avoid retrieving layout bounds inside of right click menu event handler
...
Co-Authored-By: Nathan <nathan@zed.dev >
Co-Authored-By: Max <max@zed.dev >
2024-01-15 19:27:18 +01:00
f3087a8cf7
Preserve tooltips requested by cached views
...
Co-Authored-By: Nathan <nathan@zed.dev >
Co-Authored-By: Max <max@zed.dev >
2024-01-15 19:19:27 +01:00
Thorsten Ball
862122bb6d
Fix unaligned close button in tab bar ( #4054 )
...
This fixes the close button not being vertically aligned in the tab bar.
## Before

## After

---
Release Notes:
- Fixed close-tab button not being vertically aligned in the tab bar.
2024-01-15 18:24:44 +01:00
Thorsten Ball and Marshall
84220a83eb
Fix unaligned close button in tab bar
...
Co-authored-by: Marshall <marshall@zed.dev >
2024-01-15 18:16:41 +01:00
Marshall Bowers
dc67b7bcaa
Rename h_stack and v_stack to h_flex and v_flex, respectively ( #4053 )
...
This PR renames the `h_stack` and `v_stack` to `h_flex` and `v_flex`,
respectively.
We were previously using `h_stack` and `v_stack` to match SwiftUI, but
`h_flex` and `v_flex` fit better with the web/flexbox terminology that
the rest of GPUI uses.
Additionally, we were already calling the utility functions used to
implement `h_stack` and `v_stack` by the new names.
Release Notes:
- N/A
2024-01-15 11:34:06 -05:00
Marshall Bowers
2999a0fd58
Make tab close button square ( #4052 )
...
This PR makes the close button for tabs square.
`IconButton` now accepts a `shape`, and using `IconButtonShape::Square`
will ensure the `IconButton` is square with respect to its contained
icon.
#### Before
<img width="119" alt="Screenshot 2024-01-15 at 10 32 40 AM"
src="https://github.com/zed-industries/zed/assets/1486634/dc806b9b-411f-4cd9-8c10-676d2cbd298b ">
#### After
<img width="116" alt="Screenshot 2024-01-15 at 10 32 24 AM"
src="https://github.com/zed-industries/zed/assets/1486634/8b4ef43c-14b6-449f-a235-5d7affd82c4e ">
Release Notes:
- Changed the tab close button to be square.
2024-01-15 10:43:03 -05:00
Antonio Scandurra
410faa43a1
Rebuild shader header when cbindgen sources have changed ( #4051 )
...
This was causing the Metal shaders to incorrectly interpret the
primitives submitted by GPUI, which in turn caused rendering to be
completely borked.
Release Notes:
- N/A
2024-01-15 16:32:09 +01:00
Julia
b528a20102
Prevent storybook dialog from swallowing terminal cursor when ctrl-c-ed ( #4050 )
...
Honestly thought this was a bug with our terminal port lol. Turns out
its an oversight in the `dialoguer` crate but its seems pretty easy to
work around so might as well
Release Notes:
- N/A
2024-01-15 10:25:11 -05:00
Antonio Scandurra and Thorsten
90e010b532
Rebuild shader header when cbindgen sources have changed
...
Co-Authored-By: Thorsten <thorsten@zed.dev >
2024-01-15 16:23:22 +01:00
Julia
fdb2cfe3d5
Prevent storybook dialog from swallowing terminal cursor when ctrl-c-ed
2024-01-15 10:19:08 -05:00
Piotr Osiewicz
f8791b44f5
gpui: Pin to font-kit with improved OTC parsing performance. ( #4047 )
...
Details are in https://github.com/zed-industries/font-kit/pull/1 ; We're
not doing anything too fancy, really. Still, you should mostly see font
loading times drop significantly for font collections
Release Notes:
- Improved loading performance of large font collections (e.g. Iosevka).
Fixes https://github.com/zed-industries/community/issues/1745 ,
https://github.com/zed-industries/community/issues/246
https://github.com/zed-industries/zed/assets/24362066/f70edbad-ded6-4c12-9c6d-7a487f330a1b
2024-01-15 15:46:18 +01:00
Kirill Bulatov
710ca4ef77
Do not run squawk tests outside of PR builds ( #4049 )
...
Release Notes:
- N/A
2024-01-15 16:24:15 +02:00
Kirill Bulatov
57d00e1480
Do not run squawk tests outside of PR builds
2024-01-15 16:20:53 +02:00
Kirill Bulatov
7755e5145e
Disable copilot for feedback and lsp log editors ( #4048 )
...
LSP log editor caused recursive flood of messages, and feedback editor
is better with people writing their own feedback.
Release Notes:
- Fixed hanging due to excessive logs when browsing Copilot LSP logs
2024-01-15 15:59:27 +02:00
Kirill Bulatov
e5827c49ff
Disable copilot for feedback and lsp log editors
...
LSP log editor caused recursive flood of messages, and feedback editor is better with people writing their own feedback.
2024-01-15 15:49:23 +02:00
Thorsten Ball
b0976f74cb
Fix editor stealing click events from copy-error button ( #4046 )
...
This fixes the click event on the "copy error message" button by
changing the `editor` element to ignore mouse-down events when the
default was prevented. That's similar to how `div` does it.
Release Notes:
- Fixed a bug that prevented "copy error message" button from being
clicked.
2024-01-15 14:03:15 +01:00
Thorsten Ball and Antonio
530638a765
Fix editor stealing click events from copy-error button
...
Co-authored-by: Antonio <antonio@zed.dev >
2024-01-15 13:47:09 +01:00
Antonio Scandurra
3a27bbd105
Introduce view caching ( #4019 )
...
<img width="996" alt="image"
src="https://github.com/zed-industries/zed/assets/482957/a5683382-6ff1-4558-9e9b-ebc17bc00289 ">
TODO:
- [x] Fix rename editor not updating
Release Notes:
- Improved rendering performance when editing.
2024-01-15 13:26:08 +01:00
Antonio Scandurra and Thorsten
4ba5fbd20e
Pop node from dispatch tree during cx.paint_view
...
Co-Authored-By: Thorsten <thorsten@zed.dev >
2024-01-15 11:46:46 +01:00
Antonio Scandurra
9526dee28b
Merge remote-tracking branch 'origin/main' into cache
...
# Conflicts:
# crates/gpui/src/elements/div.rs
2024-01-15 11:37:46 +01:00
Conrad Irwin
14f097db8b
Try sqwauk ( #4032 )
...
It'd be nice to automatically get warned if you're about to do a
backward incompatible migration mistakenly, and sqauwk does exactly
that.
Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/ <public_issue_number_if_exists>)).
2024-01-14 13:54:35 -07:00
Conrad Irwin
4704e268d2
chat panel ++ ( #4044 )
...
- Update chat panel with current channel
- Open chat panel for guests
- Open chat when joining a channel with guests
- Some tweaks for chat panels
- Don't lose focus on default panel state
- Make chat prettier (to my eyes at least)
- Fix multiple mentions in one message
- Show a border when scrolled in chat
- Fix re-docking chat panel
- Move settings subscription to dock
[[PR Description]]
Release Notes:
- Opens chat by default when joining a public channel
- Improves chat panel UI
2024-01-14 13:54:10 -07:00
Conrad Irwin
3378cab3f7
Fix tests for TestPanel
2024-01-14 12:26:54 -07:00
Conrad Irwin
50c4f07c95
Default to Zed Sans for UI ( #4045 )
...
Release Notes:
- Improve legibility of default UI font
2024-01-14 12:22:32 -07:00
Conrad Irwin
d1d9c3fca6
Remove unused imports
2024-01-13 22:44:47 -07:00
Conrad Irwin
d6d8d41808
Move settings subscription to dock
...
Reduces likelihood of panels being unable to move themselves
2024-01-13 22:41:26 -07:00
Conrad Irwin
0fdbce875b
Default to Zed Sans for UI
2024-01-13 22:38:22 -07:00
Conrad Irwin
39c6156210
Fix re-docking chat panel
2024-01-13 22:26:25 -07:00
Conrad Irwin
2ea8c1baee
Show a border when scrolled in chat
2024-01-13 22:19:21 -07:00
Conrad Irwin
d97618364c
Fix multiple mentions in one message
2024-01-13 21:53:22 -07:00
Conrad Irwin
7f6968d1a5
Make chat prettier (to my eyes at least)
2024-01-13 21:37:13 -07:00
Conrad Irwin
974b969a3a
Don't lose focus on default panel state
2024-01-13 14:32:24 -07:00
Mikayla Maki
2e09d65fce
Restore temp file initialization in telemetry code ( #4043 )
...
Release Notes:
- Fix 'open telemetry log' command to actually show the telemetry log.
2024-01-13 09:04:08 -08:00
Mikayla
610455254b
Don't open files unescessary in dev builds
2024-01-12 22:47:07 -08:00
Mikayla
3c34f6282d
Restore temp file initialization in telemetry code
2024-01-12 21:37:09 -08:00
Mikayla Maki
c9db609074
Disable searches for '.' in the terminal. ( #4042 )
...
Release Notes:
- N/A A crash that could occur when searching for '.' in the terminal
with a large monitor.
2024-01-12 21:17:10 -08:00
Mikayla
e97cc63aaa
Disable searches for '.', so that users with large monitors don't accidentally crash the terminal when searching for dot files.
2024-01-12 21:12:02 -08:00
Mikayla Maki
414ef53f24
Remove last commented code ( #4041 )
...
Release Notes:
- N/A
2024-01-12 21:08:39 -08:00
Mikayla
461f30f2e2
fmt
2024-01-12 21:02:01 -08:00
Mikayla
6f891a3553
Remove last stale code
2024-01-12 20:59:19 -08:00
Mikayla
4a824521f3
remove more commented code
2024-01-12 20:10:40 -08:00
Mikayla
8604fcac41
Remove some comments
2024-01-12 20:10:40 -08:00
Max Brunsfeld
80647be85a
Don't initialize audio crate in integration tests
...
Otherwise, a lot of time is spent in Audio::play_sound
2024-01-12 17:29:33 -08:00
Nathan Sobo
af22ac93a5
fix bounds checks ( #4038 )
...
Ensure we `panic()` instead of crash on graphics memory buffer overflow
Also bump the buffer size to 32Mb from 8Mb to make this rarer (but still
possible)
Release Notes: Fixes some crahes due to lack of graphics buffer spacae
2024-01-12 15:28:19 -08:00
Max Brunsfeld
dac7d53250
Don't run newly published audio tracks when deafened
...
Also, simplify the management of the muted and deafened state in Room.
2024-01-12 15:12:29 -08:00
Conrad Irwin
b024e2e866
Some tweaks for chat panels
2024-01-12 16:01:51 -07:00