Brandt WearyandHector
fcb7e60384
## Summary Extends #46011 to make folds survive tab close and workspace cleanup. - Adds `file_folds` table keyed by `(workspace_id, path)` instead of `editor_id` - Follows the `breakpoints` table pattern in `workspace/src/persistence.rs` - Includes backwards-compatible migration from `editor_folds` on first read cc @Veykril - you reviewed the original fold persistence PR, this extends it to handle the tab-close case. ## Problem Folds stored by `editor_id` get deleted when: 1. User closes a tab 2. Tab is removed from workspace serialization 3. On next Zed start, `cleanup()` deletes editor rows not in `loaded_items` 4. `ON DELETE CASCADE` wipes associated folds 5. User manually reopens file → folds gone This is especially painful for PKM/notes workflows where folds represent permanent document structure (collapsed sections, reference blocks, etc). ## Solution Store folds by file path, not editor ID. The `breakpoints` table already proves this pattern works in Zed - breakpoints persist across tab close because they're keyed by path. ## Migration The PR includes backwards-compatible migration: reads from `file_folds` first, falls back to `get_editor_folds()`, and migrates old data on first read. Happy to remove this if you'd prefer a clean break - I'd delete `get_editor_folds()`, remove the fallback logic in `read_metadata_from_db()`, and add a `DROP TABLE IF EXISTS editor_folds` migration. Users would lose any folds saved before the update. ## Test Plan - [x] Unit test for `file_folds` queries in `persistence.rs` - [x] Manual test: Open file → fold → close tab → quit Zed → reopen → manually open file → folds restored Release Notes: - N/A Co-authored-by: Hector <hector@cyberneticwilderness.com>
Zed
Welcome to Zed, a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
Installation
On macOS, Linux, and Windows you can download Zed directly or install Zed via your local package manager (macOS/Linux/Windows).
Other platforms are not yet available:
- Web (tracking issue)
Developing Zed
Contributing
See CONTRIBUTING.md for ways you can contribute to Zed.
Also... we're hiring! Check out our jobs page for open roles.
Licensing
License information for third party dependencies must be correctly provided for CI to pass.
We use cargo-about to automatically comply with open source licenses. If CI is failing, check the following:
- Is it showing a
no license specifiederror for a crate you've created? If so, addpublish = falseunder[package]in your crate's Cargo.toml. - Is the error
failed to satisfy license requirementsfor a dependency? If so, first determine what license the project has and whether this system is sufficient to comply with this license's requirements. If you're unsure, ask a lawyer. Once you've verified that this system is acceptable add the license's SPDX identifier to theacceptedarray inscript/licenses/zed-licenses.toml. - Is
cargo-aboutunable to find the license for a dependency? If so, add a clarification field at the end ofscript/licenses/zed-licenses.toml, as specified in the cargo-about book.
Sponsorship
Zed is developed by Zed Industries, Inc., a for-profit company.
If you’d like to financially support the project, you can do so via GitHub Sponsors. Sponsorships go directly to Zed Industries and are used as general company revenue. There are no perks or entitlements associated with sponsorship.